Compare commits
24
Commits
7.58
...
8f4ce63da5
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
8f4ce63da5 | ||
|
|
6385bc5267 | ||
|
|
5656f5a68a | ||
|
|
fd5d68d5e9 | ||
|
|
7b1e954f7f | ||
|
|
1be79e1e06 | ||
|
|
be8ccebfac | ||
|
|
04c585f500 | ||
|
|
65ff1558e4 | ||
|
|
6b93e345cd | ||
|
|
438237e852 | ||
|
|
cc3b64a193 | ||
|
|
aa5c4a5a74 | ||
|
|
4e0d4316d6 | ||
|
|
27bffaa4dc | ||
|
|
a8891db014 | ||
|
|
54c778223d | ||
|
|
a40774a820 | ||
|
|
f466459072 | ||
|
|
d5096cf9ad | ||
|
|
a163542966 | ||
|
|
f7ae17e6c4 | ||
|
|
fdd2f67cc6 | ||
|
|
8fb74fdf95 |
@@ -6,3 +6,6 @@ sites/*/files
|
||||
sites/*/private
|
||||
sites/*/tmp
|
||||
|
||||
error/
|
||||
|
||||
**.tar.gz
|
||||
|
||||
+139
-1
@@ -1,7 +1,145 @@
|
||||
Drupal 7.80, 2021-04-20
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2021-002
|
||||
|
||||
Drupal 7.79, 2021-04-07
|
||||
-----------------------
|
||||
- Initial support for PHP 8
|
||||
- Support for SameSite cookie attribute
|
||||
- Avoid write for unchanged fields (opt-in)
|
||||
|
||||
Drupal 7.78, 2021-01-19
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2021-001
|
||||
|
||||
Drupal 7.77, 2020-12-03
|
||||
-----------------------
|
||||
- Hotfix for schema.prefixed tables
|
||||
|
||||
Drupal 7.76, 2020-12-02
|
||||
-----------------------
|
||||
- Support for MySQL 8
|
||||
- Core tests pass in SQLite
|
||||
- Better user flood control logging
|
||||
|
||||
Drupal 7.75, 2020-11-26
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2020-013
|
||||
|
||||
Drupal 7.74, 2020-11-17
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2020-012
|
||||
|
||||
Drupal 7.73, 2020-09-16
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2020-007
|
||||
|
||||
Drupal 7.72, 2020-06-17
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2020-004
|
||||
|
||||
Drupal 7.71, 2020-06-03
|
||||
-----------------------
|
||||
- Fix for jQuery Form bug in Chromium-based browsers
|
||||
- Full support for PHP 7.4
|
||||
|
||||
Drupal 7.70, 2020-05-19
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2020-002
|
||||
- SA-CORE-2020-003
|
||||
|
||||
Drupal 7.69, 2019-12-18
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2019-012
|
||||
|
||||
Drupal 7.68, 2019-12-04
|
||||
-----------------------
|
||||
- Fixed: Hide toolbar when printing
|
||||
- Fixed: Settings returned via ajax are not run through hook_js_alter()
|
||||
- Fixed: Use drupal_http_build_query() in drupal_http_request()
|
||||
- Fixed: DrupalRequestSanitizer not found fatal error when bootstrap phase order is changed
|
||||
- Fixed: Block web.config in .htaccess (and vice-versa)
|
||||
- Fixed: Create "scripts" element to align rendering workflow to how "styles" are handled
|
||||
- PHP 7.3: Fixed 'Cannot change session id when session is active'
|
||||
- PHP 7.1: Fixed 'A non-numeric value encountered in theme_pager()'
|
||||
- PHP 7.x: Fixed file.inc generated .htaccess does not cover PHP 7
|
||||
- PHP 5.3: Fixed check_plain() 'Invalid multibyte sequence in argument' test failures
|
||||
- Fixed: Allow passing data as array to drupal_http_request()
|
||||
- Fixed: Skip module_invoke/module_hook in calling hook_watchdog (excessive function_exist)
|
||||
- Fixed: HTTP status 200 returned for 'Additional uncaught exception thrown while handling exception'
|
||||
- Fixed: theme_table() should take an optional footer variable and produce <tfoot>
|
||||
- Fixed: 'uasort() expects parameter 1 to be array, null given in node_view_multiple()'
|
||||
- [regression] Fix default.settings.php permission
|
||||
|
||||
Drupal 7.67, 2019-05-08
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2019-007
|
||||
|
||||
Drupal 7.66, 2019-04-17
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2019-006
|
||||
|
||||
Drupal 7.65, 2019-03-20
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2019-004
|
||||
|
||||
Drupal 7.64, 2019-02-06
|
||||
-----------------------
|
||||
- [regression] Unset the 'host' header in drupal_http_request() during redirect
|
||||
- Fixed: 7.x does not have Phar protection and Phar tests are failing on Drupal 7
|
||||
- Fixed: Notice: Undefined index: display_field in file_field_widget_value() (line 582 of /module/file/file.field.inc)
|
||||
- Performance improvement: Registry rebuild should not parse the same file twice in the same request
|
||||
- Fixed _registry_update() to clear caches after transaction is committed
|
||||
|
||||
Drupal 7.63, 2019-01-16
|
||||
-----------------------
|
||||
- Fixed a fatal error for some Drush users introduced by SA-CORE-2019-002.
|
||||
|
||||
Drupal 7.62, 2019-01-15
|
||||
-----------------------
|
||||
- Fixed security issues:
|
||||
- SA-CORE-2019-001
|
||||
- SA-CORE-2019-002
|
||||
|
||||
Drupal 7.61, 2018-11-07
|
||||
-----------------------
|
||||
- File upload validation functions and hook_file_validate() implementations are
|
||||
now always passed the correct file URI.
|
||||
- The default form cache expiration of 6 hours is now configurable (API
|
||||
addition: https://www.drupal.org/node/2857751).
|
||||
- Allowed callers of drupal_http_request() to optionally specify an explicit
|
||||
Host header.
|
||||
- Allowed the + character to appear in usernames.
|
||||
- PHP 7.2: Fixed Archive_Tar incompatibility.
|
||||
- PHP 7.2: Removed deprecated function each().
|
||||
- PHP 7.2: Avoid count() calls on uncountable variables.
|
||||
- PHP 7.2: Removed deprecated create_function() call.
|
||||
- PHP 7.2: Make sure variables are arrays in theme_links().
|
||||
- Fixed theme-settings.php not being loaded on cached forms
|
||||
- Fixed problem with IE11 & Chrome(PointerEvents enabled) & some Firefox scroll to the top of the page after dragging the bottom item with jquery 1.5 <-> 1.11
|
||||
|
||||
Drupal 7.60, 2018-10-18
|
||||
------------------------
|
||||
- Fixed security issues. See SA-CORE-2018-006.
|
||||
|
||||
Drupal 7.59, 2018-04-25
|
||||
-----------------------
|
||||
- Fixed security issues (remote code execution). See SA-CORE-2018-004.
|
||||
|
||||
Drupal 7.58, 2018-03-28
|
||||
-----------------------
|
||||
- Fixed security issues (multiple vulnerabilities). See SA-CORE-2018-002.
|
||||
- Fixed security issues (remote code execution). See SA-CORE-2018-002.
|
||||
|
||||
Drupal 7.57, 2018-02-21
|
||||
-----------------------
|
||||
|
||||
+2
-5
@@ -11,10 +11,8 @@ The Drupal Core branch maintainers oversee the development of Drupal as a whole.
|
||||
The branch maintainers for Drupal 7 are:
|
||||
|
||||
- Dries Buytaert 'dries' https://www.drupal.org/u/dries
|
||||
- Angela Byron 'webchick' https://www.drupal.org/u/webchick
|
||||
- Fabian Franz 'Fabianx' https://www.drupal.org/u/fabianx
|
||||
- David Rothstein 'David_Rothstein' https://www.drupal.org/u/david_rothstein
|
||||
- Stefan Ruijsenaars 'stefan.r' https://www.drupal.org/u/stefanr-0
|
||||
- Drew Webber 'mcdruid' https://www.drupal.org/u/mcdruid
|
||||
|
||||
|
||||
Component maintainers
|
||||
@@ -44,10 +42,9 @@ Cron system
|
||||
- Derek Wright 'dww' https://www.drupal.org/u/dww
|
||||
|
||||
Database system
|
||||
- Larry Garfield 'Crell' https://www.drupal.org/u/crell
|
||||
- ?
|
||||
|
||||
- MySQL driver
|
||||
- Larry Garfield 'Crell' https://www.drupal.org/u/crell
|
||||
- David Strauss 'David Strauss' https://www.drupal.org/u/david-strauss
|
||||
|
||||
- PostgreSQL driver
|
||||
|
||||
@@ -1 +0,0 @@
|
||||
google-site-verification: google5c59d2e455c34eaa.html
|
||||
@@ -294,6 +294,7 @@ function ajax_render($commands = array()) {
|
||||
|
||||
// Now add a command to merge changes and additions to Drupal.settings.
|
||||
$scripts = drupal_add_js();
|
||||
drupal_alter('js', $scripts);
|
||||
if (!empty($scripts['settings'])) {
|
||||
$settings = $scripts['settings'];
|
||||
array_unshift($commands, ajax_command_settings(drupal_array_merge_deep_array($settings['data']), TRUE));
|
||||
|
||||
+7
-8
@@ -478,18 +478,17 @@ function _batch_finished() {
|
||||
$queue->deleteQueue();
|
||||
}
|
||||
}
|
||||
// Clean-up the session. Not needed for CLI updates.
|
||||
if (isset($_SESSION)) {
|
||||
unset($_SESSION['batches'][$batch['id']]);
|
||||
if (empty($_SESSION['batches'])) {
|
||||
unset($_SESSION['batches']);
|
||||
}
|
||||
}
|
||||
}
|
||||
$_batch = $batch;
|
||||
$batch = NULL;
|
||||
|
||||
// Clean-up the session. Not needed for CLI updates.
|
||||
if (isset($_SESSION)) {
|
||||
unset($_SESSION['batches'][$batch['id']]);
|
||||
if (empty($_SESSION['batches'])) {
|
||||
unset($_SESSION['batches']);
|
||||
}
|
||||
}
|
||||
|
||||
// Redirect if needed.
|
||||
if ($_batch['progressive']) {
|
||||
// Revert the 'destination' that was saved in batch_process().
|
||||
|
||||
+124
-19
@@ -8,7 +8,7 @@
|
||||
/**
|
||||
* The current system version.
|
||||
*/
|
||||
define('VERSION', '7.58');
|
||||
define('VERSION', '7.80');
|
||||
|
||||
/**
|
||||
* Core API compatibility.
|
||||
@@ -704,6 +704,19 @@ function drupal_environment_initialize() {
|
||||
// Set sane locale settings, to ensure consistent string, dates, times and
|
||||
// numbers handling.
|
||||
setlocale(LC_ALL, 'C');
|
||||
|
||||
// PHP's built-in phar:// stream wrapper is not sufficiently secure. Override
|
||||
// it with a more secure one, which requires PHP 5.3.3. For lower versions,
|
||||
// unregister the built-in one without replacing it. Sites needing phar
|
||||
// support for lower PHP versions must implement hook_stream_wrappers() to
|
||||
// register their desired implementation.
|
||||
if (in_array('phar', stream_get_wrappers(), TRUE)) {
|
||||
stream_wrapper_unregister('phar');
|
||||
if (version_compare(PHP_VERSION, '5.3.3', '>=')) {
|
||||
include_once DRUPAL_ROOT . '/includes/file.phar.inc';
|
||||
file_register_phar_wrapper();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -1176,19 +1189,21 @@ function variable_initialize($conf = array()) {
|
||||
$variables = $cached->data;
|
||||
}
|
||||
else {
|
||||
// Cache miss. Avoid a stampede.
|
||||
// Cache miss. Avoid a stampede by acquiring a lock. If the lock fails to
|
||||
// acquire, optionally just continue with uncached processing.
|
||||
$name = 'variable_init';
|
||||
if (!lock_acquire($name, 1)) {
|
||||
// Another request is building the variable cache.
|
||||
// Wait, then re-run this function.
|
||||
$lock_acquired = lock_acquire($name, 1);
|
||||
if (!$lock_acquired && variable_get('variable_initialize_wait_for_lock', FALSE)) {
|
||||
lock_wait($name);
|
||||
return variable_initialize($conf);
|
||||
}
|
||||
else {
|
||||
// Proceed with variable rebuild.
|
||||
// Load the variables from the table.
|
||||
$variables = array_map('unserialize', db_query('SELECT name, value FROM {variable}')->fetchAllKeyed());
|
||||
cache_set('variables', $variables, 'cache_bootstrap');
|
||||
lock_release($name);
|
||||
if ($lock_acquired) {
|
||||
cache_set('variables', $variables, 'cache_bootstrap');
|
||||
lock_release($name);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1985,7 +2000,7 @@ function watchdog($type, $message, $variables = array(), $severity = WATCHDOG_NO
|
||||
|
||||
// It is possible that the error handling will itself trigger an error. In that case, we could
|
||||
// end up in an infinite loop. To avoid that, we implement a simple static semaphore.
|
||||
if (!$in_error_state && function_exists('module_implements')) {
|
||||
if (!$in_error_state && function_exists('module_invoke_all')) {
|
||||
$in_error_state = TRUE;
|
||||
|
||||
// The user object may not exist in all conditions, so 0 is substituted if needed.
|
||||
@@ -2008,9 +2023,7 @@ function watchdog($type, $message, $variables = array(), $severity = WATCHDOG_NO
|
||||
);
|
||||
|
||||
// Call the logging hooks to log/process the message
|
||||
foreach (module_implements('watchdog') as $module) {
|
||||
module_invoke($module, 'watchdog', $log_entry);
|
||||
}
|
||||
module_invoke_all('watchdog', $log_entry);
|
||||
|
||||
// It is critical that the semaphore is only cleared here, in the parent
|
||||
// watchdog() call (not outside the loop), to prevent recursive execution.
|
||||
@@ -2505,6 +2518,7 @@ function drupal_bootstrap($phase = NULL, $new_phase = TRUE) {
|
||||
|
||||
switch ($current_phase) {
|
||||
case DRUPAL_BOOTSTRAP_CONFIGURATION:
|
||||
require_once DRUPAL_ROOT . '/includes/request-sanitizer.inc';
|
||||
_drupal_bootstrap_configuration();
|
||||
break;
|
||||
|
||||
@@ -2582,13 +2596,10 @@ function drupal_get_hash_salt() {
|
||||
* The filename that the error was raised in.
|
||||
* @param $line
|
||||
* The line number the error was raised at.
|
||||
* @param $context
|
||||
* An array that points to the active symbol table at the point the error
|
||||
* occurred.
|
||||
*/
|
||||
function _drupal_error_handler($error_level, $message, $filename, $line, $context) {
|
||||
function _drupal_error_handler($error_level, $message, $filename, $line) {
|
||||
require_once DRUPAL_ROOT . '/includes/errors.inc';
|
||||
_drupal_error_handler_real($error_level, $message, $filename, $line, $context);
|
||||
_drupal_error_handler_real($error_level, $message, $filename, $line);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -2609,6 +2620,10 @@ function _drupal_exception_handler($exception) {
|
||||
_drupal_log_error(_drupal_decode_exception($exception), TRUE);
|
||||
}
|
||||
catch (Exception $exception2) {
|
||||
// Add a 500 status code in case an exception was thrown before the 500
|
||||
// status could be set (e.g. while loading a maintenance theme from cache).
|
||||
drupal_add_http_header('Status', '500 Internal Server Error');
|
||||
|
||||
// Another uncaught exception was thrown while handling the first one.
|
||||
// If we are displaying errors, then do so with no possibility of a further uncaught exception being thrown.
|
||||
if (error_displayable()) {
|
||||
@@ -2634,7 +2649,6 @@ function _drupal_bootstrap_configuration() {
|
||||
drupal_settings_initialize();
|
||||
|
||||
// Sanitize unsafe keys from the request.
|
||||
require_once DRUPAL_ROOT . '/includes/request-sanitizer.inc';
|
||||
DrupalRequestSanitizer::sanitize();
|
||||
}
|
||||
|
||||
@@ -2778,6 +2792,11 @@ function _drupal_bootstrap_variables() {
|
||||
unset($_GET['destination']);
|
||||
unset($_REQUEST['destination']);
|
||||
}
|
||||
// Use the DrupalRequestSanitizer to ensure that the destination's query
|
||||
// parameters are not dangerous.
|
||||
if (isset($_GET['destination'])) {
|
||||
DrupalRequestSanitizer::cleanDestination();
|
||||
}
|
||||
// If there's still something in $_REQUEST['destination'] that didn't come
|
||||
// from $_GET, check it too.
|
||||
if (isset($_REQUEST['destination']) && (!isset($_GET['destination']) || $_REQUEST['destination'] != $_GET['destination']) && url_is_external($_REQUEST['destination'])) {
|
||||
@@ -3780,8 +3799,12 @@ function _drupal_shutdown_function() {
|
||||
chdir(DRUPAL_ROOT);
|
||||
|
||||
try {
|
||||
while (list($key, $callback) = each($callbacks)) {
|
||||
// Manually iterate over the array instead of using a foreach loop.
|
||||
// A foreach operates on a copy of the array, so any shutdown functions that
|
||||
// were added from other shutdown functions would never be called.
|
||||
while ($callback = current($callbacks)) {
|
||||
call_user_func_array($callback['callback'], $callback['arguments']);
|
||||
next($callbacks);
|
||||
}
|
||||
}
|
||||
catch (Exception $exception) {
|
||||
@@ -3853,3 +3876,85 @@ function drupal_clear_opcode_cache($filepath) {
|
||||
@apc_delete_file($filepath);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Drupal's wrapper around PHP's setcookie() function.
|
||||
*
|
||||
* This allows the cookie's $value and $options to be altered.
|
||||
*
|
||||
* @param $name
|
||||
* The name of the cookie.
|
||||
* @param $value
|
||||
* The value of the cookie.
|
||||
* @param $options
|
||||
* An associative array which may have any of the keys expires, path, domain,
|
||||
* secure, httponly, samesite.
|
||||
*
|
||||
* @see setcookie()
|
||||
* @ingroup php_wrappers
|
||||
*/
|
||||
function drupal_setcookie($name, $value, $options) {
|
||||
$options = _drupal_cookie_params($options);
|
||||
if (\PHP_VERSION_ID >= 70300) {
|
||||
setcookie($name, $value, $options);
|
||||
}
|
||||
else {
|
||||
setcookie($name, $value, $options['expires'], $options['path'], $options['domain'], $options['secure'], $options['httponly']);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Process the params for cookies. This emulates support for the SameSite
|
||||
* attribute in earlier versions of PHP, and allows the value of that attribute
|
||||
* to be overridden.
|
||||
*
|
||||
* @param $options
|
||||
* An associative array which may have any of the keys expires, path, domain,
|
||||
* secure, httponly, samesite.
|
||||
*
|
||||
* @return
|
||||
* An associative array which may have any of the keys expires, path, domain,
|
||||
* secure, httponly, and samesite.
|
||||
*/
|
||||
function _drupal_cookie_params($options) {
|
||||
$options['samesite'] = _drupal_samesite_cookie($options);
|
||||
if (\PHP_VERSION_ID < 70300) {
|
||||
// Emulate SameSite support in older PHP versions.
|
||||
if (!empty($options['samesite'])) {
|
||||
// Ensure the SameSite attribute is only added once.
|
||||
if (!preg_match('/SameSite=/i', $options['path'])) {
|
||||
$options['path'] .= '; SameSite=' . $options['samesite'];
|
||||
}
|
||||
}
|
||||
}
|
||||
return $options;
|
||||
}
|
||||
|
||||
/**
|
||||
* Determine the value for the samesite cookie attribute, in the following order
|
||||
* of precedence:
|
||||
*
|
||||
* 1) A value explicitly passed to drupal_setcookie()
|
||||
* 2) A value set in $conf['samesite_cookie_value']
|
||||
* 3) The setting from php ini
|
||||
* 4) The default of None, or FALSE (no attribute) if the cookie is not Secure
|
||||
*
|
||||
* @param $options
|
||||
* An associative array as passed to drupal_setcookie().
|
||||
* @return
|
||||
* The value for the samesite cookie attribute.
|
||||
*/
|
||||
function _drupal_samesite_cookie($options) {
|
||||
if (isset($options['samesite'])) {
|
||||
return $options['samesite'];
|
||||
}
|
||||
$override = variable_get('samesite_cookie_value', NULL);
|
||||
if ($override !== NULL) {
|
||||
return $override;
|
||||
}
|
||||
$ini_options = session_get_cookie_params();
|
||||
if (isset($ini_options['samesite'])) {
|
||||
return $ini_options['samesite'];
|
||||
}
|
||||
return empty($options['secure']) ? FALSE : 'None';
|
||||
}
|
||||
|
||||
+150
-56
@@ -391,7 +391,7 @@ function drupal_add_feed($url = NULL, $title = '') {
|
||||
*/
|
||||
function drupal_get_feeds($delimiter = "\n") {
|
||||
$feeds = drupal_add_feed();
|
||||
return implode($feeds, $delimiter);
|
||||
return implode($delimiter, $feeds);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -611,8 +611,9 @@ function drupal_parse_url($url) {
|
||||
}
|
||||
// The 'q' parameter contains the path of the current page if clean URLs are
|
||||
// disabled. It overrides the 'path' of the URL when present, even if clean
|
||||
// URLs are enabled, due to how Apache rewriting rules work.
|
||||
if (isset($options['query']['q'])) {
|
||||
// URLs are enabled, due to how Apache rewriting rules work. The path
|
||||
// parameter must be a string.
|
||||
if (isset($options['query']['q']) && is_string($options['query']['q'])) {
|
||||
$options['path'] = $options['query']['q'];
|
||||
unset($options['query']['q']);
|
||||
}
|
||||
@@ -683,7 +684,10 @@ function drupal_goto($path = '', array $options = array(), $http_response_code =
|
||||
// We do not allow absolute URLs to be passed via $_GET, as this can be an attack vector.
|
||||
if (isset($_GET['destination']) && !url_is_external($_GET['destination'])) {
|
||||
$destination = drupal_parse_url($_GET['destination']);
|
||||
$path = $destination['path'];
|
||||
// Double check the path derived by drupal_parse_url() is not external.
|
||||
if (!url_is_external($destination['path'])) {
|
||||
$path = $destination['path'];
|
||||
}
|
||||
$options['query'] = $destination['query'];
|
||||
$options['fragment'] = $destination['fragment'];
|
||||
}
|
||||
@@ -759,9 +763,10 @@ function drupal_access_denied() {
|
||||
* (optional) An array that can have one or more of the following elements:
|
||||
* - headers: An array containing request headers to send as name/value pairs.
|
||||
* - method: A string containing the request method. Defaults to 'GET'.
|
||||
* - data: A string containing the request body, formatted as
|
||||
* 'param=value¶m=value&...'; to generate this, use http_build_query().
|
||||
* Defaults to NULL.
|
||||
* - data: An array containing the values for the request body or a string
|
||||
* containing the request body, formatted as
|
||||
* 'param=value¶m=value&...'; to generate this, use
|
||||
* drupal_http_build_query(). Defaults to NULL.
|
||||
* - max_redirects: An integer representing how many times a redirect
|
||||
* may be followed. Defaults to 3.
|
||||
* - timeout: A float representing the maximum number of seconds the function
|
||||
@@ -787,7 +792,7 @@ function drupal_access_denied() {
|
||||
* easy access the array keys are returned in lower case.
|
||||
* - data: A string containing the response body that was received.
|
||||
*
|
||||
* @see http_build_query()
|
||||
* @see drupal_http_build_query()
|
||||
*/
|
||||
function drupal_http_request($url, array $options = array()) {
|
||||
// Allow an alternate HTTP client library to replace Drupal's default
|
||||
@@ -866,8 +871,10 @@ function drupal_http_request($url, array $options = array()) {
|
||||
// Make the socket connection to a proxy server.
|
||||
$socket = 'tcp://' . $proxy_server . ':' . variable_get('proxy_port', 8080);
|
||||
// The Host header still needs to match the real request.
|
||||
$options['headers']['Host'] = $uri['host'];
|
||||
$options['headers']['Host'] .= isset($uri['port']) && $uri['port'] != 80 ? ':' . $uri['port'] : '';
|
||||
if (!isset($options['headers']['Host'])) {
|
||||
$options['headers']['Host'] = $uri['host'];
|
||||
$options['headers']['Host'] .= isset($uri['port']) && $uri['port'] != 80 ? ':' . $uri['port'] : '';
|
||||
}
|
||||
break;
|
||||
|
||||
case 'http':
|
||||
@@ -877,14 +884,18 @@ function drupal_http_request($url, array $options = array()) {
|
||||
// RFC 2616: "non-standard ports MUST, default ports MAY be included".
|
||||
// We don't add the standard port to prevent from breaking rewrite rules
|
||||
// checking the host that do not take into account the port number.
|
||||
$options['headers']['Host'] = $uri['host'] . ($port != 80 ? ':' . $port : '');
|
||||
if (!isset($options['headers']['Host'])) {
|
||||
$options['headers']['Host'] = $uri['host'] . ($port != 80 ? ':' . $port : '');
|
||||
}
|
||||
break;
|
||||
|
||||
case 'https':
|
||||
// Note: Only works when PHP is compiled with OpenSSL support.
|
||||
$port = isset($uri['port']) ? $uri['port'] : 443;
|
||||
$socket = 'ssl://' . $uri['host'] . ':' . $port;
|
||||
$options['headers']['Host'] = $uri['host'] . ($port != 443 ? ':' . $port : '');
|
||||
if (!isset($options['headers']['Host'])) {
|
||||
$options['headers']['Host'] = $uri['host'] . ($port != 443 ? ':' . $port : '');
|
||||
}
|
||||
break;
|
||||
|
||||
default:
|
||||
@@ -923,6 +934,11 @@ function drupal_http_request($url, array $options = array()) {
|
||||
$path .= '?' . $uri['query'];
|
||||
}
|
||||
|
||||
// Convert array $options['data'] to query string.
|
||||
if (is_array($options['data'])) {
|
||||
$options['data'] = drupal_http_build_query($options['data']);
|
||||
}
|
||||
|
||||
// Only add Content-Length if we actually have any content or if it is a POST
|
||||
// or PUT request. Some non-standard servers get confused by Content-Length in
|
||||
// at least HEAD/GET requests, and Squid always requires Content-Length in
|
||||
@@ -1087,6 +1103,11 @@ function drupal_http_request($url, array $options = array()) {
|
||||
elseif ($options['max_redirects']) {
|
||||
// Redirect to the new location.
|
||||
$options['max_redirects']--;
|
||||
|
||||
// We need to unset the 'Host' header
|
||||
// as we are redirecting to a new location.
|
||||
unset($options['headers']['Host']);
|
||||
|
||||
$result = drupal_http_request($location, $options);
|
||||
$result->redirect_code = $code;
|
||||
}
|
||||
@@ -1538,7 +1559,7 @@ function _filter_xss_split($m, $store = FALSE) {
|
||||
return '<';
|
||||
}
|
||||
|
||||
if (!preg_match('%^<\s*(/\s*)?([a-zA-Z0-9\-]+)([^>]*)>?|(<!--.*?-->)$%', $string, $matches)) {
|
||||
if (!preg_match('%^<\s*(/\s*)?([a-zA-Z0-9\-]+)\s*([^>]*)>?|(<!--.*?-->)$%', $string, $matches)) {
|
||||
// Seriously malformed.
|
||||
return '';
|
||||
}
|
||||
@@ -1597,7 +1618,13 @@ function _filter_xss_attributes($attr) {
|
||||
// Attribute name, href for instance.
|
||||
if (preg_match('/^([-a-zA-Z]+)/', $attr, $match)) {
|
||||
$attrname = strtolower($match[1]);
|
||||
$skip = ($attrname == 'style' || substr($attrname, 0, 2) == 'on');
|
||||
$skip = (
|
||||
$attrname == 'style' ||
|
||||
substr($attrname, 0, 2) == 'on' ||
|
||||
substr($attrname, 0, 1) == '-' ||
|
||||
// Ignore long attributes to avoid unnecessary processing overhead.
|
||||
strlen($attrname) > 96
|
||||
);
|
||||
$working = $mode = 1;
|
||||
$attr = preg_replace('/^[-a-zA-Z]+/', '', $attr);
|
||||
}
|
||||
@@ -2308,9 +2335,13 @@ function url($path = NULL, array $options = array()) {
|
||||
}
|
||||
elseif (!empty($path) && !$options['alias']) {
|
||||
$language = isset($options['language']) && isset($options['language']->language) ? $options['language']->language : '';
|
||||
require_once DRUPAL_ROOT . '/' . variable_get('path_inc', 'includes/path.inc');
|
||||
$alias = drupal_get_path_alias($original_path, $language);
|
||||
if ($alias != $original_path) {
|
||||
$path = $alias;
|
||||
// Strip leading slashes from internal path aliases to prevent them
|
||||
// becoming external URLs without protocol. /example.com should not be
|
||||
// turned into //example.com.
|
||||
$path = ltrim($alias, '/');
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3719,7 +3750,7 @@ function _drupal_build_css_path($matches, $base = NULL) {
|
||||
}
|
||||
|
||||
// Prefix with base and remove '../' segments where possible.
|
||||
$path = $_base . $matches[1];
|
||||
$path = $_base . (isset($matches[1]) ? $matches[1] : '');
|
||||
$last = '';
|
||||
while ($path != $last) {
|
||||
$last = $path;
|
||||
@@ -4426,12 +4457,54 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
}
|
||||
}
|
||||
|
||||
$output = '';
|
||||
// The index counter is used to keep aggregated and non-aggregated files in
|
||||
// order by weight.
|
||||
$index = 1;
|
||||
$processed = array();
|
||||
$files = array();
|
||||
// Sort the JavaScript so that it appears in the correct order.
|
||||
uasort($items, 'drupal_sort_css_js');
|
||||
|
||||
// Provide the page with information about the individual JavaScript files
|
||||
// used, information not otherwise available when aggregation is enabled.
|
||||
$setting['ajaxPageState']['js'] = array_fill_keys(array_keys($items), 1);
|
||||
unset($setting['ajaxPageState']['js']['settings']);
|
||||
drupal_add_js($setting, 'setting');
|
||||
|
||||
// If we're outputting the header scope, then this might be the final time
|
||||
// that drupal_get_js() is running, so add the setting to this output as well
|
||||
// as to the drupal_add_js() cache. If $items['settings'] doesn't exist, it's
|
||||
// because drupal_get_js() was intentionally passed a $javascript argument
|
||||
// stripped off settings, potentially in order to override how settings get
|
||||
// output, so in this case, do not add the setting to this output.
|
||||
if ($scope == 'header' && isset($items['settings'])) {
|
||||
$items['settings']['data'][] = $setting;
|
||||
}
|
||||
|
||||
$elements = array(
|
||||
'#type' => 'scripts',
|
||||
'#items' => $items,
|
||||
);
|
||||
|
||||
return drupal_render($elements);
|
||||
}
|
||||
|
||||
/**
|
||||
* The #pre_render callback for the "scripts" element.
|
||||
*
|
||||
* This callback adds elements needed for <script> tags to be rendered.
|
||||
*
|
||||
* @param array $elements
|
||||
* A render array containing:
|
||||
* - '#items': The JS items as returned by drupal_add_js() and altered by
|
||||
* drupal_get_js().
|
||||
*
|
||||
* @return array
|
||||
* The $elements variable passed as argument with two more children keys:
|
||||
* - "scripts": contains the Javascript items
|
||||
* - "settings": contains the Javascript settings items.
|
||||
* If those keys are already existing, then the items will be appended and
|
||||
* their keys will be preserved.
|
||||
*
|
||||
* @see drupal_get_js()
|
||||
* @see drupal_add_js()
|
||||
*/
|
||||
function drupal_pre_render_scripts(array $elements) {
|
||||
$preprocess_js = (variable_get('preprocess_js', FALSE) && (!defined('MAINTENANCE_MODE') || MAINTENANCE_MODE != 'update'));
|
||||
|
||||
// A dummy query-string is added to filenames, to gain control over
|
||||
@@ -4452,34 +4525,29 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
// third-party code might require the use of a different query string.
|
||||
$js_version_string = variable_get('drupal_js_version_query_string', 'v=');
|
||||
|
||||
// Sort the JavaScript so that it appears in the correct order.
|
||||
uasort($items, 'drupal_sort_css_js');
|
||||
$files = array();
|
||||
|
||||
// Provide the page with information about the individual JavaScript files
|
||||
// used, information not otherwise available when aggregation is enabled.
|
||||
$setting['ajaxPageState']['js'] = array_fill_keys(array_keys($items), 1);
|
||||
unset($setting['ajaxPageState']['js']['settings']);
|
||||
drupal_add_js($setting, 'setting');
|
||||
$scripts = isset($elements['scripts']) ? $elements['scripts'] : array();
|
||||
$scripts += array('#weight' => 0);
|
||||
|
||||
// If we're outputting the header scope, then this might be the final time
|
||||
// that drupal_get_js() is running, so add the setting to this output as well
|
||||
// as to the drupal_add_js() cache. If $items['settings'] doesn't exist, it's
|
||||
// because drupal_get_js() was intentionally passed a $javascript argument
|
||||
// stripped off settings, potentially in order to override how settings get
|
||||
// output, so in this case, do not add the setting to this output.
|
||||
if ($scope == 'header' && isset($items['settings'])) {
|
||||
$items['settings']['data'][] = $setting;
|
||||
}
|
||||
$settings = isset($elements['settings']) ? $elements['settings'] : array();
|
||||
$settings += array('#weight' => $scripts['#weight'] + 10);
|
||||
|
||||
// The index counter is used to keep aggregated and non-aggregated files in
|
||||
// order by weight. Use existing scripts count as a starting point.
|
||||
$index = count(element_children($scripts)) + 1;
|
||||
|
||||
// Loop through the JavaScript to construct the rendered output.
|
||||
$element = array(
|
||||
'#type' => 'html_tag',
|
||||
'#tag' => 'script',
|
||||
'#value' => '',
|
||||
'#attributes' => array(
|
||||
'type' => 'text/javascript',
|
||||
),
|
||||
);
|
||||
foreach ($items as $item) {
|
||||
|
||||
foreach ($elements['#items'] as $item) {
|
||||
$query_string = empty($item['version']) ? $default_query_string : $js_version_string . $item['version'];
|
||||
|
||||
switch ($item['type']) {
|
||||
@@ -4488,7 +4556,7 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
$js_element['#value_prefix'] = $embed_prefix;
|
||||
$js_element['#value'] = 'jQuery.extend(Drupal.settings, ' . drupal_json_encode(drupal_array_merge_deep_array($item['data'])) . ");";
|
||||
$js_element['#value_suffix'] = $embed_suffix;
|
||||
$output .= theme('html_tag', array('element' => $js_element));
|
||||
$settings[] = $js_element;
|
||||
break;
|
||||
|
||||
case 'inline':
|
||||
@@ -4499,7 +4567,7 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
$js_element['#value_prefix'] = $embed_prefix;
|
||||
$js_element['#value'] = $item['data'];
|
||||
$js_element['#value_suffix'] = $embed_suffix;
|
||||
$processed[$index++] = theme('html_tag', array('element' => $js_element));
|
||||
$scripts[$index++] = $js_element;
|
||||
break;
|
||||
|
||||
case 'file':
|
||||
@@ -4510,7 +4578,7 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
}
|
||||
$query_string_separator = (strpos($item['data'], '?') !== FALSE) ? '&' : '?';
|
||||
$js_element['#attributes']['src'] = file_create_url($item['data']) . $query_string_separator . ($item['cache'] ? $query_string : REQUEST_TIME);
|
||||
$processed[$index++] = theme('html_tag', array('element' => $js_element));
|
||||
$scripts[$index++] = $js_element;
|
||||
}
|
||||
else {
|
||||
// By increasing the index for each aggregated file, we maintain
|
||||
@@ -4521,7 +4589,7 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
// leading to better front-end performance of a website as a whole.
|
||||
// See drupal_add_js() for details.
|
||||
$key = 'aggregate_' . $item['group'] . '_' . $item['every_page'] . '_' . $index;
|
||||
$processed[$key] = '';
|
||||
$scripts[$key] = '';
|
||||
$files[$key][$item['data']] = $item;
|
||||
}
|
||||
break;
|
||||
@@ -4533,7 +4601,7 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
$js_element['#attributes']['defer'] = 'defer';
|
||||
}
|
||||
$js_element['#attributes']['src'] = $item['data'];
|
||||
$processed[$index++] = theme('html_tag', array('element' => $js_element));
|
||||
$scripts[$index++] = $js_element;
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -4548,14 +4616,18 @@ function drupal_get_js($scope = 'header', $javascript = NULL, $skip_alter = FALS
|
||||
$preprocess_file = file_create_url($uri);
|
||||
$js_element = $element;
|
||||
$js_element['#attributes']['src'] = $preprocess_file;
|
||||
$processed[$key] = theme('html_tag', array('element' => $js_element));
|
||||
$scripts[$key] = $js_element;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Keep the order of JS files consistent as some are preprocessed and others are not.
|
||||
// Make sure any inline or JS setting variables appear last after libraries have loaded.
|
||||
return implode('', $processed) . $output;
|
||||
// Keep the order of JS files consistent as some are preprocessed and others
|
||||
// are not. Make sure any inline or JS setting variables appear last after
|
||||
// libraries have loaded.
|
||||
$element['scripts'] = $scripts;
|
||||
$element['settings'] = $settings;
|
||||
|
||||
return $element;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -5101,6 +5173,8 @@ function drupal_build_js_cache($files) {
|
||||
$contents .= file_get_contents($path) . ";\n";
|
||||
}
|
||||
}
|
||||
// Remove JS source and source mapping urls or these may cause 404 errors.
|
||||
$contents = preg_replace('/\/\/(#|@)\s(sourceURL|sourceMappingURL)=\s*(\S*?)\s*$/m', '', $contents);
|
||||
// Prefix filename to prevent blocking by firewalls which reject files
|
||||
// starting with "ad*".
|
||||
$filename = 'js_' . drupal_hash_base64($contents) . '.js';
|
||||
@@ -6588,30 +6662,41 @@ function element_children(&$elements, $sort = FALSE) {
|
||||
$sort = isset($elements['#sorted']) ? !$elements['#sorted'] : $sort;
|
||||
|
||||
// Filter out properties from the element, leaving only children.
|
||||
$children = array();
|
||||
$count = count($elements);
|
||||
$child_weights = array();
|
||||
$i = 0;
|
||||
$sortable = FALSE;
|
||||
foreach ($elements as $key => $value) {
|
||||
if ($key === '' || $key[0] !== '#') {
|
||||
$children[$key] = $value;
|
||||
if (is_int($key) || $key === '' || $key[0] !== '#') {
|
||||
if (is_array($value) && isset($value['#weight'])) {
|
||||
$weight = $value['#weight'];
|
||||
$sortable = TRUE;
|
||||
}
|
||||
else {
|
||||
$weight = 0;
|
||||
}
|
||||
// Support weights with up to three digit precision and conserve the
|
||||
// insertion order.
|
||||
$child_weights[$key] = floor($weight * 1000) + $i / $count;
|
||||
}
|
||||
$i++;
|
||||
}
|
||||
|
||||
// Sort the children if necessary.
|
||||
if ($sort && $sortable) {
|
||||
uasort($children, 'element_sort');
|
||||
asort($child_weights);
|
||||
// Put the sorted children back into $elements in the correct order, to
|
||||
// preserve sorting if the same element is passed through
|
||||
// element_children() twice.
|
||||
foreach ($children as $key => $child) {
|
||||
foreach ($child_weights as $key => $weight) {
|
||||
$value = $elements[$key];
|
||||
unset($elements[$key]);
|
||||
$elements[$key] = $child;
|
||||
$elements[$key] = $value;
|
||||
}
|
||||
$elements['#sorted'] = TRUE;
|
||||
}
|
||||
|
||||
return array_keys($children);
|
||||
return array_keys($child_weights);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -6937,7 +7022,16 @@ function drupal_common_theme() {
|
||||
'variables' => array(),
|
||||
),
|
||||
'table' => array(
|
||||
'variables' => array('header' => NULL, 'rows' => NULL, 'attributes' => array(), 'caption' => NULL, 'colgroups' => array(), 'sticky' => TRUE, 'empty' => ''),
|
||||
'variables' => array(
|
||||
'header' => NULL,
|
||||
'footer' => NULL,
|
||||
'rows' => NULL,
|
||||
'attributes' => array(),
|
||||
'caption' => NULL,
|
||||
'colgroups' => array(),
|
||||
'sticky' => TRUE,
|
||||
'empty' => '',
|
||||
),
|
||||
),
|
||||
'tablesort_indicator' => array(
|
||||
'variables' => array('style' => NULL),
|
||||
|
||||
@@ -184,7 +184,7 @@
|
||||
*
|
||||
* @see http://php.net/manual/book.pdo.php
|
||||
*/
|
||||
abstract class DatabaseConnection extends PDO {
|
||||
abstract class DatabaseConnection {
|
||||
|
||||
/**
|
||||
* The database target this connection is for.
|
||||
@@ -261,6 +261,13 @@ abstract class DatabaseConnection extends PDO {
|
||||
*/
|
||||
protected $temporaryNameIndex = 0;
|
||||
|
||||
/**
|
||||
* The actual PDO connection.
|
||||
*
|
||||
* @var \PDO
|
||||
*/
|
||||
protected $connection;
|
||||
|
||||
/**
|
||||
* The connection information for this connection object.
|
||||
*
|
||||
@@ -310,6 +317,13 @@ abstract class DatabaseConnection extends PDO {
|
||||
*/
|
||||
protected $escapedAliases = array();
|
||||
|
||||
/**
|
||||
* List of un-prefixed table names, keyed by prefixed table names.
|
||||
*
|
||||
* @var array
|
||||
*/
|
||||
protected $unprefixedTablesMap = array();
|
||||
|
||||
function __construct($dsn, $username, $password, $driver_options = array()) {
|
||||
// Initialize and prepare the connection prefix.
|
||||
$this->setPrefix(isset($this->connectionOptions['prefix']) ? $this->connectionOptions['prefix'] : '');
|
||||
@@ -318,14 +332,27 @@ abstract class DatabaseConnection extends PDO {
|
||||
$driver_options[PDO::ATTR_ERRMODE] = PDO::ERRMODE_EXCEPTION;
|
||||
|
||||
// Call PDO::__construct and PDO::setAttribute.
|
||||
parent::__construct($dsn, $username, $password, $driver_options);
|
||||
$this->connection = new PDO($dsn, $username, $password, $driver_options);
|
||||
|
||||
// Set a Statement class, unless the driver opted out.
|
||||
if (!empty($this->statementClass)) {
|
||||
$this->setAttribute(PDO::ATTR_STATEMENT_CLASS, array($this->statementClass, array($this)));
|
||||
$this->connection->setAttribute(PDO::ATTR_STATEMENT_CLASS, array($this->statementClass, array($this)));
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Proxy possible direct calls to the \PDO methods.
|
||||
*
|
||||
* Since PHP8.0 the signature of the the \PDO::query() method has changed,
|
||||
* and this class can't extending \PDO any more.
|
||||
*
|
||||
* However, for the BC, proxy any calls to the \PDO methods to the actual
|
||||
* PDO connection object.
|
||||
*/
|
||||
public function __call($name, $arguments) {
|
||||
return call_user_func_array(array($this->connection, $name), $arguments);
|
||||
}
|
||||
|
||||
/**
|
||||
* Destroys this Connection object.
|
||||
*
|
||||
@@ -338,7 +365,9 @@ abstract class DatabaseConnection extends PDO {
|
||||
// Destroy all references to this connection by setting them to NULL.
|
||||
// The Statement class attribute only accepts a new value that presents a
|
||||
// proper callable, so we reset it to PDOStatement.
|
||||
$this->setAttribute(PDO::ATTR_STATEMENT_CLASS, array('PDOStatement', array()));
|
||||
if (!empty($this->statementClass)) {
|
||||
$this->connection->setAttribute(PDO::ATTR_STATEMENT_CLASS, array('PDOStatement', array()));
|
||||
}
|
||||
$this->schema = NULL;
|
||||
}
|
||||
|
||||
@@ -442,6 +471,13 @@ abstract class DatabaseConnection extends PDO {
|
||||
$this->prefixReplace[] = $this->prefixes['default'];
|
||||
$this->prefixSearch[] = '}';
|
||||
$this->prefixReplace[] = '';
|
||||
|
||||
// Set up a map of prefixed => un-prefixed tables.
|
||||
foreach ($this->prefixes as $table_name => $prefix) {
|
||||
if ($table_name !== 'default') {
|
||||
$this->unprefixedTablesMap[$prefix . $table_name] = $table_name;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -477,6 +513,17 @@ abstract class DatabaseConnection extends PDO {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Gets a list of individually prefixed table names.
|
||||
*
|
||||
* @return array
|
||||
* An array of un-prefixed table names, keyed by their fully qualified table
|
||||
* names (i.e. prefix + table_name).
|
||||
*/
|
||||
public function getUnprefixedTablesMap() {
|
||||
return $this->unprefixedTablesMap;
|
||||
}
|
||||
|
||||
/**
|
||||
* Prepares a query string and returns the prepared statement.
|
||||
*
|
||||
@@ -494,7 +541,7 @@ abstract class DatabaseConnection extends PDO {
|
||||
$query = $this->prefixTables($query);
|
||||
|
||||
// Call PDO::prepare.
|
||||
return parent::prepare($query);
|
||||
return $this->connection->prepare($query);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -706,7 +753,7 @@ abstract class DatabaseConnection extends PDO {
|
||||
case Database::RETURN_AFFECTED:
|
||||
return $stmt->rowCount();
|
||||
case Database::RETURN_INSERT_ID:
|
||||
return $this->lastInsertId();
|
||||
return $this->connection->lastInsertId();
|
||||
case Database::RETURN_NULL:
|
||||
return;
|
||||
default:
|
||||
@@ -1089,7 +1136,7 @@ abstract class DatabaseConnection extends PDO {
|
||||
$rolled_back_other_active_savepoints = TRUE;
|
||||
}
|
||||
}
|
||||
parent::rollBack();
|
||||
$this->connection->rollBack();
|
||||
if ($rolled_back_other_active_savepoints) {
|
||||
throw new DatabaseTransactionOutOfOrderException();
|
||||
}
|
||||
@@ -1117,7 +1164,7 @@ abstract class DatabaseConnection extends PDO {
|
||||
$this->query('SAVEPOINT ' . $name);
|
||||
}
|
||||
else {
|
||||
parent::beginTransaction();
|
||||
$this->connection->beginTransaction();
|
||||
}
|
||||
$this->transactionLayers[$name] = $name;
|
||||
}
|
||||
@@ -1168,7 +1215,7 @@ abstract class DatabaseConnection extends PDO {
|
||||
// If there are no more layers left then we should commit.
|
||||
unset($this->transactionLayers[$name]);
|
||||
if (empty($this->transactionLayers)) {
|
||||
if (!parent::commit()) {
|
||||
if (!$this->connection->commit()) {
|
||||
throw new DatabaseTransactionCommitFailedException();
|
||||
}
|
||||
}
|
||||
@@ -1252,7 +1299,7 @@ abstract class DatabaseConnection extends PDO {
|
||||
* Returns the version of the database server.
|
||||
*/
|
||||
public function version() {
|
||||
return $this->getAttribute(PDO::ATTR_SERVER_VERSION);
|
||||
return $this->connection->getAttribute(PDO::ATTR_SERVER_VERSION);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -1697,12 +1744,16 @@ abstract class Database {
|
||||
*
|
||||
* @param $key
|
||||
* The connection key.
|
||||
* @param $close
|
||||
* Whether to close the connection.
|
||||
* @return
|
||||
* TRUE in case of success, FALSE otherwise.
|
||||
*/
|
||||
final public static function removeConnection($key) {
|
||||
final public static function removeConnection($key, $close = TRUE) {
|
||||
if (isset(self::$databaseInfo[$key])) {
|
||||
self::closeConnection(NULL, $key);
|
||||
if ($close) {
|
||||
self::closeConnection(NULL, $key);
|
||||
}
|
||||
unset(self::$databaseInfo[$key]);
|
||||
return TRUE;
|
||||
}
|
||||
@@ -2840,7 +2891,6 @@ function db_field_exists($table, $field) {
|
||||
*
|
||||
* @param $table_expression
|
||||
* An SQL expression, for example "simpletest%" (without the quotes).
|
||||
* BEWARE: this is not prefixed, the caller should take care of that.
|
||||
*
|
||||
* @return
|
||||
* Array, both the keys and the values are the matching tables.
|
||||
@@ -2849,6 +2899,23 @@ function db_find_tables($table_expression) {
|
||||
return Database::getConnection()->schema()->findTables($table_expression);
|
||||
}
|
||||
|
||||
/**
|
||||
* Finds all tables that are like the specified base table name. This is a
|
||||
* backport of the change made to db_find_tables in Drupal 8 to work with
|
||||
* virtual, un-prefixed table names. The original function is retained for
|
||||
* Backwards Compatibility.
|
||||
* @see https://www.drupal.org/node/2552435
|
||||
*
|
||||
* @param $table_expression
|
||||
* An SQL expression, for example "simpletest%" (without the quotes).
|
||||
*
|
||||
* @return
|
||||
* Array, both the keys and the values are the matching tables.
|
||||
*/
|
||||
function db_find_tables_d8($table_expression) {
|
||||
return Database::getConnection()->schema()->findTablesD8($table_expression);
|
||||
}
|
||||
|
||||
function _db_create_keys_sql($spec) {
|
||||
return Database::getConnection()->schema()->createKeysSql($spec);
|
||||
}
|
||||
|
||||
@@ -5,6 +5,11 @@
|
||||
* Database interface code for MySQL database servers.
|
||||
*/
|
||||
|
||||
/**
|
||||
* The default character for quoting identifiers in MySQL.
|
||||
*/
|
||||
define('MYSQL_IDENTIFIER_QUOTE_CHARACTER_DEFAULT', '`');
|
||||
|
||||
/**
|
||||
* @addtogroup database
|
||||
* @{
|
||||
@@ -19,6 +24,277 @@ class DatabaseConnection_mysql extends DatabaseConnection {
|
||||
*/
|
||||
protected $needsCleanup = FALSE;
|
||||
|
||||
/**
|
||||
* The list of MySQL reserved key words.
|
||||
*
|
||||
* @link https://dev.mysql.com/doc/refman/8.0/en/keywords.html
|
||||
*/
|
||||
private $reservedKeyWords = array(
|
||||
'accessible',
|
||||
'add',
|
||||
'admin',
|
||||
'all',
|
||||
'alter',
|
||||
'analyze',
|
||||
'and',
|
||||
'as',
|
||||
'asc',
|
||||
'asensitive',
|
||||
'before',
|
||||
'between',
|
||||
'bigint',
|
||||
'binary',
|
||||
'blob',
|
||||
'both',
|
||||
'by',
|
||||
'call',
|
||||
'cascade',
|
||||
'case',
|
||||
'change',
|
||||
'char',
|
||||
'character',
|
||||
'check',
|
||||
'collate',
|
||||
'column',
|
||||
'condition',
|
||||
'constraint',
|
||||
'continue',
|
||||
'convert',
|
||||
'create',
|
||||
'cross',
|
||||
'cube',
|
||||
'cume_dist',
|
||||
'current_date',
|
||||
'current_time',
|
||||
'current_timestamp',
|
||||
'current_user',
|
||||
'cursor',
|
||||
'database',
|
||||
'databases',
|
||||
'day_hour',
|
||||
'day_microsecond',
|
||||
'day_minute',
|
||||
'day_second',
|
||||
'dec',
|
||||
'decimal',
|
||||
'declare',
|
||||
'default',
|
||||
'delayed',
|
||||
'delete',
|
||||
'dense_rank',
|
||||
'desc',
|
||||
'describe',
|
||||
'deterministic',
|
||||
'distinct',
|
||||
'distinctrow',
|
||||
'div',
|
||||
'double',
|
||||
'drop',
|
||||
'dual',
|
||||
'each',
|
||||
'else',
|
||||
'elseif',
|
||||
'empty',
|
||||
'enclosed',
|
||||
'escaped',
|
||||
'except',
|
||||
'exists',
|
||||
'exit',
|
||||
'explain',
|
||||
'false',
|
||||
'fetch',
|
||||
'first_value',
|
||||
'float',
|
||||
'float4',
|
||||
'float8',
|
||||
'for',
|
||||
'force',
|
||||
'foreign',
|
||||
'from',
|
||||
'fulltext',
|
||||
'function',
|
||||
'generated',
|
||||
'get',
|
||||
'grant',
|
||||
'group',
|
||||
'grouping',
|
||||
'groups',
|
||||
'having',
|
||||
'high_priority',
|
||||
'hour_microsecond',
|
||||
'hour_minute',
|
||||
'hour_second',
|
||||
'if',
|
||||
'ignore',
|
||||
'in',
|
||||
'index',
|
||||
'infile',
|
||||
'inner',
|
||||
'inout',
|
||||
'insensitive',
|
||||
'insert',
|
||||
'int',
|
||||
'int1',
|
||||
'int2',
|
||||
'int3',
|
||||
'int4',
|
||||
'int8',
|
||||
'integer',
|
||||
'interval',
|
||||
'into',
|
||||
'io_after_gtids',
|
||||
'io_before_gtids',
|
||||
'is',
|
||||
'iterate',
|
||||
'join',
|
||||
'json_table',
|
||||
'key',
|
||||
'keys',
|
||||
'kill',
|
||||
'lag',
|
||||
'last_value',
|
||||
'lead',
|
||||
'leading',
|
||||
'leave',
|
||||
'left',
|
||||
'like',
|
||||
'limit',
|
||||
'linear',
|
||||
'lines',
|
||||
'load',
|
||||
'localtime',
|
||||
'localtimestamp',
|
||||
'lock',
|
||||
'long',
|
||||
'longblob',
|
||||
'longtext',
|
||||
'loop',
|
||||
'low_priority',
|
||||
'master_bind',
|
||||
'master_ssl_verify_server_cert',
|
||||
'match',
|
||||
'maxvalue',
|
||||
'mediumblob',
|
||||
'mediumint',
|
||||
'mediumtext',
|
||||
'middleint',
|
||||
'minute_microsecond',
|
||||
'minute_second',
|
||||
'mod',
|
||||
'modifies',
|
||||
'natural',
|
||||
'not',
|
||||
'no_write_to_binlog',
|
||||
'nth_value',
|
||||
'ntile',
|
||||
'null',
|
||||
'numeric',
|
||||
'of',
|
||||
'on',
|
||||
'optimize',
|
||||
'optimizer_costs',
|
||||
'option',
|
||||
'optionally',
|
||||
'or',
|
||||
'order',
|
||||
'out',
|
||||
'outer',
|
||||
'outfile',
|
||||
'over',
|
||||
'partition',
|
||||
'percent_rank',
|
||||
'persist',
|
||||
'persist_only',
|
||||
'precision',
|
||||
'primary',
|
||||
'procedure',
|
||||
'purge',
|
||||
'range',
|
||||
'rank',
|
||||
'read',
|
||||
'reads',
|
||||
'read_write',
|
||||
'real',
|
||||
'recursive',
|
||||
'references',
|
||||
'regexp',
|
||||
'release',
|
||||
'rename',
|
||||
'repeat',
|
||||
'replace',
|
||||
'require',
|
||||
'resignal',
|
||||
'restrict',
|
||||
'return',
|
||||
'revoke',
|
||||
'right',
|
||||
'rlike',
|
||||
'row',
|
||||
'rows',
|
||||
'row_number',
|
||||
'schema',
|
||||
'schemas',
|
||||
'second_microsecond',
|
||||
'select',
|
||||
'sensitive',
|
||||
'separator',
|
||||
'set',
|
||||
'show',
|
||||
'signal',
|
||||
'smallint',
|
||||
'spatial',
|
||||
'specific',
|
||||
'sql',
|
||||
'sqlexception',
|
||||
'sqlstate',
|
||||
'sqlwarning',
|
||||
'sql_big_result',
|
||||
'sql_calc_found_rows',
|
||||
'sql_small_result',
|
||||
'ssl',
|
||||
'starting',
|
||||
'stored',
|
||||
'straight_join',
|
||||
'system',
|
||||
'table',
|
||||
'terminated',
|
||||
'then',
|
||||
'tinyblob',
|
||||
'tinyint',
|
||||
'tinytext',
|
||||
'to',
|
||||
'trailing',
|
||||
'trigger',
|
||||
'true',
|
||||
'undo',
|
||||
'union',
|
||||
'unique',
|
||||
'unlock',
|
||||
'unsigned',
|
||||
'update',
|
||||
'usage',
|
||||
'use',
|
||||
'using',
|
||||
'utc_date',
|
||||
'utc_time',
|
||||
'utc_timestamp',
|
||||
'values',
|
||||
'varbinary',
|
||||
'varchar',
|
||||
'varcharacter',
|
||||
'varying',
|
||||
'virtual',
|
||||
'when',
|
||||
'where',
|
||||
'while',
|
||||
'window',
|
||||
'with',
|
||||
'write',
|
||||
'xor',
|
||||
'year_month',
|
||||
'zerofill',
|
||||
);
|
||||
|
||||
public function __construct(array $connection_options = array()) {
|
||||
// This driver defaults to transaction support, except if explicitly passed FALSE.
|
||||
$this->transactionSupport = !isset($connection_options['transactions']) || ($connection_options['transactions'] !== FALSE);
|
||||
@@ -69,10 +345,10 @@ class DatabaseConnection_mysql extends DatabaseConnection {
|
||||
// certain one has been set; otherwise, MySQL defaults to 'utf8_general_ci'
|
||||
// for UTF-8.
|
||||
if (!empty($connection_options['collation'])) {
|
||||
$this->exec('SET NAMES ' . $charset . ' COLLATE ' . $connection_options['collation']);
|
||||
$this->connection->exec('SET NAMES ' . $charset . ' COLLATE ' . $connection_options['collation']);
|
||||
}
|
||||
else {
|
||||
$this->exec('SET NAMES ' . $charset);
|
||||
$this->connection->exec('SET NAMES ' . $charset);
|
||||
}
|
||||
|
||||
// Set MySQL init_commands if not already defined. Default Drupal's MySQL
|
||||
@@ -86,15 +362,95 @@ class DatabaseConnection_mysql extends DatabaseConnection {
|
||||
$connection_options += array(
|
||||
'init_commands' => array(),
|
||||
);
|
||||
|
||||
$sql_mode = 'REAL_AS_FLOAT,PIPES_AS_CONCAT,ANSI_QUOTES,IGNORE_SPACE,STRICT_TRANS_TABLES,STRICT_ALL_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO';
|
||||
// NO_AUTO_CREATE_USER was removed in MySQL 8.0.11
|
||||
// https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html#mysqld-8-0-11-deprecation-removal
|
||||
if (version_compare($this->connection->getAttribute(PDO::ATTR_SERVER_VERSION), '8.0.11', '<')) {
|
||||
$sql_mode .= ',NO_AUTO_CREATE_USER';
|
||||
}
|
||||
$connection_options['init_commands'] += array(
|
||||
'sql_mode' => "SET sql_mode = 'REAL_AS_FLOAT,PIPES_AS_CONCAT,ANSI_QUOTES,IGNORE_SPACE,STRICT_TRANS_TABLES,STRICT_ALL_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER'",
|
||||
'sql_mode' => "SET sql_mode = '$sql_mode'",
|
||||
);
|
||||
|
||||
// Execute initial commands.
|
||||
foreach ($connection_options['init_commands'] as $sql) {
|
||||
$this->exec($sql);
|
||||
$this->connection->exec($sql);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* {@inheritdoc}}
|
||||
*/
|
||||
protected function setPrefix($prefix) {
|
||||
parent::setPrefix($prefix);
|
||||
// Successive versions of MySQL have become increasingly strict about the
|
||||
// use of reserved keywords as table names. Drupal 7 uses at least one such
|
||||
// table (system). Therefore we surround all table names with quotes.
|
||||
$quote_char = variable_get('mysql_identifier_quote_character', MYSQL_IDENTIFIER_QUOTE_CHARACTER_DEFAULT);
|
||||
foreach ($this->prefixSearch as $i => $prefixSearch) {
|
||||
if (substr($prefixSearch, 0, 1) === '{') {
|
||||
// If the prefix already contains one or more quotes remove them.
|
||||
// This can happen when - for example - DrupalUnitTestCase sets up a
|
||||
// "temporary prefixed database". Also if there's a dot in the prefix,
|
||||
// wrap it in quotes to cater for schema names in prefixes.
|
||||
$search = array($quote_char, '.');
|
||||
$replace = array('', $quote_char . '.' . $quote_char);
|
||||
$this->prefixReplace[$i] = $quote_char . str_replace($search, $replace, $this->prefixReplace[$i]);
|
||||
}
|
||||
if (substr($prefixSearch, -1) === '}') {
|
||||
$this->prefixReplace[$i] .= $quote_char;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* {@inheritdoc}
|
||||
*/
|
||||
public function escapeField($field) {
|
||||
$field = parent::escapeField($field);
|
||||
return $this->quoteIdentifier($field);
|
||||
}
|
||||
|
||||
public function escapeFields(array $fields) {
|
||||
foreach ($fields as &$field) {
|
||||
$field = $this->escapeField($field);
|
||||
}
|
||||
return $fields;
|
||||
}
|
||||
|
||||
/**
|
||||
* {@inheritdoc}
|
||||
*/
|
||||
public function escapeAlias($field) {
|
||||
$field = parent::escapeAlias($field);
|
||||
return $this->quoteIdentifier($field);
|
||||
}
|
||||
|
||||
/**
|
||||
* Quotes an identifier if it matches a MySQL reserved keyword.
|
||||
*
|
||||
* @param string $identifier
|
||||
* The field to check.
|
||||
*
|
||||
* @return string
|
||||
* The identifier, quoted if it matches a MySQL reserved keyword.
|
||||
*/
|
||||
private function quoteIdentifier($identifier) {
|
||||
// Quote identifiers so that MySQL reserved words like 'function' can be
|
||||
// used as column names. Sometimes the 'table.column_name' format is passed
|
||||
// in. For example, menu_load_links() adds a condition on "ml.menu_name".
|
||||
if (strpos($identifier, '.') !== FALSE) {
|
||||
list($table, $identifier) = explode('.', $identifier, 2);
|
||||
}
|
||||
if (in_array(strtolower($identifier), $this->reservedKeyWords, TRUE)) {
|
||||
// Quote the string for MySQL reserved keywords.
|
||||
$quote_char = variable_get('mysql_identifier_quote_character', MYSQL_IDENTIFIER_QUOTE_CHARACTER_DEFAULT);
|
||||
$identifier = $quote_char . $identifier . $quote_char;
|
||||
}
|
||||
return isset($table) ? $table . '.' . $identifier : $identifier;
|
||||
}
|
||||
|
||||
public function __destruct() {
|
||||
if ($this->needsCleanup) {
|
||||
$this->nextIdDelete();
|
||||
@@ -180,7 +536,7 @@ class DatabaseConnection_mysql extends DatabaseConnection {
|
||||
// If there are no more layers left then we should commit.
|
||||
unset($this->transactionLayers[$name]);
|
||||
if (empty($this->transactionLayers)) {
|
||||
if (!PDO::commit()) {
|
||||
if (!$this->doCommit()) {
|
||||
throw new DatabaseTransactionCommitFailedException();
|
||||
}
|
||||
}
|
||||
@@ -203,7 +559,7 @@ class DatabaseConnection_mysql extends DatabaseConnection {
|
||||
$this->transactionLayers = array();
|
||||
// We also have to explain to PDO that the transaction stack has
|
||||
// been cleaned-up.
|
||||
PDO::commit();
|
||||
$this->doCommit();
|
||||
}
|
||||
else {
|
||||
throw $e;
|
||||
@@ -213,6 +569,53 @@ class DatabaseConnection_mysql extends DatabaseConnection {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Do the actual commit, including a workaround for PHP 8 behaviour changes.
|
||||
*
|
||||
* @return bool
|
||||
* Success or otherwise of the commit.
|
||||
*/
|
||||
protected function doCommit() {
|
||||
if ($this->connection->inTransaction()) {
|
||||
return $this->connection->commit();
|
||||
}
|
||||
else {
|
||||
// In PHP 8.0 a PDOException is thrown when a commit is attempted with no
|
||||
// transaction active. In previous PHP versions this failed silently.
|
||||
return TRUE;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* {@inheritdoc}
|
||||
*/
|
||||
public function rollback($savepoint_name = 'drupal_transaction') {
|
||||
// MySQL will automatically commit transactions when tables are altered or
|
||||
// created (DDL transactions are not supported). Prevent triggering an
|
||||
// exception to ensure that the error that has caused the rollback is
|
||||
// properly reported.
|
||||
if (!$this->connection->inTransaction()) {
|
||||
// Before PHP 8 $this->connection->inTransaction() will return TRUE and
|
||||
// $this->connection->rollback() does not throw an exception; the
|
||||
// following code is unreachable.
|
||||
|
||||
// If \DatabaseConnection::rollback() would throw an
|
||||
// exception then continue to throw an exception.
|
||||
if (!$this->inTransaction()) {
|
||||
throw new DatabaseTransactionNoActiveException();
|
||||
}
|
||||
// A previous rollback to an earlier savepoint may mean that the savepoint
|
||||
// in question has already been accidentally committed.
|
||||
if (!isset($this->transactionLayers[$savepoint_name])) {
|
||||
throw new DatabaseTransactionNoActiveException();
|
||||
}
|
||||
|
||||
trigger_error('Rollback attempted when there is no active transaction. This can cause data integrity issues.', E_USER_WARNING);
|
||||
return;
|
||||
}
|
||||
return parent::rollback($savepoint_name);
|
||||
}
|
||||
|
||||
public function utf8mb4IsConfigurable() {
|
||||
return TRUE;
|
||||
}
|
||||
@@ -223,7 +626,7 @@ class DatabaseConnection_mysql extends DatabaseConnection {
|
||||
|
||||
public function utf8mb4IsSupported() {
|
||||
// Ensure that the MySQL driver supports utf8mb4 encoding.
|
||||
$version = $this->getAttribute(PDO::ATTR_CLIENT_VERSION);
|
||||
$version = $this->connection->getAttribute(PDO::ATTR_CLIENT_VERSION);
|
||||
if (strpos($version, 'mysqlnd') !== FALSE) {
|
||||
// The mysqlnd driver supports utf8mb4 starting at version 5.0.9.
|
||||
$version = preg_replace('/^\D+([\d.]+).*/', '$1', $version);
|
||||
|
||||
@@ -48,6 +48,10 @@ class InsertQuery_mysql extends InsertQuery {
|
||||
// Default fields are always placed first for consistency.
|
||||
$insert_fields = array_merge($this->defaultFields, $this->insertFields);
|
||||
|
||||
if (method_exists($this->connection, 'escapeFields')) {
|
||||
$insert_fields = $this->connection->escapeFields($insert_fields);
|
||||
}
|
||||
|
||||
// If we're selecting from a SelectQuery, finish building the query and
|
||||
// pass it back, as any remaining options are irrelevant.
|
||||
if (!empty($this->fromQuery)) {
|
||||
@@ -89,6 +93,20 @@ class InsertQuery_mysql extends InsertQuery {
|
||||
|
||||
class TruncateQuery_mysql extends TruncateQuery { }
|
||||
|
||||
class UpdateQuery_mysql extends UpdateQuery {
|
||||
public function __toString() {
|
||||
if (method_exists($this->connection, 'escapeField')) {
|
||||
$escapedFields = array();
|
||||
foreach ($this->fields as $field => $data) {
|
||||
$field = $this->connection->escapeField($field);
|
||||
$escapedFields[$field] = $data;
|
||||
}
|
||||
$this->fields = $escapedFields;
|
||||
}
|
||||
return parent::__toString();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @} End of "addtogroup database".
|
||||
*/
|
||||
|
||||
@@ -57,6 +57,11 @@ class DatabaseSchema_mysql extends DatabaseSchema {
|
||||
protected function buildTableNameCondition($table_name, $operator = '=', $add_prefix = TRUE) {
|
||||
$info = $this->connection->getConnectionOptions();
|
||||
|
||||
// Ensure the table name is not surrounded with quotes as that is not
|
||||
// appropriate for schema queries.
|
||||
$quote_char = variable_get('mysql_identifier_quote_character', MYSQL_IDENTIFIER_QUOTE_CHARACTER_DEFAULT);
|
||||
$table_name = str_replace($quote_char, '', $table_name);
|
||||
|
||||
$table_info = $this->getPrefixInfo($table_name, $add_prefix);
|
||||
|
||||
$condition = new DatabaseCondition('AND');
|
||||
@@ -494,11 +499,11 @@ class DatabaseSchema_mysql extends DatabaseSchema {
|
||||
$condition->condition('column_name', $column);
|
||||
$condition->compile($this->connection, $this);
|
||||
// Don't use {} around information_schema.columns table.
|
||||
return $this->connection->query("SELECT column_comment FROM information_schema.columns WHERE " . (string) $condition, $condition->arguments())->fetchField();
|
||||
return $this->connection->query("SELECT column_comment AS column_comment FROM information_schema.columns WHERE " . (string) $condition, $condition->arguments())->fetchField();
|
||||
}
|
||||
$condition->compile($this->connection, $this);
|
||||
// Don't use {} around information_schema.tables table.
|
||||
$comment = $this->connection->query("SELECT table_comment FROM information_schema.tables WHERE " . (string) $condition, $condition->arguments())->fetchField();
|
||||
$comment = $this->connection->query("SELECT table_comment AS table_comment FROM information_schema.tables WHERE " . (string) $condition, $condition->arguments())->fetchField();
|
||||
// Work-around for MySQL 5.0 bug http://bugs.mysql.com/bug.php?id=11379
|
||||
return preg_replace('/; InnoDB free:.*$/', '', $comment);
|
||||
}
|
||||
|
||||
@@ -66,11 +66,11 @@ class DatabaseConnection_pgsql extends DatabaseConnection {
|
||||
parent::__construct($dsn, $connection_options['username'], $connection_options['password'], $connection_options['pdo']);
|
||||
|
||||
// Force PostgreSQL to use the UTF-8 character set by default.
|
||||
$this->exec("SET NAMES 'UTF8'");
|
||||
$this->connection->exec("SET NAMES 'UTF8'");
|
||||
|
||||
// Execute PostgreSQL init_commands.
|
||||
if (isset($connection_options['init_commands'])) {
|
||||
$this->exec(implode('; ', $connection_options['init_commands']));
|
||||
$this->connection->exec(implode('; ', $connection_options['init_commands']));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -117,7 +117,7 @@ class DatabaseConnection_pgsql extends DatabaseConnection {
|
||||
case Database::RETURN_AFFECTED:
|
||||
return $stmt->rowCount();
|
||||
case Database::RETURN_INSERT_ID:
|
||||
return $this->lastInsertId($options['sequence_name']);
|
||||
return $this->connection->lastInsertId($options['sequence_name']);
|
||||
case Database::RETURN_NULL:
|
||||
return;
|
||||
default:
|
||||
|
||||
@@ -169,6 +169,11 @@ require_once dirname(__FILE__) . '/query.inc';
|
||||
*/
|
||||
abstract class DatabaseSchema implements QueryPlaceholderInterface {
|
||||
|
||||
/**
|
||||
* The database connection.
|
||||
*
|
||||
* @var DatabaseConnection
|
||||
*/
|
||||
protected $connection;
|
||||
|
||||
/**
|
||||
@@ -343,7 +348,70 @@ abstract class DatabaseSchema implements QueryPlaceholderInterface {
|
||||
// couldn't use db_select() here because it would prefix
|
||||
// information_schema.tables and the query would fail.
|
||||
// Don't use {} around information_schema.tables table.
|
||||
return $this->connection->query("SELECT table_name FROM information_schema.tables WHERE " . (string) $condition, $condition->arguments())->fetchAllKeyed(0, 0);
|
||||
return $this->connection->query("SELECT table_name AS table_name FROM information_schema.tables WHERE " . (string) $condition, $condition->arguments())->fetchAllKeyed(0, 0);
|
||||
}
|
||||
|
||||
/**
|
||||
* Finds all tables that are like the specified base table name. This is a
|
||||
* backport of the change made to findTables in Drupal 8 to work with virtual,
|
||||
* un-prefixed table names. The original function is retained for Backwards
|
||||
* Compatibility.
|
||||
* @see https://www.drupal.org/node/2552435
|
||||
*
|
||||
* @param string $table_expression
|
||||
* An SQL expression, for example "cache_%" (without the quotes).
|
||||
*
|
||||
* @return array
|
||||
* Both the keys and the values are the matching tables.
|
||||
*/
|
||||
public function findTablesD8($table_expression) {
|
||||
// Load all the tables up front in order to take into account per-table
|
||||
// prefixes. The actual matching is done at the bottom of the method.
|
||||
$condition = $this->buildTableNameCondition('%', 'LIKE');
|
||||
$condition->compile($this->connection, $this);
|
||||
|
||||
$individually_prefixed_tables = $this->connection->getUnprefixedTablesMap();
|
||||
$default_prefix = $this->connection->tablePrefix();
|
||||
$default_prefix_length = strlen($default_prefix);
|
||||
$tables = array();
|
||||
// Normally, we would heartily discourage the use of string
|
||||
// concatenation for conditionals like this however, we
|
||||
// couldn't use db_select() here because it would prefix
|
||||
// information_schema.tables and the query would fail.
|
||||
// Don't use {} around information_schema.tables table.
|
||||
$results = $this->connection->query("SELECT table_name AS table_name FROM information_schema.tables WHERE " . (string) $condition, $condition->arguments());
|
||||
foreach ($results as $table) {
|
||||
// Take into account tables that have an individual prefix.
|
||||
if (isset($individually_prefixed_tables[$table->table_name])) {
|
||||
$prefix_length = strlen($this->connection->tablePrefix($individually_prefixed_tables[$table->table_name]));
|
||||
}
|
||||
elseif ($default_prefix && substr($table->table_name, 0, $default_prefix_length) !== $default_prefix) {
|
||||
// This table name does not start the default prefix, which means that
|
||||
// it is not managed by Drupal so it should be excluded from the result.
|
||||
continue;
|
||||
}
|
||||
else {
|
||||
$prefix_length = $default_prefix_length;
|
||||
}
|
||||
|
||||
// Remove the prefix from the returned tables.
|
||||
$unprefixed_table_name = substr($table->table_name, $prefix_length);
|
||||
|
||||
// The pattern can match a table which is the same as the prefix. That
|
||||
// will become an empty string when we remove the prefix, which will
|
||||
// probably surprise the caller, besides not being a prefixed table. So
|
||||
// remove it.
|
||||
if (!empty($unprefixed_table_name)) {
|
||||
$tables[$unprefixed_table_name] = $unprefixed_table_name;
|
||||
}
|
||||
}
|
||||
|
||||
// Convert the table expression from its SQL LIKE syntax to a regular
|
||||
// expression and escape the delimiter that will be used for matching.
|
||||
$table_expression = str_replace(array('%', '_'), array('.*?', '.'), preg_quote($table_expression, '/'));
|
||||
$tables = preg_grep('/^' . $table_expression . '$/i', $tables);
|
||||
|
||||
return $tables;
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -964,7 +964,7 @@ class SelectQuery extends Query implements SelectQueryInterface {
|
||||
*/
|
||||
protected $forUpdate = FALSE;
|
||||
|
||||
public function __construct($table, $alias = NULL, DatabaseConnection $connection, $options = array()) {
|
||||
public function __construct($table, $alias, DatabaseConnection $connection, $options = array()) {
|
||||
$options['return'] = Database::RETURN_STATEMENT;
|
||||
parent::__construct($connection, $options);
|
||||
$this->where = new DatabaseCondition('AND');
|
||||
@@ -1520,13 +1520,16 @@ class SelectQuery extends Query implements SelectQueryInterface {
|
||||
$fields = array();
|
||||
foreach ($this->tables as $alias => $table) {
|
||||
if (!empty($table['all_fields'])) {
|
||||
$fields[] = $this->connection->escapeTable($alias) . '.*';
|
||||
$fields[] = $this->connection->escapeAlias($alias) . '.*';
|
||||
}
|
||||
}
|
||||
foreach ($this->fields as $alias => $field) {
|
||||
// Note that $field['table'] holds the table alias.
|
||||
// @see \SelectQuery::addField
|
||||
$table = isset($field['table']) ? $this->connection->escapeAlias($field['table']) . '.' : '';
|
||||
// Always use the AS keyword for field aliases, as some
|
||||
// databases require it (e.g., PostgreSQL).
|
||||
$fields[] = (isset($field['table']) ? $this->connection->escapeTable($field['table']) . '.' : '') . $this->connection->escapeField($field['field']) . ' AS ' . $this->connection->escapeAlias($field['alias']);
|
||||
$fields[] = $table . $this->connection->escapeField($field['field']) . ' AS ' . $this->connection->escapeAlias($field['alias']);
|
||||
}
|
||||
foreach ($this->expressions as $alias => $expression) {
|
||||
$fields[] = $expression['expression'] . ' AS ' . $this->connection->escapeAlias($expression['alias']);
|
||||
@@ -1555,7 +1558,7 @@ class SelectQuery extends Query implements SelectQueryInterface {
|
||||
|
||||
// Don't use the AS keyword for table aliases, as some
|
||||
// databases don't support it (e.g., Oracle).
|
||||
$query .= $table_string . ' ' . $this->connection->escapeTable($table['alias']);
|
||||
$query .= $table_string . ' ' . $this->connection->escapeAlias($table['alias']);
|
||||
|
||||
if (!empty($table['condition'])) {
|
||||
$query .= ' ON ' . $table['condition'];
|
||||
|
||||
@@ -107,9 +107,21 @@ class DatabaseConnection_sqlite extends DatabaseConnection {
|
||||
$this->sqliteCreateFunction('substring_index', array($this, 'sqlFunctionSubstringIndex'), 3);
|
||||
$this->sqliteCreateFunction('rand', array($this, 'sqlFunctionRand'));
|
||||
|
||||
// Enable the Write-Ahead Logging (WAL) option for SQLite if supported.
|
||||
// @see https://www.drupal.org/node/2348137
|
||||
// @see https://sqlite.org/wal.html
|
||||
if (version_compare($version, '3.7') >= 0) {
|
||||
$connection_options += array(
|
||||
'init_commands' => array(),
|
||||
);
|
||||
$connection_options['init_commands'] += array(
|
||||
'wal' => "PRAGMA journal_mode=WAL",
|
||||
);
|
||||
}
|
||||
|
||||
// Execute sqlite init_commands.
|
||||
if (isset($connection_options['init_commands'])) {
|
||||
$this->exec(implode('; ', $connection_options['init_commands']));
|
||||
$this->connection->exec(implode('; ', $connection_options['init_commands']));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -128,10 +140,10 @@ class DatabaseConnection_sqlite extends DatabaseConnection {
|
||||
$count = $this->query('SELECT COUNT(*) FROM ' . $prefix . '.sqlite_master WHERE type = :type AND name NOT LIKE :pattern', array(':type' => 'table', ':pattern' => 'sqlite_%'))->fetchField();
|
||||
|
||||
// We can prune the database file if it doesn't have any tables.
|
||||
if ($count == 0) {
|
||||
// Detach the database.
|
||||
$this->query('DETACH DATABASE :schema', array(':schema' => $prefix));
|
||||
// Destroy the database file.
|
||||
if ($count == 0 && $this->connectionOptions['database'] != ':memory:') {
|
||||
// Detaching the database fails at this point, but no other queries
|
||||
// are executed after the connection is destructed so we can simply
|
||||
// remove the database file.
|
||||
unlink($this->connectionOptions['database'] . '-' . $prefix);
|
||||
}
|
||||
}
|
||||
@@ -143,6 +155,18 @@ class DatabaseConnection_sqlite extends DatabaseConnection {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Gets all the attached databases.
|
||||
*
|
||||
* @return array
|
||||
* An array of attached database names.
|
||||
*
|
||||
* @see DatabaseConnection_sqlite::__construct().
|
||||
*/
|
||||
public function getAttachedDatabases() {
|
||||
return $this->attachedDatabases;
|
||||
}
|
||||
|
||||
/**
|
||||
* SQLite compatibility implementation for the IF() SQL function.
|
||||
*/
|
||||
@@ -235,7 +259,7 @@ class DatabaseConnection_sqlite extends DatabaseConnection {
|
||||
* expose this function to the world.
|
||||
*/
|
||||
public function PDOPrepare($query, array $options = array()) {
|
||||
return parent::prepare($query, $options);
|
||||
return $this->connection->prepare($query, $options);
|
||||
}
|
||||
|
||||
public function queryRange($query, $from, $count, array $args = array(), array $options = array()) {
|
||||
@@ -326,7 +350,7 @@ class DatabaseConnection_sqlite extends DatabaseConnection {
|
||||
}
|
||||
}
|
||||
if ($this->supportsTransactions()) {
|
||||
PDO::rollBack();
|
||||
$this->connection->rollBack();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -341,7 +365,7 @@ class DatabaseConnection_sqlite extends DatabaseConnection {
|
||||
throw new DatabaseTransactionNameNonUniqueException($name . " is already in use.");
|
||||
}
|
||||
if (!$this->inTransaction()) {
|
||||
PDO::beginTransaction();
|
||||
$this->connection->beginTransaction();
|
||||
}
|
||||
$this->transactionLayers[$name] = $name;
|
||||
}
|
||||
@@ -366,9 +390,9 @@ class DatabaseConnection_sqlite extends DatabaseConnection {
|
||||
// If there was any rollback() we should roll back whole transaction.
|
||||
if ($this->willRollback) {
|
||||
$this->willRollback = FALSE;
|
||||
PDO::rollBack();
|
||||
$this->connection->rollBack();
|
||||
}
|
||||
elseif (!PDO::commit()) {
|
||||
elseif (!$this->connection->commit()) {
|
||||
throw new DatabaseTransactionCommitFailedException();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -23,7 +23,7 @@ class InsertQuery_sqlite extends InsertQuery {
|
||||
if (!$this->preExecute()) {
|
||||
return NULL;
|
||||
}
|
||||
if (count($this->insertFields)) {
|
||||
if (count($this->insertFields) || !empty($this->fromQuery)) {
|
||||
return parent::execute();
|
||||
}
|
||||
else {
|
||||
@@ -36,7 +36,10 @@ class InsertQuery_sqlite extends InsertQuery {
|
||||
$comments = $this->connection->makeComment($this->comments);
|
||||
|
||||
// Produce as many generic placeholders as necessary.
|
||||
$placeholders = array_fill(0, count($this->insertFields), '?');
|
||||
$placeholders = array();
|
||||
if (!empty($this->insertFields)) {
|
||||
$placeholders = array_fill(0, count($this->insertFields), '?');
|
||||
}
|
||||
|
||||
// If we're selecting from a SelectQuery, finish building the query and
|
||||
// pass it back, as any remaining options are irrelevant.
|
||||
|
||||
@@ -668,6 +668,9 @@ class DatabaseSchema_sqlite extends DatabaseSchema {
|
||||
$this->alterTable($table, $old_schema, $new_schema);
|
||||
}
|
||||
|
||||
/**
|
||||
* {@inheritdoc}
|
||||
*/
|
||||
public function findTables($table_expression) {
|
||||
// Don't add the prefix, $table_expression already includes the prefix.
|
||||
$info = $this->getPrefixInfo($table_expression, FALSE);
|
||||
@@ -680,4 +683,32 @@ class DatabaseSchema_sqlite extends DatabaseSchema {
|
||||
));
|
||||
return $result->fetchAllKeyed(0, 0);
|
||||
}
|
||||
|
||||
/**
|
||||
* {@inheritdoc}
|
||||
*/
|
||||
public function findTablesD8($table_expression) {
|
||||
$tables = array();
|
||||
|
||||
// The SQLite implementation doesn't need to use the same filtering strategy
|
||||
// as the parent one because individually prefixed tables live in their own
|
||||
// schema (database), which means that neither the main database nor any
|
||||
// attached one will contain a prefixed table name, so we just need to loop
|
||||
// over all known schemas and filter by the user-supplied table expression.
|
||||
$attached_dbs = $this->connection->getAttachedDatabases();
|
||||
foreach ($attached_dbs as $schema) {
|
||||
// Can't use query placeholders for the schema because the query would
|
||||
// have to be :prefixsqlite_master, which does not work. We also need to
|
||||
// ignore the internal SQLite tables.
|
||||
$result = db_query("SELECT name FROM " . $schema . ".sqlite_master WHERE type = :type AND name LIKE :table_name AND name NOT LIKE :pattern", array(
|
||||
':type' => 'table',
|
||||
':table_name' => $table_expression,
|
||||
':pattern' => 'sqlite_%',
|
||||
));
|
||||
$tables += $result->fetchAllKeyed(0, 0);
|
||||
}
|
||||
|
||||
return $tables;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
+1
-4
@@ -48,11 +48,8 @@ function drupal_error_levels() {
|
||||
* The filename that the error was raised in.
|
||||
* @param $line
|
||||
* The line number the error was raised at.
|
||||
* @param $context
|
||||
* An array that points to the active symbol table at the point the error
|
||||
* occurred.
|
||||
*/
|
||||
function _drupal_error_handler_real($error_level, $message, $filename, $line, $context) {
|
||||
function _drupal_error_handler_real($error_level, $message, $filename, $line) {
|
||||
if ($error_level & error_reporting()) {
|
||||
$types = drupal_error_levels();
|
||||
list($severity_msg, $severity_level) = $types[$error_level];
|
||||
|
||||
+99
-25
@@ -532,6 +532,9 @@ SetHandler Drupal_Security_Do_Not_Remove_See_SA_2006_006
|
||||
<IfModule mod_php5.c>
|
||||
php_flag engine off
|
||||
</IfModule>
|
||||
<IfModule mod_php7.c>
|
||||
php_flag engine off
|
||||
</IfModule>
|
||||
EOF;
|
||||
|
||||
if ($private) {
|
||||
@@ -993,8 +996,15 @@ function file_build_uri($path) {
|
||||
* @return
|
||||
* The destination filepath, or FALSE if the file already exists
|
||||
* and FILE_EXISTS_ERROR is specified.
|
||||
*
|
||||
* @throws RuntimeException
|
||||
* Thrown if the filename contains invalid UTF-8.
|
||||
*/
|
||||
function file_destination($destination, $replace) {
|
||||
$basename = drupal_basename($destination);
|
||||
if (!drupal_validate_utf8($basename)) {
|
||||
throw new RuntimeException(sprintf("Invalid filename '%s'", $basename));
|
||||
}
|
||||
if (file_exists($destination)) {
|
||||
switch ($replace) {
|
||||
case FILE_EXISTS_REPLACE:
|
||||
@@ -1002,7 +1012,6 @@ function file_destination($destination, $replace) {
|
||||
break;
|
||||
|
||||
case FILE_EXISTS_RENAME:
|
||||
$basename = drupal_basename($destination);
|
||||
$directory = drupal_dirname($destination);
|
||||
$destination = file_create_filename($basename, $directory);
|
||||
break;
|
||||
@@ -1138,8 +1147,8 @@ function file_unmanaged_move($source, $destination = NULL, $replace = FILE_EXIST
|
||||
* exploit.php_.pps.
|
||||
*
|
||||
* Specifically, this function adds an underscore to all extensions that are
|
||||
* between 2 and 5 characters in length, internal to the file name, and not
|
||||
* included in $extensions.
|
||||
* between 2 and 5 characters in length, internal to the file name, and either
|
||||
* included in the list of unsafe extensions, or not included in $extensions.
|
||||
*
|
||||
* Function behavior is also controlled by the Drupal variable
|
||||
* 'allow_insecure_uploads'. If 'allow_insecure_uploads' evaluates to TRUE, no
|
||||
@@ -1148,7 +1157,8 @@ function file_unmanaged_move($source, $destination = NULL, $replace = FILE_EXIST
|
||||
* @param $filename
|
||||
* File name to modify.
|
||||
* @param $extensions
|
||||
* A space-separated list of extensions that should not be altered.
|
||||
* A space-separated list of extensions that should not be altered. Note that
|
||||
* extensions that are unsafe will be altered regardless of this parameter.
|
||||
* @param $alerts
|
||||
* If TRUE, drupal_set_message() will be called to display a message if the
|
||||
* file name was changed.
|
||||
@@ -1166,6 +1176,10 @@ function file_munge_filename($filename, $extensions, $alerts = TRUE) {
|
||||
|
||||
$whitelist = array_unique(explode(' ', strtolower(trim($extensions))));
|
||||
|
||||
// Remove unsafe extensions from the list of allowed extensions. The list is
|
||||
// copied from file_save_upload().
|
||||
$whitelist = array_diff($whitelist, explode('|', 'php|phar|pl|py|cgi|asp|js'));
|
||||
|
||||
// Split the filename up by periods. The first part becomes the basename
|
||||
// the last part the final extension.
|
||||
$filename_parts = explode('.', $filename);
|
||||
@@ -1218,11 +1232,20 @@ function file_unmunge_filename($filename) {
|
||||
* @return
|
||||
* File path consisting of $directory and a unique filename based off
|
||||
* of $basename.
|
||||
*
|
||||
* @throws RuntimeException
|
||||
* Thrown if the $basename is not valid UTF-8 or another error occurs
|
||||
* stripping control characters.
|
||||
*/
|
||||
function file_create_filename($basename, $directory) {
|
||||
$original = $basename;
|
||||
// Strip control characters (ASCII value < 32). Though these are allowed in
|
||||
// some filesystems, not many applications handle them well.
|
||||
$basename = preg_replace('/[\x00-\x1F]/u', '_', $basename);
|
||||
if (preg_last_error() !== PREG_NO_ERROR) {
|
||||
throw new RuntimeException(sprintf("Invalid filename '%s'", $original));
|
||||
}
|
||||
|
||||
if (substr(PHP_OS, 0, 3) == 'WIN') {
|
||||
// These characters are not allowed in Windows filenames
|
||||
$basename = str_replace(array(':', '*', '?', '"', '<', '>', '|'), '_', $basename);
|
||||
@@ -1524,25 +1547,35 @@ function file_save_upload($form_field_name, $validators = array(), $destination
|
||||
$validators['file_validate_extensions'][0] = $extensions;
|
||||
}
|
||||
|
||||
if (!empty($extensions)) {
|
||||
// Munge the filename to protect against possible malicious extension hiding
|
||||
// within an unknown file type (ie: filename.html.foo).
|
||||
$file->filename = file_munge_filename($file->filename, $extensions);
|
||||
}
|
||||
|
||||
// Rename potentially executable files, to help prevent exploits (i.e. will
|
||||
// rename filename.php.foo and filename.php to filename.php.foo.txt and
|
||||
// filename.php.txt, respectively). Don't rename if 'allow_insecure_uploads'
|
||||
// evaluates to TRUE.
|
||||
if (!variable_get('allow_insecure_uploads', 0) && preg_match('/\.(php|pl|py|cgi|asp|js)(\.|$)/i', $file->filename) && (substr($file->filename, -4) != '.txt')) {
|
||||
$file->filemime = 'text/plain';
|
||||
$file->uri .= '.txt';
|
||||
$file->filename .= '.txt';
|
||||
// The .txt extension may not be in the allowed list of extensions. We have
|
||||
// to add it here or else the file upload will fail.
|
||||
if (!variable_get('allow_insecure_uploads', 0)) {
|
||||
if (!empty($extensions)) {
|
||||
$validators['file_validate_extensions'][0] .= ' txt';
|
||||
drupal_set_message(t('For security reasons, your upload has been renamed to %filename.', array('%filename' => $file->filename)));
|
||||
// Munge the filename to protect against possible malicious extension hiding
|
||||
// within an unknown file type (ie: filename.html.foo).
|
||||
$file->filename = file_munge_filename($file->filename, $extensions);
|
||||
}
|
||||
|
||||
// Rename potentially executable files, to help prevent exploits (i.e. will
|
||||
// rename filename.php.foo and filename.php to filename.php_.foo_.txt and
|
||||
// filename.php_.txt, respectively). Don't rename if 'allow_insecure_uploads'
|
||||
// evaluates to TRUE.
|
||||
if (preg_match('/\.(php|phar|pl|py|cgi|asp|js)(\.|$)/i', $file->filename)) {
|
||||
// If the file will be rejected anyway due to a disallowed extension, it
|
||||
// should not be renamed; rather, we'll let file_validate_extensions()
|
||||
// reject it below.
|
||||
if (!isset($validators['file_validate_extensions']) || !file_validate_extensions($file, $extensions)) {
|
||||
$file->filemime = 'text/plain';
|
||||
if (substr($file->filename, -4) != '.txt') {
|
||||
// The destination filename will also later be used to create the URI.
|
||||
$file->filename .= '.txt';
|
||||
}
|
||||
$file->filename = file_munge_filename($file->filename, $extensions, FALSE);
|
||||
drupal_set_message(t('For security reasons, your upload has been renamed to %filename.', array('%filename' => $file->filename)));
|
||||
// The .txt extension may not be in the allowed list of extensions. We have
|
||||
// to add it here or else the file upload will fail.
|
||||
if (!empty($validators['file_validate_extensions'][0])) {
|
||||
$validators['file_validate_extensions'][0] .= ' txt';
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1563,7 +1596,13 @@ function file_save_upload($form_field_name, $validators = array(), $destination
|
||||
if (substr($destination, -1) != '/') {
|
||||
$destination .= '/';
|
||||
}
|
||||
$file->destination = file_destination($destination . $file->filename, $replace);
|
||||
try {
|
||||
$file->destination = file_destination($destination . $file->filename, $replace);
|
||||
}
|
||||
catch (RuntimeException $e) {
|
||||
drupal_set_message(t('The file %source could not be uploaded because the name is invalid.', array('%source' => $form_field_name)), 'error');
|
||||
return FALSE;
|
||||
}
|
||||
// If file_destination() returns FALSE then $replace == FILE_EXISTS_ERROR and
|
||||
// there's an existing file so we need to bail.
|
||||
if ($file->destination === FALSE) {
|
||||
@@ -1704,7 +1743,18 @@ function file_validate(stdClass &$file, $validators = array()) {
|
||||
}
|
||||
|
||||
// Let other modules perform validation on the new file.
|
||||
return array_merge($errors, module_invoke_all('file_validate', $file));
|
||||
$errors = array_merge($errors, module_invoke_all('file_validate', $file));
|
||||
|
||||
// Ensure the file does not contain a malicious extension. At this point
|
||||
// file_save_upload() will have munged the file so it does not contain a
|
||||
// malicious extension. Contributed and custom code that calls this method
|
||||
// needs to take similar steps if they need to permit files with malicious
|
||||
// extensions to be uploaded.
|
||||
if (empty($errors) && !variable_get('allow_insecure_uploads', 0) && preg_match('/\.(php|phar|pl|py|cgi|asp|js)(\.|$)/i', $file->filename)) {
|
||||
$errors[] = t('For security reasons, your upload has been rejected.');
|
||||
}
|
||||
|
||||
return $errors;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -2130,9 +2180,33 @@ function file_download_access($uri) {
|
||||
* 'filename', and 'name' members corresponding to the matching files.
|
||||
*/
|
||||
function file_scan_directory($dir, $mask, $options = array(), $depth = 0) {
|
||||
// Default nomask option.
|
||||
$nomask = '/(\.\.?|CVS)$/';
|
||||
|
||||
// Overrides the $nomask variable accordingly if $options['nomask'] is set.
|
||||
//
|
||||
// Allow directories specified in settings.php to be ignored. You can use this
|
||||
// to not check for files in common special-purpose directories. For example,
|
||||
// node_modules and bower_components. Ignoring irrelevant directories is a
|
||||
// performance boost.
|
||||
if (!isset($options['nomask'])) {
|
||||
$ignore_directories = variable_get(
|
||||
'file_scan_ignore_directories',
|
||||
array()
|
||||
);
|
||||
|
||||
foreach ($ignore_directories as $index => $ignore_directory) {
|
||||
$ignore_directories[$index] = preg_quote($ignore_directory, '/');
|
||||
}
|
||||
|
||||
if (!empty($ignore_directories)) {
|
||||
$nomask = '/^(\.\.?)|CVS|' . implode('|', $ignore_directories) . '$/';
|
||||
}
|
||||
}
|
||||
|
||||
// Merge in defaults.
|
||||
$options += array(
|
||||
'nomask' => '/(\.\.?|CVS)$/',
|
||||
'nomask' => $nomask,
|
||||
'callback' => 0,
|
||||
'recurse' => TRUE,
|
||||
'key' => 'uri',
|
||||
|
||||
@@ -0,0 +1,55 @@
|
||||
<?php
|
||||
|
||||
use Drupal\Core\Security\PharExtensionInterceptor;
|
||||
use TYPO3\PharStreamWrapper\Manager as PharStreamWrapperManager;
|
||||
use TYPO3\PharStreamWrapper\Behavior as PharStreamWrapperBehavior;
|
||||
use TYPO3\PharStreamWrapper\PharStreamWrapper;
|
||||
|
||||
/**
|
||||
* Registers a phar stream wrapper that is more secure than PHP's built-in one.
|
||||
*
|
||||
* @see file_get_stream_wrappers()
|
||||
*/
|
||||
function file_register_phar_wrapper() {
|
||||
$directory = DRUPAL_ROOT . '/misc/typo3/phar-stream-wrapper/src';
|
||||
include_once $directory . '/Assertable.php';
|
||||
include_once $directory . '/Behavior.php';
|
||||
include_once $directory . '/Exception.php';
|
||||
include_once $directory . '/Helper.php';
|
||||
include_once $directory . '/Manager.php';
|
||||
include_once $directory . '/PharStreamWrapper.php';
|
||||
include_once $directory . '/Collectable.php';
|
||||
include_once $directory . '/Interceptor/ConjunctionInterceptor.php';
|
||||
include_once $directory . '/Interceptor/PharMetaDataInterceptor.php';
|
||||
include_once $directory . '/Phar/Container.php';
|
||||
include_once $directory . '/Phar/DeserializationException.php';
|
||||
include_once $directory . '/Phar/Manifest.php';
|
||||
include_once $directory . '/Phar/Reader.php';
|
||||
include_once $directory . '/Phar/ReaderException.php';
|
||||
include_once $directory . '/Phar/Stub.php';
|
||||
include_once $directory . '/Resolvable.php';
|
||||
include_once $directory . '/Resolver/PharInvocation.php';
|
||||
include_once $directory . '/Resolver/PharInvocationCollection.php';
|
||||
include_once $directory . '/Resolver/PharInvocationResolver.php';
|
||||
include_once DRUPAL_ROOT . '/misc/typo3/drupal-security/PharExtensionInterceptor.php';
|
||||
include_once DRUPAL_ROOT . '/misc/brumann/polyfill-unserialize/src/Unserialize.php';
|
||||
|
||||
// Set up a stream wrapper to handle insecurities due to PHP's built-in
|
||||
// phar stream wrapper.
|
||||
try {
|
||||
$behavior = new PharStreamWrapperBehavior();
|
||||
PharStreamWrapperManager::initialize(
|
||||
$behavior->withAssertion(new PharExtensionInterceptor())
|
||||
);
|
||||
}
|
||||
catch (\LogicException $e) {
|
||||
// Continue if the PharStreamWrapperManager is already initialized.
|
||||
// For example, this occurs following a drupal_static_reset(), such
|
||||
// as during tests.
|
||||
};
|
||||
|
||||
// To prevent file_stream_wrapper_valid_scheme() treating "phar" as a valid
|
||||
// scheme, this is registered with PHP only, not with hook_stream_wrappers()
|
||||
// or the internal storage of file_get_stream_wrappers().
|
||||
stream_wrapper_register('phar', '\\TYPO3\\PharStreamWrapper\\PharStreamWrapper');
|
||||
}
|
||||
@@ -301,7 +301,7 @@ abstract class FileTransfer {
|
||||
$parts = explode('/', $path);
|
||||
$chroot = '';
|
||||
while (count($parts)) {
|
||||
$check = implode($parts, '/');
|
||||
$check = implode('/', $parts);
|
||||
if ($this->isFile($check . '/' . drupal_basename(__FILE__))) {
|
||||
// Remove the trailing slash.
|
||||
return substr($chroot, 0, -1);
|
||||
|
||||
+29
-10
@@ -555,8 +555,10 @@ function form_get_cache($form_build_id, &$form_state) {
|
||||
* Stores a form in the cache.
|
||||
*/
|
||||
function form_set_cache($form_build_id, $form, $form_state) {
|
||||
// 6 hours cache life time for forms should be plenty.
|
||||
$expire = 21600;
|
||||
// The default cache_form expiration is 6 hours. On busy sites, the cache_form
|
||||
// table can become very large. A shorter cache lifetime can help to keep the
|
||||
// table's size under control.
|
||||
$expire = variable_get('form_cache_expiration', 21600);
|
||||
|
||||
// Ensure that the form build_id embedded in the form structure is the same as
|
||||
// the one passed in as a parameter. This is an additional safety measure to
|
||||
@@ -1133,12 +1135,8 @@ function drupal_prepare_form($form_id, &$form, &$form_state) {
|
||||
* Helper function to call form_set_error() if there is a token error.
|
||||
*/
|
||||
function _drupal_invalid_token_set_form_error() {
|
||||
$path = current_path();
|
||||
$query = drupal_get_query_parameters();
|
||||
$url = url($path, array('query' => $query));
|
||||
|
||||
// Setting this error will cause the form to fail validation.
|
||||
form_set_error('form_token', t('The form has become outdated. Copy any unsaved work in the form below and then <a href="@link">reload this page</a>.', array('@link' => $url)));
|
||||
form_set_error('form_token', t('The form has become outdated. Press the back button, copy any unsaved work in the form, and then reload the page.'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -1179,6 +1177,11 @@ function drupal_validate_form($form_id, &$form, &$form_state) {
|
||||
if (!empty($form['#token'])) {
|
||||
if (!drupal_valid_token($form_state['values']['form_token'], $form['#token']) || !empty($form_state['invalid_token'])) {
|
||||
_drupal_invalid_token_set_form_error();
|
||||
// Ignore all submitted values.
|
||||
$form_state['input'] = array();
|
||||
$_POST = array();
|
||||
// Make sure file uploads do not get processed.
|
||||
$_FILES = array();
|
||||
// Stop here and don't run any further validation handlers, because they
|
||||
// could invoke non-safe operations which opens the door for CSRF
|
||||
// vulnerabilities.
|
||||
@@ -1358,7 +1361,10 @@ function _form_validate(&$elements, &$form_state, $form_id = NULL) {
|
||||
// The following errors are always shown.
|
||||
if (isset($elements['#needs_validation'])) {
|
||||
// Verify that the value is not longer than #maxlength.
|
||||
if (isset($elements['#maxlength']) && drupal_strlen($elements['#value']) > $elements['#maxlength']) {
|
||||
if (isset($elements['#maxlength']) && (isset($elements['#value']) && !is_scalar($elements['#value']))) {
|
||||
form_error($elements, $t('An illegal value has been detected. Please contact the site administrator.'));
|
||||
}
|
||||
elseif (isset($elements['#maxlength']) && drupal_strlen($elements['#value']) > $elements['#maxlength']) {
|
||||
form_error($elements, $t('!name cannot be longer than %max characters but is currently %length characters long.', array('!name' => empty($elements['#title']) ? $elements['#parents'][0] : $elements['#title'], '%max' => $elements['#maxlength'], '%length' => drupal_strlen($elements['#value']))));
|
||||
}
|
||||
|
||||
@@ -1438,10 +1444,12 @@ function _form_validate(&$elements, &$form_state, $form_id = NULL) {
|
||||
// length if it's a string, and the item count if it's an array.
|
||||
// An unchecked checkbox has a #value of integer 0, different than string
|
||||
// '0', which could be a valid value.
|
||||
$is_empty_multiple = (!count($elements['#value']));
|
||||
$is_countable = is_array($elements['#value']) || $elements['#value'] instanceof Countable;
|
||||
$is_empty_multiple = $is_countable && count($elements['#value']) == 0;
|
||||
$is_empty_string = (is_string($elements['#value']) && drupal_strlen(trim($elements['#value'])) == 0);
|
||||
$is_empty_value = ($elements['#value'] === 0);
|
||||
if ($is_empty_multiple || $is_empty_string || $is_empty_value) {
|
||||
$is_empty_null = is_null($elements['#value']);
|
||||
if ($is_empty_multiple || $is_empty_string || $is_empty_value || $is_empty_null) {
|
||||
// Although discouraged, a #title is not mandatory for form elements. In
|
||||
// case there is no #title, we cannot set a form error message.
|
||||
// Instead of setting no #title, form constructors are encouraged to set
|
||||
@@ -1844,6 +1852,9 @@ function form_builder($form_id, &$element, &$form_state) {
|
||||
_drupal_invalid_token_set_form_error();
|
||||
// This value is checked in _form_builder_handle_input_element().
|
||||
$form_state['invalid_token'] = TRUE;
|
||||
// Ignore all submitted values.
|
||||
$form_state['input'] = array();
|
||||
$_POST = array();
|
||||
// Make sure file uploads do not get processed.
|
||||
$_FILES = array();
|
||||
}
|
||||
@@ -4116,9 +4127,17 @@ function form_process_weight($element) {
|
||||
$max_elements = variable_get('drupal_weight_select_max', DRUPAL_WEIGHT_SELECT_MAX);
|
||||
if ($element['#delta'] <= $max_elements) {
|
||||
$element['#type'] = 'select';
|
||||
$weights = array();
|
||||
for ($n = (-1 * $element['#delta']); $n <= $element['#delta']; $n++) {
|
||||
$weights[$n] = $n;
|
||||
}
|
||||
if (isset($element['#default_value'])) {
|
||||
$default_value = (int) $element['#default_value'];
|
||||
if (!isset($weights[$default_value])) {
|
||||
$weights[$default_value] = $default_value;
|
||||
ksort($weights);
|
||||
}
|
||||
}
|
||||
$element['#options'] = $weights;
|
||||
$element += element_info('select');
|
||||
}
|
||||
|
||||
@@ -779,7 +779,7 @@ function drupal_uninstall_modules($module_list = array(), $uninstall_dependents
|
||||
$module_list = array_flip(array_values($module_list));
|
||||
|
||||
$profile = drupal_get_profile();
|
||||
while (list($module) = each($module_list)) {
|
||||
foreach (array_keys($module_list) as $module) {
|
||||
if (!isset($module_data[$module]) || drupal_get_installed_schema_version($module) == SCHEMA_UNINSTALLED) {
|
||||
// This module doesn't exist or is already uninstalled. Skip it.
|
||||
unset($module_list[$module]);
|
||||
|
||||
+62
-2
@@ -12,6 +12,12 @@
|
||||
*/
|
||||
define('MAIL_LINE_ENDINGS', isset($_SERVER['WINDIR']) || (isset($_SERVER['SERVER_SOFTWARE']) && strpos($_SERVER['SERVER_SOFTWARE'], 'Win32') !== FALSE) ? "\r\n" : "\n");
|
||||
|
||||
|
||||
/**
|
||||
* Special characters, defined in RFC_2822.
|
||||
*/
|
||||
define('MAIL_RFC_2822_SPECIALS', '()<>[]:;@\,."');
|
||||
|
||||
/**
|
||||
* Composes and optionally sends an e-mail message.
|
||||
*
|
||||
@@ -148,8 +154,13 @@ function drupal_mail($module, $key, $to, $language, $params = array(), $from = N
|
||||
// Return-Path headers should have a domain authorized to use the originating
|
||||
// SMTP server.
|
||||
$headers['From'] = $headers['Sender'] = $headers['Return-Path'] = $default_from;
|
||||
|
||||
if (variable_get('mail_display_name_site_name', FALSE)) {
|
||||
$display_name = variable_get('site_name', 'Drupal');
|
||||
$headers['From'] = drupal_mail_format_display_name($display_name) . ' <' . $default_from . '>';
|
||||
}
|
||||
}
|
||||
if ($from) {
|
||||
if ($from && $from != $default_from) {
|
||||
$headers['From'] = $from;
|
||||
}
|
||||
$message['headers'] = $headers;
|
||||
@@ -557,10 +568,59 @@ function drupal_html_to_text($string, $allowed_tags = NULL) {
|
||||
return $output . $footnotes;
|
||||
}
|
||||
|
||||
/**
|
||||
* Return a RFC-2822 compliant "display-name" component.
|
||||
*
|
||||
* The "display-name" component is used in mail header "Originator" fields
|
||||
* (From, Sender, Reply-to) to give a human-friendly description of the
|
||||
* address, i.e. From: My Display Name <xyz@example.org>. RFC-822 and
|
||||
* RFC-2822 define its syntax and rules. This method gets as input a string
|
||||
* to be used as "display-name" and formats it to be RFC compliant.
|
||||
*
|
||||
* @param string $string
|
||||
* A string to be used as "display-name".
|
||||
*
|
||||
* @return string
|
||||
* A RFC compliant version of the string, ready to be used as
|
||||
* "display-name" in mail originator header fields.
|
||||
*/
|
||||
function drupal_mail_format_display_name($string) {
|
||||
// Make sure we don't process html-encoded characters. They may create
|
||||
// unneeded trouble if left encoded, besides they will be correctly
|
||||
// processed if decoded.
|
||||
$string = decode_entities($string);
|
||||
|
||||
// If string contains non-ASCII characters it must be (short) encoded
|
||||
// according to RFC-2047. The output of a "B" (Base64) encoded-word is
|
||||
// always safe to be used as display-name.
|
||||
$safe_display_name = mime_header_encode($string, TRUE);
|
||||
|
||||
// Encoded-words are always safe to be used as display-name because don't
|
||||
// contain any RFC 2822 "specials" characters. However
|
||||
// mimeHeaderEncode() encodes a string only if it contains any
|
||||
// non-ASCII characters, and leaves its value untouched (un-encoded) if
|
||||
// ASCII only. For this reason in order to produce a valid display-name we
|
||||
// still need to make sure there are no "specials" characters left.
|
||||
if (preg_match('/[' . preg_quote(MAIL_RFC_2822_SPECIALS) . ']/', $safe_display_name)) {
|
||||
|
||||
// If string is already quoted, it may or may not be escaped properly, so
|
||||
// don't trust it and reset.
|
||||
if (preg_match('/^"(.+)"$/', $safe_display_name, $matches)) {
|
||||
$safe_display_name = str_replace(array('\\\\', '\\"'), array('\\', '"'), $matches[1]);
|
||||
}
|
||||
|
||||
// Transform the string in a RFC-2822 "quoted-string" by wrapping it in
|
||||
// double-quotes. Also make sure '"' and '\' occurrences are escaped.
|
||||
$safe_display_name = '"' . str_replace(array('\\', '"'), array('\\\\', '\\"'), $safe_display_name) . '"';
|
||||
}
|
||||
|
||||
return $safe_display_name;
|
||||
}
|
||||
|
||||
/**
|
||||
* Wraps words on a single line.
|
||||
*
|
||||
* Callback for array_walk() winthin drupal_wrap_mail().
|
||||
* Callback for array_walk() within drupal_wrap_mail().
|
||||
*/
|
||||
function _drupal_wrap_mail_line(&$line, $key, $values) {
|
||||
// Use soft-breaks only for purely quoted or unindented text.
|
||||
|
||||
+12
-6
@@ -317,7 +317,7 @@ define('MENU_PREFERRED_LINK', '1cf698d64d1aa4b83907cf6ed55db3a7f8e92c91');
|
||||
* actually exists. This list of 'masks' is built in menu_rebuild().
|
||||
*
|
||||
* @param $parts
|
||||
* An array of path parts; for the above example,
|
||||
* An array of path parts; for the above example,
|
||||
* array('node', '12345', 'edit').
|
||||
*
|
||||
* @return
|
||||
@@ -576,7 +576,8 @@ function _menu_load_objects(&$item, &$map) {
|
||||
// 'load arguments' in the hook_menu() entry, but they need
|
||||
// some processing. In this case the $function is the key to the
|
||||
// load_function array, and the value is the list of arguments.
|
||||
list($function, $args) = each($function);
|
||||
$args = current($function);
|
||||
$function = key($function);
|
||||
$load_functions[$index] = $function;
|
||||
|
||||
// Some arguments are placeholders for dynamic items to process.
|
||||
@@ -1066,7 +1067,7 @@ function menu_tree_output($tree) {
|
||||
// the active class accordingly. But local tasks do not appear in menu
|
||||
// trees, so if the current path is a local task, and this link is its
|
||||
// tab root, then we have to set the class manually.
|
||||
if ($data['link']['href'] == $router_item['tab_root_href'] && $data['link']['href'] != $_GET['q']) {
|
||||
if ($router_item && $data['link']['href'] == $router_item['tab_root_href'] && $data['link']['href'] != $_GET['q']) {
|
||||
$data['link']['localized_options']['attributes']['class'][] = 'active';
|
||||
}
|
||||
|
||||
@@ -2402,7 +2403,8 @@ function menu_set_active_trail($new_trail = NULL) {
|
||||
// a stripped down menu tree containing the active trail only, in case
|
||||
// the given menu has not been built in this request yet.
|
||||
$tree = menu_tree_page_data($preferred_link['menu_name'], NULL, TRUE);
|
||||
list($key, $curr) = each($tree);
|
||||
$curr = current($tree);
|
||||
next($tree);
|
||||
}
|
||||
// There is no link for the current path.
|
||||
else {
|
||||
@@ -2432,7 +2434,8 @@ function menu_set_active_trail($new_trail = NULL) {
|
||||
}
|
||||
$tree = $curr['below'] ? $curr['below'] : array();
|
||||
}
|
||||
list($key, $curr) = each($tree);
|
||||
$curr = current($tree);
|
||||
next($tree);
|
||||
}
|
||||
// Make sure the current page is in the trail to build the page title, by
|
||||
// appending either the preferred link or the menu router item for the
|
||||
@@ -2480,6 +2483,9 @@ function menu_link_get_preferred($path = NULL, $selected_menu = NULL) {
|
||||
// untranslated paths). Afterwards, the most relevant path is picked from
|
||||
// the menus, ordered by menu preference.
|
||||
$item = menu_get_item($path);
|
||||
if ($item === FALSE) {
|
||||
return FALSE;
|
||||
}
|
||||
$path_candidates = array();
|
||||
// 1. The current item href.
|
||||
$path_candidates[$item['href']] = $item['href'];
|
||||
@@ -2589,7 +2595,7 @@ function menu_get_active_breadcrumb() {
|
||||
|
||||
// Don't show a link to the current page in the breadcrumb trail.
|
||||
$end = end($active_trail);
|
||||
if ($item['href'] == $end['href']) {
|
||||
if (is_array($end) && $item['href'] == $end['href']) {
|
||||
array_pop($active_trail);
|
||||
}
|
||||
|
||||
|
||||
+10
-2
@@ -404,7 +404,11 @@ function module_enable($module_list, $enable_dependencies = TRUE) {
|
||||
// Create an associative array with weights as values.
|
||||
$module_list = array_flip(array_values($module_list));
|
||||
|
||||
while (list($module) = each($module_list)) {
|
||||
// The array is iterated over manually (instead of using a foreach) because
|
||||
// modules may be added to the list within the loop and we need to process
|
||||
// them.
|
||||
while ($module = key($module_list)) {
|
||||
next($module_list);
|
||||
if (!isset($module_data[$module])) {
|
||||
// This module is not found in the filesystem, abort.
|
||||
return FALSE;
|
||||
@@ -540,7 +544,11 @@ function module_disable($module_list, $disable_dependents = TRUE) {
|
||||
$module_list = array_flip(array_values($module_list));
|
||||
|
||||
$profile = drupal_get_profile();
|
||||
while (list($module) = each($module_list)) {
|
||||
// The array is iterated over manually (instead of using a foreach) because
|
||||
// modules may be added to the list within the loop and we need to process
|
||||
// them.
|
||||
while ($module = key($module_list)) {
|
||||
next($module_list);
|
||||
if (!isset($module_data[$module]) || !$module_data[$module]->status) {
|
||||
// This module doesn't exist or is already disabled, skip it.
|
||||
unset($module_list[$module]);
|
||||
|
||||
+31
-1
@@ -321,9 +321,19 @@ function theme_pager($variables) {
|
||||
$tags = $variables['tags'];
|
||||
$element = $variables['element'];
|
||||
$parameters = $variables['parameters'];
|
||||
$quantity = $variables['quantity'];
|
||||
$quantity = empty($variables['quantity']) ? 0 : $variables['quantity'];
|
||||
global $pager_page_array, $pager_total;
|
||||
|
||||
// Nothing to do if there is no pager.
|
||||
if (!isset($pager_page_array[$element]) || !isset($pager_total[$element])) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Nothing to do if there is only one page.
|
||||
if ($pager_total[$element] <= 1) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Calculate various markers within this pager piece:
|
||||
// Middle is used to "center" pages around the current page.
|
||||
$pager_middle = ceil($quantity / 2);
|
||||
@@ -455,6 +465,11 @@ function theme_pager_first($variables) {
|
||||
global $pager_page_array;
|
||||
$output = '';
|
||||
|
||||
// Nothing to do if there is no pager.
|
||||
if (!isset($pager_page_array[$element])) {
|
||||
return;
|
||||
}
|
||||
|
||||
// If we are anywhere but the first page
|
||||
if ($pager_page_array[$element] > 0) {
|
||||
$output = theme('pager_link', array('text' => $text, 'page_new' => pager_load_array(0, $element, $pager_page_array), 'element' => $element, 'parameters' => $parameters));
|
||||
@@ -485,6 +500,11 @@ function theme_pager_previous($variables) {
|
||||
global $pager_page_array;
|
||||
$output = '';
|
||||
|
||||
// Nothing to do if there is no pager.
|
||||
if (!isset($pager_page_array[$element])) {
|
||||
return;
|
||||
}
|
||||
|
||||
// If we are anywhere but the first page
|
||||
if ($pager_page_array[$element] > 0) {
|
||||
$page_new = pager_load_array($pager_page_array[$element] - $interval, $element, $pager_page_array);
|
||||
@@ -524,6 +544,11 @@ function theme_pager_next($variables) {
|
||||
global $pager_page_array, $pager_total;
|
||||
$output = '';
|
||||
|
||||
// Nothing to do if there is no pager.
|
||||
if (!isset($pager_page_array[$element]) || !isset($pager_total[$element])) {
|
||||
return;
|
||||
}
|
||||
|
||||
// If we are anywhere but the last page
|
||||
if ($pager_page_array[$element] < ($pager_total[$element] - 1)) {
|
||||
$page_new = pager_load_array($pager_page_array[$element] + $interval, $element, $pager_page_array);
|
||||
@@ -560,6 +585,11 @@ function theme_pager_last($variables) {
|
||||
global $pager_page_array, $pager_total;
|
||||
$output = '';
|
||||
|
||||
// Nothing to do if there is no pager.
|
||||
if (!isset($pager_page_array[$element]) || !isset($pager_total[$element])) {
|
||||
return;
|
||||
}
|
||||
|
||||
// If we are anywhere but the last page
|
||||
if ($pager_page_array[$element] < ($pager_total[$element] - 1)) {
|
||||
$output = theme('pager_link', array('text' => $text, 'page_new' => pager_load_array($pager_total[$element] - 1, $element, $pager_page_array), 'element' => $element, 'parameters' => $parameters));
|
||||
|
||||
+8
-6
@@ -466,13 +466,15 @@ function path_delete($criteria) {
|
||||
$criteria = array('pid' => $criteria);
|
||||
}
|
||||
$path = path_load($criteria);
|
||||
$query = db_delete('url_alias');
|
||||
foreach ($criteria as $field => $value) {
|
||||
$query->condition($field, $value);
|
||||
if (isset($path['source'])) {
|
||||
$query = db_delete('url_alias');
|
||||
foreach ($criteria as $field => $value) {
|
||||
$query->condition($field, $value);
|
||||
}
|
||||
$query->execute();
|
||||
module_invoke_all('path_delete', $path);
|
||||
drupal_clear_path_cache($path['source']);
|
||||
}
|
||||
$query->execute();
|
||||
module_invoke_all('path_delete', $path);
|
||||
drupal_clear_path_cache($path['source']);
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
+30
-5
@@ -19,7 +19,6 @@
|
||||
* Does the work for registry_update().
|
||||
*/
|
||||
function _registry_update() {
|
||||
|
||||
// The registry serves as a central autoloader for all classes, including
|
||||
// the database query builders. However, the registry rebuild process
|
||||
// requires write ability to the database, which means having access to the
|
||||
@@ -33,6 +32,11 @@ function _registry_update() {
|
||||
require_once DRUPAL_ROOT . '/includes/database/select.inc';
|
||||
require_once DRUPAL_ROOT . '/includes/database/' . $driver . '/query.inc';
|
||||
|
||||
// During the first registry rebuild in a request, we check all the files.
|
||||
// During subsequent rebuilds, we only add new files. It makes the rebuilding
|
||||
// process faster during installation of modules.
|
||||
static $check_existing_files = TRUE;
|
||||
|
||||
// Get current list of modules and their files.
|
||||
$modules = db_query("SELECT * FROM {system} WHERE type = 'module'")->fetchAll();
|
||||
// Get the list of files we are going to parse.
|
||||
@@ -55,6 +59,9 @@ function _registry_update() {
|
||||
$files["$filename"] = array('module' => '', 'weight' => 0);
|
||||
}
|
||||
|
||||
// Initialize an empty array for the unchanged files.
|
||||
$unchanged_files = array();
|
||||
|
||||
$transaction = db_transaction();
|
||||
try {
|
||||
// Allow modules to manually modify the list of files before the registry
|
||||
@@ -63,10 +70,19 @@ function _registry_update() {
|
||||
// list can then be added to the list of files that the registry will parse,
|
||||
// or modify attributes of a file.
|
||||
drupal_alter('registry_files', $files, $modules);
|
||||
|
||||
foreach (registry_get_parsed_files() as $filename => $file) {
|
||||
// Add the hash for those files we have already parsed.
|
||||
if (isset($files[$filename])) {
|
||||
$files[$filename]['hash'] = $file['hash'];
|
||||
if ($check_existing_files === TRUE) {
|
||||
$files[$filename]['hash'] = $file['hash'];
|
||||
}
|
||||
else {
|
||||
// Ignore that file for this request, it has been parsed previously
|
||||
// and it is unlikely it has changed.
|
||||
unset($files[$filename]);
|
||||
$unchanged_files[$filename] = $file;
|
||||
}
|
||||
}
|
||||
else {
|
||||
// Flush the registry of resources in files that are no longer on disc
|
||||
@@ -79,8 +95,12 @@ function _registry_update() {
|
||||
->execute();
|
||||
}
|
||||
}
|
||||
|
||||
$parsed_files = _registry_parse_files($files);
|
||||
|
||||
// Add unchanged files to the files.
|
||||
$files += $unchanged_files;
|
||||
|
||||
$unchanged_resources = array();
|
||||
$lookup_cache = array();
|
||||
if ($cache = cache_get('lookup_cache', 'cache_bootstrap')) {
|
||||
@@ -89,12 +109,10 @@ function _registry_update() {
|
||||
foreach ($lookup_cache as $key => $file) {
|
||||
// If the file for this cached resource is carried over unchanged from
|
||||
// the last registry build, then we can safely re-cache it.
|
||||
if ($file && in_array($file, array_keys($files)) && !in_array($file, $parsed_files)) {
|
||||
if ($file && isset($files[$file]) && !in_array($file, $parsed_files, TRUE)) {
|
||||
$unchanged_resources[$key] = $file;
|
||||
}
|
||||
}
|
||||
module_implements('', FALSE, TRUE);
|
||||
_registry_check_code(REGISTRY_RESET_LOOKUP_CACHE);
|
||||
}
|
||||
catch (Exception $e) {
|
||||
$transaction->rollback();
|
||||
@@ -102,6 +120,13 @@ function _registry_update() {
|
||||
throw $e;
|
||||
}
|
||||
|
||||
module_implements('', FALSE, TRUE);
|
||||
_registry_check_code(REGISTRY_RESET_LOOKUP_CACHE);
|
||||
|
||||
// During the next run in this request, don't bother re-checking existing
|
||||
// files.
|
||||
$check_existing_files = FALSE;
|
||||
|
||||
// We have some unchanged resources, warm up the cache - no need to pay
|
||||
// for looking them up again.
|
||||
if (count($unchanged_resources) > 0) {
|
||||
|
||||
@@ -51,6 +51,38 @@ class DrupalRequestSanitizer {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Removes the destination if it is dangerous.
|
||||
*
|
||||
* Note this can only be called after common.inc has been included.
|
||||
*
|
||||
* @return bool
|
||||
* TRUE if the destination has been removed from $_GET, FALSE if not.
|
||||
*/
|
||||
public static function cleanDestination() {
|
||||
$dangerous_keys = array();
|
||||
$log_sanitized_keys = variable_get('sanitize_input_logging', FALSE);
|
||||
|
||||
$parts = drupal_parse_url($_GET['destination']);
|
||||
// If there is a query string, check its query parameters.
|
||||
if (!empty($parts['query'])) {
|
||||
$whitelist = variable_get('sanitize_input_whitelist', array());
|
||||
|
||||
self::stripDangerousValues($parts['query'], $whitelist, $dangerous_keys);
|
||||
if (!empty($dangerous_keys)) {
|
||||
// The destination is removed rather than sanitized to mirror the
|
||||
// handling of external destinations.
|
||||
unset($_GET['destination']);
|
||||
unset($_REQUEST['destination']);
|
||||
if ($log_sanitized_keys) {
|
||||
trigger_error(format_string('Potentially unsafe destination removed from query string parameters (GET) because it contained the following keys: @keys', array('@keys' => implode(', ', $dangerous_keys))));
|
||||
}
|
||||
return TRUE;
|
||||
}
|
||||
}
|
||||
return FALSE;
|
||||
}
|
||||
|
||||
/**
|
||||
* Strips dangerous keys from the provided input.
|
||||
*
|
||||
@@ -67,7 +99,7 @@ class DrupalRequestSanitizer {
|
||||
protected static function stripDangerousValues($input, array $whitelist, array &$sanitized_keys) {
|
||||
if (is_array($input)) {
|
||||
foreach ($input as $key => $value) {
|
||||
if ($key !== '' && $key[0] === '#' && !in_array($key, $whitelist, TRUE)) {
|
||||
if ($key !== '' && is_string($key) && $key[0] === '#' && !in_array($key, $whitelist, TRUE)) {
|
||||
unset($input[$key]);
|
||||
$sanitized_keys[] = $key;
|
||||
}
|
||||
|
||||
+70
-5
@@ -284,6 +284,20 @@ function drupal_session_start() {
|
||||
// Save current session data before starting it, as PHP will destroy it.
|
||||
$session_data = isset($_SESSION) ? $_SESSION : NULL;
|
||||
|
||||
// Apply any overrides to the session cookie params.
|
||||
$params = $original_params = session_get_cookie_params();
|
||||
// PHP settings for samesite will be handled by _drupal_cookie_params().
|
||||
unset($params['samesite']);
|
||||
$params = _drupal_cookie_params($params);
|
||||
if ($params !== $original_params) {
|
||||
if (\PHP_VERSION_ID >= 70300) {
|
||||
session_set_cookie_params($params);
|
||||
}
|
||||
else {
|
||||
session_set_cookie_params($params['lifetime'], $params['path'], $params['domain'], $params['secure'], $params['httponly']);
|
||||
}
|
||||
}
|
||||
|
||||
session_start();
|
||||
drupal_session_started(TRUE);
|
||||
|
||||
@@ -323,7 +337,14 @@ function drupal_session_commit() {
|
||||
$insecure_session_name = substr(session_name(), 1);
|
||||
$params = session_get_cookie_params();
|
||||
$expire = $params['lifetime'] ? REQUEST_TIME + $params['lifetime'] : 0;
|
||||
setcookie($insecure_session_name, $_COOKIE[$insecure_session_name], $expire, $params['path'], $params['domain'], FALSE, $params['httponly']);
|
||||
$options = array(
|
||||
'expires' => $expire,
|
||||
'path' => $params['path'],
|
||||
'domain' => $params['domain'],
|
||||
'secure' => FALSE,
|
||||
'httponly' => $params['httponly'],
|
||||
);
|
||||
drupal_setcookie($insecure_session_name, $_COOKIE[$insecure_session_name], $options);
|
||||
}
|
||||
}
|
||||
// Write the session data.
|
||||
@@ -365,19 +386,36 @@ function drupal_session_regenerate() {
|
||||
// $params['lifetime'] seconds from the current request. If it is not set,
|
||||
// it will expire when the browser is closed.
|
||||
$expire = $params['lifetime'] ? REQUEST_TIME + $params['lifetime'] : 0;
|
||||
setcookie($insecure_session_name, $session_id, $expire, $params['path'], $params['domain'], FALSE, $params['httponly']);
|
||||
$options = array(
|
||||
'expires' => $expire,
|
||||
'path' => $params['path'],
|
||||
'domain' => $params['domain'],
|
||||
'secure' => FALSE,
|
||||
'httponly' => $params['httponly'],
|
||||
);
|
||||
drupal_setcookie($insecure_session_name, $session_id, $options);
|
||||
$_COOKIE[$insecure_session_name] = $session_id;
|
||||
}
|
||||
|
||||
if (drupal_session_started()) {
|
||||
$old_session_id = session_id();
|
||||
_drupal_session_regenerate_existing();
|
||||
}
|
||||
else {
|
||||
session_id(drupal_random_key());
|
||||
}
|
||||
session_id(drupal_random_key());
|
||||
|
||||
if (isset($old_session_id)) {
|
||||
$params = session_get_cookie_params();
|
||||
$expire = $params['lifetime'] ? REQUEST_TIME + $params['lifetime'] : 0;
|
||||
setcookie(session_name(), session_id(), $expire, $params['path'], $params['domain'], $params['secure'], $params['httponly']);
|
||||
$options = array(
|
||||
'expires' => $expire,
|
||||
'path' => $params['path'],
|
||||
'domain' => $params['domain'],
|
||||
'secure' => $params['secure'],
|
||||
'httponly' => $params['httponly'],
|
||||
);
|
||||
drupal_setcookie(session_name(), session_id(), $options);
|
||||
$fields = array('sid' => session_id());
|
||||
if ($is_https) {
|
||||
$fields['ssid'] = session_id();
|
||||
@@ -412,6 +450,26 @@ function drupal_session_regenerate() {
|
||||
date_default_timezone_set(drupal_get_user_timezone());
|
||||
}
|
||||
|
||||
/**
|
||||
* Regenerates an existing session.
|
||||
*/
|
||||
function _drupal_session_regenerate_existing() {
|
||||
global $user;
|
||||
// Preserve existing settings for the saving of sessions.
|
||||
$original_save_session_status = drupal_save_session();
|
||||
// Turn off saving of sessions.
|
||||
drupal_save_session(FALSE);
|
||||
session_write_close();
|
||||
drupal_session_started(FALSE);
|
||||
// Preserve the user object, as starting a new session will reset it.
|
||||
$original_user = $user;
|
||||
session_id(drupal_random_key());
|
||||
drupal_session_start();
|
||||
$user = $original_user;
|
||||
// Restore the original settings for the saving of sessions.
|
||||
drupal_save_session($original_save_session_status);
|
||||
}
|
||||
|
||||
/**
|
||||
* Session handler assigned by session_set_save_handler().
|
||||
*
|
||||
@@ -465,7 +523,14 @@ function _drupal_session_delete_cookie($name, $secure = NULL) {
|
||||
if ($secure !== NULL) {
|
||||
$params['secure'] = $secure;
|
||||
}
|
||||
setcookie($name, '', REQUEST_TIME - 3600, $params['path'], $params['domain'], $params['secure'], $params['httponly']);
|
||||
$options = array(
|
||||
'expires' => REQUEST_TIME - 3600,
|
||||
'path' => $params['path'],
|
||||
'domain' => $params['domain'],
|
||||
'secure' => $params['secure'],
|
||||
'httponly' => $params['httponly'],
|
||||
);
|
||||
drupal_setcookie($name, '', $options);
|
||||
unset($_COOKIE[$name]);
|
||||
}
|
||||
}
|
||||
|
||||
+70
-31
@@ -1776,13 +1776,13 @@ function theme_link($variables) {
|
||||
* http://www.w3.org/TR/WCAG-TECHS/H42.html for more information.
|
||||
*/
|
||||
function theme_links($variables) {
|
||||
$links = $variables['links'];
|
||||
$attributes = $variables['attributes'];
|
||||
$links = (array) $variables['links'];
|
||||
$attributes = (array) $variables['attributes'];
|
||||
$heading = $variables['heading'];
|
||||
global $language_url;
|
||||
$output = '';
|
||||
|
||||
if (count($links) > 0) {
|
||||
if (!empty($links)) {
|
||||
// Treat the heading first if it is present to prepend it to the
|
||||
// list of links.
|
||||
if (!empty($heading)) {
|
||||
@@ -1911,7 +1911,7 @@ function theme_breadcrumb($variables) {
|
||||
/**
|
||||
* Returns HTML for a table.
|
||||
*
|
||||
* @param $variables
|
||||
* @param array $variables
|
||||
* An associative array containing:
|
||||
* - header: An array containing the table headers. Each element of the array
|
||||
* can be either a localized string or an associative array with the
|
||||
@@ -1948,6 +1948,11 @@ function theme_breadcrumb($variables) {
|
||||
* )
|
||||
* );
|
||||
* @endcode
|
||||
* - footer: An array of table rows which will be printed within a <tfoot>
|
||||
* tag, in the same format as the rows element (see above).
|
||||
* The structure is the same the one defined for the "rows" key except
|
||||
* that the no_striping boolean has no effect, there is no rows striping
|
||||
* for the table footer.
|
||||
* - attributes: An array of HTML attributes to apply to the table tag.
|
||||
* - caption: A localized string to use for the <caption> tag.
|
||||
* - colgroups: An array of column groups. Each element of the array can be
|
||||
@@ -1984,8 +1989,11 @@ function theme_breadcrumb($variables) {
|
||||
* - sticky: Use a "sticky" table header.
|
||||
* - empty: The message to display in an extra row if table does not have any
|
||||
* rows.
|
||||
*
|
||||
* @return string
|
||||
* The HTML output.
|
||||
*/
|
||||
function theme_table($variables) {
|
||||
function theme_table(array $variables) {
|
||||
$header = $variables['header'];
|
||||
$rows = $variables['rows'];
|
||||
$attributes = $variables['attributes'];
|
||||
@@ -1995,7 +2003,7 @@ function theme_table($variables) {
|
||||
$empty = $variables['empty'];
|
||||
|
||||
// Add sticky headers, if applicable.
|
||||
if (count($header) && $sticky) {
|
||||
if (!empty($header) && $sticky) {
|
||||
drupal_add_js('misc/tableheader.js');
|
||||
// Add 'sticky-enabled' class to the table to identify it for JS.
|
||||
// This is needed to target tables constructed by this function.
|
||||
@@ -2009,7 +2017,7 @@ function theme_table($variables) {
|
||||
}
|
||||
|
||||
// Format the table columns:
|
||||
if (count($colgroups)) {
|
||||
if (!empty($colgroups)) {
|
||||
foreach ($colgroups as $number => $colgroup) {
|
||||
$attributes = array();
|
||||
|
||||
@@ -2044,46 +2052,74 @@ function theme_table($variables) {
|
||||
}
|
||||
|
||||
// Add the 'empty' row message if available.
|
||||
if (!count($rows) && $empty) {
|
||||
if (empty($rows) && $empty) {
|
||||
$header_count = 0;
|
||||
foreach ($header as $header_cell) {
|
||||
if (is_array($header_cell)) {
|
||||
$header_count += isset($header_cell['colspan']) ? $header_cell['colspan'] : 1;
|
||||
}
|
||||
else {
|
||||
$header_count++;
|
||||
if (!empty($header)) {
|
||||
foreach ($header as $header_cell) {
|
||||
if (is_array($header_cell)) {
|
||||
$header_count += isset($header_cell['colspan']) ?
|
||||
$header_cell['colspan'] : 1;
|
||||
}
|
||||
else {
|
||||
$header_count++;
|
||||
}
|
||||
}
|
||||
}
|
||||
$rows[] = array(array('data' => $empty, 'colspan' => $header_count, 'class' => array('empty', 'message')));
|
||||
$rows[] = array(
|
||||
array(
|
||||
'data' => $empty,
|
||||
'colspan' => $header_count,
|
||||
'class' => array(
|
||||
'empty',
|
||||
'message'
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
// Format the table header:
|
||||
if (count($header)) {
|
||||
// Format the table header.
|
||||
if (!empty($header)) {
|
||||
$ts = tablesort_init($header);
|
||||
// HTML requires that the thead tag has tr tags in it followed by tbody
|
||||
// tags. Using ternary operator to check and see if we have any rows.
|
||||
$output .= (count($rows) ? ' <thead><tr>' : ' <tr>');
|
||||
$output .= (!empty($rows) ? ' <thead><tr>' : ' <tr>');
|
||||
foreach ($header as $cell) {
|
||||
$cell = tablesort_header($cell, $header, $ts);
|
||||
$output .= _theme_table_cell($cell, TRUE);
|
||||
}
|
||||
// Using ternary operator to close the tags based on whether or not there are rows
|
||||
$output .= (count($rows) ? " </tr></thead>\n" : "</tr>\n");
|
||||
// Using ternary operator to close the tags based on whether
|
||||
// or not there are rows.
|
||||
$output .= (!empty($rows) ? " </tr></thead>\n" : "</tr>\n");
|
||||
}
|
||||
else {
|
||||
$ts = array();
|
||||
}
|
||||
|
||||
// Format the table rows:
|
||||
if (count($rows)) {
|
||||
$output .= "<tbody>\n";
|
||||
// Format the table and footer rows.
|
||||
$sections = array();
|
||||
|
||||
if (!empty($rows)) {
|
||||
$sections['tbody'] = $rows;
|
||||
}
|
||||
|
||||
if (!empty($variables['footer'])) {
|
||||
$sections['tfoot'] = $variables['footer'];
|
||||
}
|
||||
|
||||
// tbody and tfoot have the same structure and are built using the same
|
||||
// procedure.
|
||||
foreach ($sections as $tag => $content) {
|
||||
$output .= "<" . $tag . ">\n";
|
||||
$flip = array('even' => 'odd', 'odd' => 'even');
|
||||
$class = 'even';
|
||||
foreach ($rows as $number => $row) {
|
||||
// Check if we're dealing with a simple or complex row
|
||||
$default_no_striping = ($tag === 'tfoot');
|
||||
|
||||
foreach ($content as $number => $row) {
|
||||
// Check if we're dealing with a simple or complex row.
|
||||
if (isset($row['data'])) {
|
||||
$cells = $row['data'];
|
||||
$no_striping = isset($row['no_striping']) ? $row['no_striping'] : FALSE;
|
||||
$no_striping = isset($row['no_striping']) ?
|
||||
$row['no_striping'] : $default_no_striping;
|
||||
|
||||
// Set the attributes array and exclude 'data' and 'no_striping'.
|
||||
$attributes = $row;
|
||||
@@ -2093,16 +2129,17 @@ function theme_table($variables) {
|
||||
else {
|
||||
$cells = $row;
|
||||
$attributes = array();
|
||||
$no_striping = FALSE;
|
||||
$no_striping = $default_no_striping;
|
||||
}
|
||||
if (count($cells)) {
|
||||
// Add odd/even class
|
||||
|
||||
if (!empty($cells)) {
|
||||
// Add odd/even class.
|
||||
if (!$no_striping) {
|
||||
$class = $flip[$class];
|
||||
$attributes['class'][] = $class;
|
||||
}
|
||||
|
||||
// Build row
|
||||
// Build row.
|
||||
$output .= ' <tr' . drupal_attributes($attributes) . '>';
|
||||
$i = 0;
|
||||
foreach ($cells as $cell) {
|
||||
@@ -2112,10 +2149,12 @@ function theme_table($variables) {
|
||||
$output .= " </tr>\n";
|
||||
}
|
||||
}
|
||||
$output .= "</tbody>\n";
|
||||
|
||||
$output .= "</" . $tag . ">\n";
|
||||
}
|
||||
|
||||
$output .= "</table>\n";
|
||||
|
||||
return $output;
|
||||
}
|
||||
|
||||
|
||||
+22
-2
@@ -149,7 +149,7 @@ Drupal.ajax = function (base, element, element_settings) {
|
||||
// The 'this' variable will not persist inside of the options object.
|
||||
var ajax = this;
|
||||
ajax.options = {
|
||||
url: ajax.url,
|
||||
url: Drupal.sanitizeAjaxUrl(ajax.url),
|
||||
data: ajax.submit,
|
||||
beforeSerialize: function (element_settings, options) {
|
||||
return ajax.beforeSerialize(element_settings, options);
|
||||
@@ -195,9 +195,29 @@ Drupal.ajax = function (base, element, element_settings) {
|
||||
}
|
||||
},
|
||||
dataType: 'json',
|
||||
jsonp: false,
|
||||
type: 'POST'
|
||||
};
|
||||
|
||||
// For multipart forms (e.g., file uploads), jQuery Form targets the form
|
||||
// submission to an iframe instead of using an XHR object. The initial "src"
|
||||
// of the iframe, prior to the form submission, is set to options.iframeSrc.
|
||||
// "about:blank" is the semantically correct, standards-compliant, way to
|
||||
// initialize a blank iframe; however, some old IE versions (possibly only 6)
|
||||
// incorrectly report a mixed content warning when iframes with an
|
||||
// "about:blank" src are added to a parent document with an https:// origin.
|
||||
// jQuery Form works around this by defaulting to "javascript:false" instead,
|
||||
// but that breaks on Chrome 83, so here we force the semantically correct
|
||||
// behavior for all browsers except old IE.
|
||||
// @see https://www.drupal.org/project/drupal/issues/3143016
|
||||
// @see https://github.com/jquery-form/form/blob/df9cb101b9c9c085c8d75ad980c7ff1cf62063a1/jquery.form.js#L68
|
||||
// @see https://bugs.chromium.org/p/chromium/issues/detail?id=1084874
|
||||
// @see https://html.spec.whatwg.org/multipage/browsers.html#creating-browsing-contexts
|
||||
// @see https://developer.mozilla.org/en-US/docs/Web/Security/Same-origin_policy
|
||||
if (navigator.userAgent.indexOf("MSIE") === -1) {
|
||||
ajax.options.iframeSrc = 'about:blank';
|
||||
}
|
||||
|
||||
// Bind the ajaxSubmit function to the element event.
|
||||
$(ajax.element).bind(element_settings.event, function (event) {
|
||||
if (!Drupal.settings.urlIsAjaxTrusted[ajax.url] && !Drupal.urlIsLocal(ajax.url)) {
|
||||
@@ -388,7 +408,7 @@ Drupal.ajax.prototype.beforeSend = function (xmlhttprequest, options) {
|
||||
|
||||
// Insert progressbar or throbber.
|
||||
if (this.progress.type == 'bar') {
|
||||
var progressBar = new Drupal.progressBar('ajax-progress-' + this.element.id, eval(this.progress.update_callback), this.progress.method, eval(this.progress.error_callback));
|
||||
var progressBar = new Drupal.progressBar('ajax-progress-' + this.element.id, $.noop, this.progress.method, $.noop);
|
||||
if (this.progress.message) {
|
||||
progressBar.setProgress(-1, this.progress.message);
|
||||
}
|
||||
|
||||
@@ -297,8 +297,9 @@ Drupal.ACDB.prototype.search = function (searchString) {
|
||||
// encodeURIComponent to allow autocomplete search terms to contain slashes.
|
||||
$.ajax({
|
||||
type: 'GET',
|
||||
url: db.uri + '/' + Drupal.encodePath(searchString),
|
||||
url: Drupal.sanitizeAjaxUrl(db.uri + '/' + Drupal.encodePath(searchString)),
|
||||
dataType: 'json',
|
||||
jsonp: false,
|
||||
success: function (matches) {
|
||||
if (typeof matches.status == 'undefined' || matches.status != 0) {
|
||||
db.cache[searchString] = matches;
|
||||
|
||||
@@ -0,0 +1,4 @@
|
||||
/vendor/
|
||||
/phpunit.xml
|
||||
/.composer.lock
|
||||
|
||||
@@ -0,0 +1,20 @@
|
||||
language: php
|
||||
|
||||
sudo: false
|
||||
|
||||
php:
|
||||
- '5.3'
|
||||
- '5.4'
|
||||
- '5.5'
|
||||
- '5.6'
|
||||
- '7.0'
|
||||
- '7.1'
|
||||
|
||||
before_install:
|
||||
- phpenv config-rm xdebug.ini
|
||||
- composer self-update
|
||||
|
||||
install:
|
||||
- composer install
|
||||
|
||||
script: phpunit
|
||||
@@ -0,0 +1,21 @@
|
||||
MIT License
|
||||
|
||||
Copyright (c) 2016 Denis Brumann
|
||||
|
||||
Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
of this software and associated documentation files (the "Software"), to deal
|
||||
in the Software without restriction, including without limitation the rights
|
||||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
copies of the Software, and to permit persons to whom the Software is
|
||||
furnished to do so, subject to the following conditions:
|
||||
|
||||
The above copyright notice and this permission notice shall be included in all
|
||||
copies or substantial portions of the Software.
|
||||
|
||||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
||||
SOFTWARE.
|
||||
@@ -0,0 +1,61 @@
|
||||
Polyfill unserialize [](https://travis-ci.org/dbrumann/polyfill-unserialize)
|
||||
===
|
||||
|
||||
Backports unserialize options introduced in PHP 7.0 to older PHP versions.
|
||||
This was originally designed as a Proof of Concept for Symfony Issue [#21090](https://github.com/symfony/symfony/pull/21090).
|
||||
|
||||
You can use this package in projects that rely on PHP versions older than PHP 7.0.
|
||||
In case you are using PHP 7.0+ the original `unserialize()` will be used instead.
|
||||
|
||||
From the [documentation](https://secure.php.net/manual/en/function.unserialize.php):
|
||||
|
||||
> Warning: Do not pass untrusted user input to unserialize(). Unserialization can
|
||||
> result in code being loaded and executed due to object instantiation
|
||||
> and autoloading, and a malicious user may be able to exploit this.
|
||||
|
||||
This warning holds true even when `allowed_classes` is used.
|
||||
|
||||
Requirements
|
||||
------------
|
||||
|
||||
- PHP 5.3+
|
||||
|
||||
Installation
|
||||
------------
|
||||
|
||||
You can install this package via composer:
|
||||
|
||||
```
|
||||
composer require brumann/polyfill-unserialize "^1.0"
|
||||
```
|
||||
|
||||
Known Issues
|
||||
------------
|
||||
|
||||
There is a mismatch in behavior when `allowed_classes` in `$options` is not
|
||||
of the correct type (array or boolean). PHP 7.1 will issue a warning, whereas
|
||||
PHP 7.0 will not. I opted to copy the behavior of the former.
|
||||
|
||||
Tests
|
||||
-----
|
||||
|
||||
You can run the test suite using PHPUnit. It is intentionally not bundled as
|
||||
dev dependency to make sure this package has the lowest restrictions on the
|
||||
implementing system as possible.
|
||||
|
||||
Please read the [PHPUnit Manual](https://phpunit.de/manual/current/en/installation.html)
|
||||
for information how to install it on your system.
|
||||
|
||||
You can run the test suite as follows:
|
||||
|
||||
```
|
||||
phpunit -c phpunit.xml.dist tests/
|
||||
```
|
||||
|
||||
Contributing
|
||||
------------
|
||||
|
||||
This package is considered feature complete. As such I will likely not update it
|
||||
unless there are security issues.
|
||||
|
||||
Should you find any bugs or have questions, feel free to submit an Issue or a Pull Request.
|
||||
@@ -0,0 +1,26 @@
|
||||
{
|
||||
"name": "brumann/polyfill-unserialize",
|
||||
"description": "Backports unserialize options introduced in PHP 7.0 to older PHP versions.",
|
||||
"type": "library",
|
||||
"license": "MIT",
|
||||
"authors": [
|
||||
{
|
||||
"name": "Denis Brumann",
|
||||
"email": "denis.brumann@sensiolabs.de"
|
||||
}
|
||||
],
|
||||
"autoload": {
|
||||
"psr-4": {
|
||||
"Brumann\\Polyfill\\": "src/"
|
||||
}
|
||||
},
|
||||
"autoload-dev": {
|
||||
"psr-4": {
|
||||
"Tests\\Brumann\\Polyfill\\": "tests/"
|
||||
}
|
||||
},
|
||||
"minimum-stability": "stable",
|
||||
"require": {
|
||||
"php": "^5.3|^7.0"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,25 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
|
||||
<phpunit
|
||||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
|
||||
xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.1/phpunit.xsd"
|
||||
backupGlobals="false"
|
||||
colors="true"
|
||||
bootstrap="vendor/autoload.php"
|
||||
>
|
||||
<php>
|
||||
<ini name="error_reporting" value="-1" />
|
||||
</php>
|
||||
|
||||
<testsuites>
|
||||
<testsuite name="Brumann\Polyfill Test Suite">
|
||||
<directory>./tests/</directory>
|
||||
</testsuite>
|
||||
</testsuites>
|
||||
|
||||
<filter>
|
||||
<whitelist>
|
||||
<directory>./src/</directory>
|
||||
</whitelist>
|
||||
</filter>
|
||||
</phpunit>
|
||||
@@ -0,0 +1,58 @@
|
||||
<?php
|
||||
|
||||
namespace Brumann\Polyfill;
|
||||
|
||||
final class Unserialize
|
||||
{
|
||||
/**
|
||||
* @see https://secure.php.net/manual/en/function.unserialize.php
|
||||
*
|
||||
* @param string $serialized Serialized data
|
||||
* @param array $options Associative array containing options
|
||||
*
|
||||
* @return mixed
|
||||
*/
|
||||
public static function unserialize($serialized, array $options = array())
|
||||
{
|
||||
if (PHP_VERSION_ID >= 70000) {
|
||||
return \unserialize($serialized, $options);
|
||||
}
|
||||
if (!array_key_exists('allowed_classes', $options)) {
|
||||
$options['allowed_classes'] = true;
|
||||
}
|
||||
$allowedClasses = $options['allowed_classes'];
|
||||
if (true === $allowedClasses) {
|
||||
return \unserialize($serialized);
|
||||
}
|
||||
if (false === $allowedClasses) {
|
||||
$allowedClasses = array();
|
||||
}
|
||||
if (!is_array($allowedClasses)) {
|
||||
trigger_error(
|
||||
'unserialize(): allowed_classes option should be array or boolean',
|
||||
E_USER_WARNING
|
||||
);
|
||||
$allowedClasses = array();
|
||||
}
|
||||
|
||||
$sanitizedSerialized = preg_replace_callback(
|
||||
'/(^|;)O:\d+:"([^"]*)":(\d+):{/',
|
||||
function ($match) use ($allowedClasses) {
|
||||
list($completeMatch, $leftBorder, $className, $objectSize) = $match;
|
||||
if (in_array($className, $allowedClasses)) {
|
||||
return $completeMatch;
|
||||
} else {
|
||||
return sprintf(
|
||||
'%sO:22:"__PHP_Incomplete_Class":%d:{s:27:"__PHP_Incomplete_Class_Name";%s',
|
||||
$leftBorder,
|
||||
$objectSize + 1, // size of object + 1 for added string
|
||||
\serialize($className)
|
||||
);
|
||||
}
|
||||
},
|
||||
$serialized
|
||||
);
|
||||
|
||||
return \unserialize($sanitizedSerialized);
|
||||
}
|
||||
}
|
||||
@@ -424,6 +424,23 @@ Drupal.urlIsLocal = function (url) {
|
||||
return absoluteUrl === baseUrl || absoluteUrl.indexOf(baseUrl + '/') === 0;
|
||||
};
|
||||
|
||||
/**
|
||||
* Sanitizes a URL for use with jQuery.ajax().
|
||||
*
|
||||
* @param url
|
||||
* The URL string to be sanitized.
|
||||
*
|
||||
* @return
|
||||
* The sanitized URL.
|
||||
*/
|
||||
Drupal.sanitizeAjaxUrl = function (url) {
|
||||
var regex = /\=\?(&|$)/;
|
||||
while (url.match(regex)) {
|
||||
url = url.replace(regex, '');
|
||||
}
|
||||
return url;
|
||||
}
|
||||
|
||||
/**
|
||||
* Generate the themed representation of a Drupal object.
|
||||
*
|
||||
|
||||
@@ -0,0 +1,112 @@
|
||||
/**
|
||||
* For jQuery versions less than 3.4.0, this replaces the jQuery.extend
|
||||
* function with the one from jQuery 3.4.0, slightly modified (documented
|
||||
* below) to be compatible with older jQuery versions and browsers.
|
||||
*
|
||||
* This provides the Object.prototype pollution vulnerability fix to Drupal
|
||||
* installations running older jQuery versions, including the versions shipped
|
||||
* with Drupal core and https://www.drupal.org/project/jquery_update.
|
||||
*
|
||||
* @see https://github.com/jquery/jquery/pull/4333
|
||||
*/
|
||||
|
||||
(function (jQuery) {
|
||||
|
||||
// Do not override jQuery.extend() if the jQuery version is already >=3.4.0.
|
||||
var versionParts = jQuery.fn.jquery.split('.');
|
||||
var majorVersion = parseInt(versionParts[0]);
|
||||
var minorVersion = parseInt(versionParts[1]);
|
||||
var patchVersion = parseInt(versionParts[2]);
|
||||
var isPreReleaseVersion = (patchVersion.toString() !== versionParts[2]);
|
||||
if (
|
||||
(majorVersion > 3) ||
|
||||
(majorVersion === 3 && minorVersion > 4) ||
|
||||
(majorVersion === 3 && minorVersion === 4 && patchVersion > 0) ||
|
||||
(majorVersion === 3 && minorVersion === 4 && patchVersion === 0 && !isPreReleaseVersion)
|
||||
) {
|
||||
return;
|
||||
}
|
||||
|
||||
/**
|
||||
* This is almost verbatim copied from jQuery 3.4.0.
|
||||
*
|
||||
* Only two minor changes have been made:
|
||||
* - The call to isFunction() is changed to jQuery.isFunction().
|
||||
* - The two calls to Array.isArray() is changed to jQuery.isArray().
|
||||
*
|
||||
* The above two changes ensure compatibility with all older jQuery versions
|
||||
* (1.4.4 - 3.3.1) and older browser versions (e.g., IE8).
|
||||
*/
|
||||
jQuery.extend = jQuery.fn.extend = function() {
|
||||
var options, name, src, copy, copyIsArray, clone,
|
||||
target = arguments[ 0 ] || {},
|
||||
i = 1,
|
||||
length = arguments.length,
|
||||
deep = false;
|
||||
|
||||
// Handle a deep copy situation
|
||||
if ( typeof target === "boolean" ) {
|
||||
deep = target;
|
||||
|
||||
// Skip the boolean and the target
|
||||
target = arguments[ i ] || {};
|
||||
i++;
|
||||
}
|
||||
|
||||
// Handle case when target is a string or something (possible in deep copy)
|
||||
if ( typeof target !== "object" && !jQuery.isFunction( target ) ) {
|
||||
target = {};
|
||||
}
|
||||
|
||||
// Extend jQuery itself if only one argument is passed
|
||||
if ( i === length ) {
|
||||
target = this;
|
||||
i--;
|
||||
}
|
||||
|
||||
for ( ; i < length; i++ ) {
|
||||
|
||||
// Only deal with non-null/undefined values
|
||||
if ( ( options = arguments[ i ] ) != null ) {
|
||||
|
||||
// Extend the base object
|
||||
for ( name in options ) {
|
||||
copy = options[ name ];
|
||||
|
||||
// Prevent Object.prototype pollution
|
||||
// Prevent never-ending loop
|
||||
if ( name === "__proto__" || target === copy ) {
|
||||
continue;
|
||||
}
|
||||
|
||||
// Recurse if we're merging plain objects or arrays
|
||||
if ( deep && copy && ( jQuery.isPlainObject( copy ) ||
|
||||
( copyIsArray = jQuery.isArray( copy ) ) ) ) {
|
||||
src = target[ name ];
|
||||
|
||||
// Ensure proper type for the source value
|
||||
if ( copyIsArray && !jQuery.isArray( src ) ) {
|
||||
clone = [];
|
||||
} else if ( !copyIsArray && !jQuery.isPlainObject( src ) ) {
|
||||
clone = {};
|
||||
} else {
|
||||
clone = src;
|
||||
}
|
||||
copyIsArray = false;
|
||||
|
||||
// Never move original objects, clone them
|
||||
target[ name ] = jQuery.extend( deep, clone, copy );
|
||||
|
||||
// Don't bring in undefined values
|
||||
} else if ( copy !== undefined ) {
|
||||
target[ name ] = copy;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Return the modified object
|
||||
return target;
|
||||
};
|
||||
|
||||
})(jQuery);
|
||||
@@ -0,0 +1,251 @@
|
||||
/**
|
||||
* For jQuery versions less than 3.5.0, this replaces the jQuery.htmlPrefilter()
|
||||
* function with one that fixes these security vulnerabilities while also
|
||||
* retaining the pre-3.5.0 behavior where it's safe to do so.
|
||||
* - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11022
|
||||
* - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023
|
||||
*
|
||||
* Additionally, for jQuery versions that do not have a jQuery.htmlPrefilter()
|
||||
* function (1.x prior to 1.12 and 2.x prior to 2.2), this adds it, and
|
||||
* extends the functions that need to call it to do so.
|
||||
*
|
||||
* Drupal core's jQuery version is 1.4.4, but jQuery Update can provide a
|
||||
* different version, so this covers all versions between 1.4.4 and 3.4.1.
|
||||
* The GitHub links in the code comments below link to jQuery 1.5 code, because
|
||||
* 1.4.4 isn't on GitHub, but the referenced code didn't change from 1.4.4 to
|
||||
* 1.5.
|
||||
*/
|
||||
|
||||
(function (jQuery) {
|
||||
|
||||
// Parts of this backport differ by jQuery version.
|
||||
var versionParts = jQuery.fn.jquery.split('.');
|
||||
var majorVersion = parseInt(versionParts[0]);
|
||||
var minorVersion = parseInt(versionParts[1]);
|
||||
|
||||
// No backport is needed if we're already on jQuery 3.5 or higher.
|
||||
if ( (majorVersion > 3) || (majorVersion === 3 && minorVersion >= 5) ) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Prior to jQuery 3.5, jQuery converted XHTML-style self-closing tags to
|
||||
// their XML equivalent: e.g., "<div />" to "<div></div>". This is
|
||||
// problematic for several reasons, including that it's vulnerable to XSS
|
||||
// attacks. However, since this was jQuery's behavior for many years, many
|
||||
// Drupal modules and jQuery plugins may be relying on it. Therefore, we
|
||||
// preserve that behavior, but for a limited set of tags only, that we believe
|
||||
// to not be vulnerable. This is the set of HTML tags that satisfy all of the
|
||||
// following conditions:
|
||||
// - In DOMPurify's list of HTML tags. If an HTML tag isn't safe enough to
|
||||
// appear in that list, then we don't want to mess with it here either.
|
||||
// @see https://github.com/cure53/DOMPurify/blob/2.0.11/dist/purify.js#L128
|
||||
// - A normal element (not a void, template, text, or foreign element).
|
||||
// @see https://html.spec.whatwg.org/multipage/syntax.html#elements-2
|
||||
// - An element that is still defined by the current HTML specification
|
||||
// (not a deprecated element), because we do not want to rely on how
|
||||
// browsers parse deprecated elements.
|
||||
// @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element
|
||||
// - Not 'html', 'head', or 'body', because this pseudo-XHTML expansion is
|
||||
// designed for fragments, not entire documents.
|
||||
// - Not 'colgroup', because due to an idiosyncrasy of jQuery's original
|
||||
// regular expression, it didn't match on colgroup, and we don't want to
|
||||
// introduce a behavior change for that.
|
||||
var selfClosingTagsToReplace = [
|
||||
'a', 'abbr', 'address', 'article', 'aside', 'audio', 'b', 'bdi', 'bdo',
|
||||
'blockquote', 'button', 'canvas', 'caption', 'cite', 'code', 'data',
|
||||
'datalist', 'dd', 'del', 'details', 'dfn', 'div', 'dl', 'dt', 'em',
|
||||
'fieldset', 'figcaption', 'figure', 'footer', 'form', 'h1', 'h2', 'h3',
|
||||
'h4', 'h5', 'h6', 'header', 'hgroup', 'i', 'ins', 'kbd', 'label', 'legend',
|
||||
'li', 'main', 'map', 'mark', 'menu', 'meter', 'nav', 'ol', 'optgroup',
|
||||
'option', 'output', 'p', 'picture', 'pre', 'progress', 'q', 'rp', 'rt',
|
||||
'ruby', 's', 'samp', 'section', 'select', 'small', 'source', 'span',
|
||||
'strong', 'sub', 'summary', 'sup', 'table', 'tbody', 'td', 'tfoot', 'th',
|
||||
'thead', 'time', 'tr', 'u', 'ul', 'var', 'video'
|
||||
];
|
||||
|
||||
// Define regular expressions for <TAG/> and <TAG ATTRIBUTES/>. Doing this as
|
||||
// two expressions makes it easier to target <a/> without also targeting
|
||||
// every tag that starts with "a".
|
||||
var xhtmlRegExpGroup = '(' + selfClosingTagsToReplace.join('|') + ')';
|
||||
var whitespace = '[\\x20\\t\\r\\n\\f]';
|
||||
var rxhtmlTagWithoutSpaceOrAttributes = new RegExp('<' + xhtmlRegExpGroup + '\\/>', 'gi');
|
||||
var rxhtmlTagWithSpaceAndMaybeAttributes = new RegExp('<' + xhtmlRegExpGroup + '(' + whitespace + '[^>]*)\\/>', 'gi');
|
||||
|
||||
// jQuery 3.5 also fixed a vulnerability for when </select> appears within
|
||||
// an <option> or <optgroup>, but it did that in local code that we can't
|
||||
// backport directly. Instead, we filter such cases out. To do so, we need to
|
||||
// determine when jQuery would otherwise invoke the vulnerable code, which it
|
||||
// uses this regular expression to determine. The regular expression changed
|
||||
// for version 3.0.0 and changed again for 3.4.0.
|
||||
// @see https://github.com/jquery/jquery/blob/1.5/jquery.js#L4958
|
||||
// @see https://github.com/jquery/jquery/blob/3.0.0/dist/jquery.js#L4584
|
||||
// @see https://github.com/jquery/jquery/blob/3.4.0/dist/jquery.js#L4712
|
||||
var rtagName;
|
||||
if (majorVersion < 3) {
|
||||
rtagName = /<([\w:]+)/;
|
||||
}
|
||||
else if (minorVersion < 4) {
|
||||
rtagName = /<([a-z][^\/\0>\x20\t\r\n\f]+)/i;
|
||||
}
|
||||
else {
|
||||
rtagName = /<([a-z][^\/\0>\x20\t\r\n\f]*)/i;
|
||||
}
|
||||
|
||||
// The regular expression that jQuery uses to determine which self-closing
|
||||
// tags to expand to open and close tags. This is vulnerable, because it
|
||||
// matches all tag names except the few excluded ones. We only use this
|
||||
// expression for determining vulnerability. The expression changed for
|
||||
// version 3, but we only need to check for vulnerability in versions 1 and 2,
|
||||
// so we use the expression from those versions.
|
||||
// @see https://github.com/jquery/jquery/blob/1.5/jquery.js#L4957
|
||||
var rxhtmlTag = /<(?!area|br|col|embed|hr|img|input|link|meta|param)(([\w:]+)[^>]*)\/>/gi;
|
||||
|
||||
jQuery.extend({
|
||||
htmlPrefilter: function (html) {
|
||||
// This is how jQuery determines the first tag in the HTML.
|
||||
// @see https://github.com/jquery/jquery/blob/1.5/jquery.js#L5521
|
||||
var tag = ( rtagName.exec( html ) || [ "", "" ] )[ 1 ].toLowerCase();
|
||||
|
||||
// It is not valid HTML for <option> or <optgroup> to have <select> as
|
||||
// either a descendant or sibling, and attempts to inject one can cause
|
||||
// XSS on jQuery versions before 3.5. Since this is invalid HTML and a
|
||||
// possible XSS attack, reject the entire string.
|
||||
// @see https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023
|
||||
if ((tag === 'option' || tag === 'optgroup') && html.match(/<\/?select/i)) {
|
||||
html = '';
|
||||
}
|
||||
|
||||
// Retain jQuery's prior to 3.5 conversion of pseudo-XHTML, but for only
|
||||
// the tags in the `selfClosingTagsToReplace` list defined above.
|
||||
// @see https://github.com/jquery/jquery/blob/1.5/jquery.js#L5518
|
||||
// @see https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11022
|
||||
html = html.replace(rxhtmlTagWithoutSpaceOrAttributes, "<$1></$1>");
|
||||
html = html.replace(rxhtmlTagWithSpaceAndMaybeAttributes, "<$1$2></$1>");
|
||||
|
||||
// Prior to jQuery 1.12 and 2.2, this function gets called (via code later
|
||||
// in this file) in addition to, rather than instead of, the unsafe
|
||||
// expansion of self-closing tags (including ones not in the list above).
|
||||
// We can't prevent that unsafe expansion from running, so instead we
|
||||
// check to make sure that it doesn't affect the DOM returned by the
|
||||
// browser's parsing logic. If it does affect it, then it's vulnerable to
|
||||
// XSS, so we reject the entire string.
|
||||
if ( (majorVersion === 1 && minorVersion < 12) || (majorVersion === 2 && minorVersion < 2) ) {
|
||||
var htmlRisky = html.replace(rxhtmlTag, "<$1></$2>");
|
||||
if (htmlRisky !== html) {
|
||||
// Even though htmlRisky and html are different strings, they might
|
||||
// represent the same HTML structure once parsed, in which case,
|
||||
// htmlRisky is actually safe. We can ask the browser to parse both
|
||||
// to find out, but the browser can't parse table fragments (e.g., a
|
||||
// root-level "<td>"), so we need to wrap them. We just need this
|
||||
// technique to work on all supported browsers; we don't need to
|
||||
// copy from the specific jQuery version we're using.
|
||||
// @see https://github.com/jquery/jquery/blob/3.5.1/dist/jquery.js#L4939
|
||||
var wrapMap = {
|
||||
thead: [ 1, "<table>", "</table>" ],
|
||||
col: [ 2, "<table><colgroup>", "</colgroup></table>" ],
|
||||
tr: [ 2, "<table><tbody>", "</tbody></table>" ],
|
||||
td: [ 3, "<table><tbody><tr>", "</tr></tbody></table>" ],
|
||||
};
|
||||
wrapMap.tbody = wrapMap.tfoot = wrapMap.colgroup = wrapMap.caption = wrapMap.thead;
|
||||
wrapMap.th = wrapMap.td;
|
||||
|
||||
// Function to wrap HTML into something that a browser can parse.
|
||||
// @see https://github.com/jquery/jquery/blob/3.5.1/dist/jquery.js#L5032
|
||||
var getWrappedHtml = function (html) {
|
||||
var wrap = wrapMap[tag];
|
||||
if (wrap) {
|
||||
html = wrap[1] + html + wrap[2];
|
||||
}
|
||||
return html;
|
||||
};
|
||||
|
||||
// Function to return canonical HTML after parsing it. This parses
|
||||
// only; it doesn't execute scripts.
|
||||
// @see https://github.com/jquery/jquery-migrate/blob/3.3.0/src/jquery/manipulation.js#L5
|
||||
var getParsedHtml = function (html) {
|
||||
var doc = window.document.implementation.createHTMLDocument( "" );
|
||||
doc.body.innerHTML = html;
|
||||
return doc.body ? doc.body.innerHTML : '';
|
||||
};
|
||||
|
||||
// If the browser couldn't parse either one successfully, or if
|
||||
// htmlRisky parses differently than html, then html is vulnerable,
|
||||
// so reject it.
|
||||
var htmlParsed = getParsedHtml(getWrappedHtml(html));
|
||||
var htmlRiskyParsed = getParsedHtml(getWrappedHtml(htmlRisky));
|
||||
if (htmlRiskyParsed === '' || htmlParsed === '' || (htmlRiskyParsed !== htmlParsed)) {
|
||||
html = '';
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return html;
|
||||
}
|
||||
});
|
||||
|
||||
// Prior to jQuery 1.12 and 2.2, jQuery.clean(), jQuery.buildFragment(), and
|
||||
// jQuery.fn.html() did not call jQuery.htmlPrefilter(), so we add that.
|
||||
if ( (majorVersion === 1 && minorVersion < 12) || (majorVersion === 2 && minorVersion < 2) ) {
|
||||
// Filter the HTML coming into jQuery.fn.html().
|
||||
var fnOriginalHtml = jQuery.fn.html;
|
||||
jQuery.fn.extend({
|
||||
// @see https://github.com/jquery/jquery/blob/1.5/jquery.js#L5147
|
||||
html: function (value) {
|
||||
if (typeof value === "string") {
|
||||
value = jQuery.htmlPrefilter(value);
|
||||
}
|
||||
// .html() can be called as a setter (with an argument) or as a getter
|
||||
// (without an argument), so invoke fnOriginalHtml() the same way that
|
||||
// we were invoked.
|
||||
return fnOriginalHtml.apply(this, arguments.length ? [value] : []);
|
||||
}
|
||||
});
|
||||
|
||||
// The regular expression that jQuery uses to determine if a string is HTML.
|
||||
// Used by both clean() and buildFragment().
|
||||
// @see https://github.com/jquery/jquery/blob/1.5/jquery.js#L4960
|
||||
var rhtml = /<|&#?\w+;/;
|
||||
|
||||
// Filter HTML coming into:
|
||||
// - jQuery.clean() for versions prior to 1.9.
|
||||
// - jQuery.buildFragment() for 1.9 and above.
|
||||
//
|
||||
// The looping constructs in the two functions might be essentially
|
||||
// identical, but they're each expressed here in the way that most closely
|
||||
// matches their original expression in jQuery, so that we filter all of
|
||||
// the items and only the items that jQuery will treat as HTML strings.
|
||||
if (majorVersion === 1 && minorVersion < 9) {
|
||||
var originalClean = jQuery.clean;
|
||||
jQuery.extend({
|
||||
// @see https://github.com/jquery/jquery/blob/1.5/jquery.js#L5493
|
||||
'clean': function (elems, context, fragment, scripts) {
|
||||
for ( var i = 0, elem; (elem = elems[i]) != null; i++ ) {
|
||||
if ( typeof elem === "string" && rhtml.test( elem ) ) {
|
||||
elems[i] = elem = jQuery.htmlPrefilter(elem);
|
||||
}
|
||||
}
|
||||
return originalClean.call(this, elems, context, fragment, scripts);
|
||||
}
|
||||
});
|
||||
}
|
||||
else {
|
||||
var originalBuildFragment = jQuery.buildFragment;
|
||||
jQuery.extend({
|
||||
// @see https://github.com/jquery/jquery/blob/1.9.0/jquery.js#L6419
|
||||
'buildFragment': function (elems, context, scripts, selection) {
|
||||
var l = elems.length;
|
||||
for ( var i = 0; i < l; i++ ) {
|
||||
var elem = elems[i];
|
||||
if (elem || elem === 0) {
|
||||
if ( jQuery.type( elem ) !== "object" && rhtml.test( elem ) ) {
|
||||
elems[i] = elem = jQuery.htmlPrefilter(elem);
|
||||
}
|
||||
}
|
||||
}
|
||||
return originalBuildFragment.call(this, elems, context, scripts, selection);
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
})(jQuery);
|
||||
Vendored
-1
@@ -1,4 +1,3 @@
|
||||
|
||||
/*!
|
||||
* jQuery JavaScript Library v1.4.4
|
||||
* http://jquery.com/
|
||||
|
||||
+34
-12
@@ -580,21 +580,43 @@ Drupal.tableDrag.prototype.dropRow = function (event, self) {
|
||||
* Get the mouse coordinates from the event (allowing for browser differences).
|
||||
*/
|
||||
Drupal.tableDrag.prototype.mouseCoords = function (event) {
|
||||
// Complete support for pointer events was only introduced to jQuery in
|
||||
// version 1.11.1; between versions 1.7 and 1.11.0 pointer events have the
|
||||
// clientX and clientY properties undefined. In those cases, the properties
|
||||
// must be retrieved from the event.originalEvent object instead.
|
||||
var clientX = event.clientX || event.originalEvent.clientX;
|
||||
var clientY = event.clientY || event.originalEvent.clientY;
|
||||
|
||||
if (event.pageX || event.pageY) {
|
||||
return { x: event.pageX, y: event.pageY };
|
||||
// Match both null and undefined, but not zero, by using != null.
|
||||
// See https://stackoverflow.com/questions/2647867/how-to-determine-if-variable-is-undefined-or-null
|
||||
if (event.pageX != null && event.pageY != null) {
|
||||
return {x: event.pageX, y: event.pageY};
|
||||
}
|
||||
|
||||
return {
|
||||
x: clientX + document.body.scrollLeft - document.body.clientLeft,
|
||||
y: clientY + document.body.scrollTop - document.body.clientTop
|
||||
};
|
||||
// Complete support for pointer events was only introduced to jQuery in
|
||||
// version 1.11.1; between versions 1.7 and 1.11.0 pointer events have the
|
||||
// pageX and pageY properties undefined. In those cases, the properties must
|
||||
// be retrieved from the event.originalEvent object instead.
|
||||
if (event.originalEvent && event.originalEvent.pageX != null && event.originalEvent.pageY != null) {
|
||||
return {x: event.originalEvent.pageX, y: event.originalEvent.pageY};
|
||||
}
|
||||
|
||||
// Some old browsers do not support MouseEvent.pageX and *.pageY at all.
|
||||
// See https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/pageY
|
||||
// For those, we look at event.clientX and event.clientY instead.
|
||||
if (event.clientX == null || event.clientY == null) {
|
||||
// In some jQuery versions, some events created by jQuery do not have
|
||||
// clientX and clientY. But the original event might have.
|
||||
if (!event.originalEvent) {
|
||||
throw new Error("The event has no coordinates, and no event.originalEvent.");
|
||||
}
|
||||
event = event.originalEvent;
|
||||
if (event.clientX == null || event.clientY == null) {
|
||||
throw new Error("The original event has no coordinates.");
|
||||
}
|
||||
}
|
||||
|
||||
// Copied from jQuery.event.fix() in jQuery 1.4.1.
|
||||
// In newer jQuery versions, this code is in jQuery.event.mouseHooks.filter().
|
||||
var doc = document.documentElement, body = document.body;
|
||||
var pageX = event.clientX + ( doc && doc.scrollLeft || body && body.scrollLeft || 0 ) - ( doc && doc.clientLeft || body && body.clientLeft || 0 );
|
||||
var pageY = event.clientY + ( doc && doc.scrollTop || body && body.scrollTop || 0 ) - ( doc && doc.clientTop || body && body.clientTop || 0 );
|
||||
|
||||
return {x: pageX, y: pageY};
|
||||
};
|
||||
|
||||
/**
|
||||
|
||||
@@ -0,0 +1,79 @@
|
||||
<?php
|
||||
|
||||
namespace Drupal\Core\Security;
|
||||
|
||||
use TYPO3\PharStreamWrapper\Assertable;
|
||||
use TYPO3\PharStreamWrapper\Helper;
|
||||
use TYPO3\PharStreamWrapper\Exception;
|
||||
|
||||
/**
|
||||
* An alternate PharExtensionInterceptor to support phar-based CLI tools.
|
||||
*
|
||||
* @see \TYPO3\PharStreamWrapper\Interceptor\PharExtensionInterceptor
|
||||
*/
|
||||
class PharExtensionInterceptor implements Assertable {
|
||||
|
||||
/**
|
||||
* Determines whether phar file is allowed to execute.
|
||||
*
|
||||
* The phar file is allowed to execute if:
|
||||
* - the base file name has a ".phar" suffix.
|
||||
* - it is the CLI tool that has invoked the interceptor.
|
||||
*
|
||||
* @param string $path
|
||||
* The path of the phar file to check.
|
||||
* @param string $command
|
||||
* The command being carried out.
|
||||
*
|
||||
* @return bool
|
||||
* TRUE if the phar file is allowed to execute.
|
||||
*
|
||||
* @throws Exception
|
||||
* Thrown when the file is not allowed to execute.
|
||||
*/
|
||||
public function assert($path, $command) {
|
||||
if ($this->baseFileContainsPharExtension($path)) {
|
||||
return TRUE;
|
||||
}
|
||||
throw new Exception(
|
||||
sprintf(
|
||||
'Unexpected file extension in "%s"',
|
||||
$path
|
||||
),
|
||||
1535198703
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Determines if a path has a .phar extension or invoked execution.
|
||||
*
|
||||
* @param string $path
|
||||
* The path of the phar file to check.
|
||||
*
|
||||
* @return bool
|
||||
* TRUE if the file has a .phar extension or if the execution has been
|
||||
* invoked by the phar file.
|
||||
*/
|
||||
private function baseFileContainsPharExtension($path) {
|
||||
$baseFile = Helper::determineBaseFile($path);
|
||||
if ($baseFile === NULL) {
|
||||
return FALSE;
|
||||
}
|
||||
// If the stream wrapper is registered by invoking a phar file that does
|
||||
// not not have .phar extension then this should be allowed. For
|
||||
// example, some CLI tools recommend removing the extension.
|
||||
$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
|
||||
// Find the last entry in the backtrace containing a 'file' key as
|
||||
// sometimes the last caller is executed outside the scope of a file. For
|
||||
// example, this occurs with shutdown functions.
|
||||
do {
|
||||
$caller = array_pop($backtrace);
|
||||
} while (empty($caller['file']) && !empty($backtrace));
|
||||
if (isset($caller['file']) && $baseFile === Helper::determineBaseFile($caller['file'])) {
|
||||
return TRUE;
|
||||
}
|
||||
$fileExtension = pathinfo($baseFile, PATHINFO_EXTENSION);
|
||||
return strtolower($fileExtension) === 'phar';
|
||||
}
|
||||
|
||||
}
|
||||
@@ -0,0 +1,3 @@
|
||||
.idea
|
||||
vendor/
|
||||
composer.lock
|
||||
@@ -0,0 +1,21 @@
|
||||
MIT License
|
||||
|
||||
Copyright (c) 2018 TYPO3 project - https://typo3.org/
|
||||
|
||||
Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
of this software and associated documentation files (the "Software"), to deal
|
||||
in the Software without restriction, including without limitation the rights
|
||||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
copies of the Software, and to permit persons to whom the Software is
|
||||
furnished to do so, subject to the following conditions:
|
||||
|
||||
The above copyright notice and this permission notice shall be included in all
|
||||
copies or substantial portions of the Software.
|
||||
|
||||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
||||
SOFTWARE.
|
||||
@@ -0,0 +1,221 @@
|
||||
[](https://scrutinizer-ci.com/g/TYPO3/phar-stream-wrapper/?branch=v2)
|
||||
[](https://travis-ci.org/TYPO3/phar-stream-wrapper)
|
||||
[](https://ci.appveyor.com/project/ohader/phar-stream-wrapper)
|
||||
|
||||
# PHP Phar Stream Wrapper
|
||||
|
||||
## Abstract & History
|
||||
|
||||
Based on Sam Thomas' findings concerning
|
||||
[insecure deserialization in combination with obfuscation strategies](https://blog.secarma.co.uk/labs/near-phar-dangerous-unserialization-wherever-you-are)
|
||||
allowing to hide Phar files inside valid image resources, the TYPO3 project
|
||||
decided back then to introduce a `PharStreamWrapper` to intercept invocations
|
||||
of the `phar://` stream in PHP and only allow usage for defined locations in
|
||||
the file system.
|
||||
|
||||
Since the TYPO3 mission statement is **inspiring people to share**, we thought
|
||||
it would be helpful for others to release our `PharStreamWrapper` as standalone
|
||||
package to the PHP community.
|
||||
|
||||
The mentioned security issue was reported to TYPO3 on 10th June 2018 by Sam Thomas
|
||||
and has been addressed concerning the specific attack vector and for this generic
|
||||
`PharStreamWrapper` in TYPO3 versions 7.6.30 LTS, 8.7.17 LTS and 9.3.1 on 12th
|
||||
July 2018.
|
||||
|
||||
* https://blog.secarma.co.uk/labs/near-phar-dangerous-unserialization-wherever-you-are
|
||||
* https://youtu.be/GePBmsNJw6Y
|
||||
* https://typo3.org/security/advisory/typo3-psa-2018-001/
|
||||
* https://typo3.org/security/advisory/typo3-psa-2019-007/
|
||||
* https://typo3.org/security/advisory/typo3-psa-2019-008/
|
||||
|
||||
## License
|
||||
|
||||
In general the TYPO3 core is released under the GNU General Public License version
|
||||
2 or any later version (`GPL-2.0-or-later`). In order to avoid licensing issues and
|
||||
incompatibilities this `PharStreamWrapper` is licenced under the MIT License. In case
|
||||
you duplicate or modify source code, credits are not required but really appreciated.
|
||||
|
||||
## Credits
|
||||
|
||||
Thanks to [Alex Pott](https://github.com/alexpott), Drupal for creating
|
||||
back-ports of all sources in order to provide compatibility with PHP v5.3.
|
||||
|
||||
## Installation
|
||||
|
||||
The `PharStreamWrapper` is provided as composer package `typo3/phar-stream-wrapper`
|
||||
and has minimum requirements of PHP v5.3 ([`v2`](https://github.com/TYPO3/phar-stream-wrapper/tree/v2) branch) and PHP v7.0 ([`master`](https://github.com/TYPO3/phar-stream-wrapper) branch).
|
||||
|
||||
### Installation for PHP v7.0
|
||||
|
||||
```
|
||||
composer require typo3/phar-stream-wrapper ^3.0
|
||||
```
|
||||
|
||||
### Installation for PHP v5.3
|
||||
|
||||
```
|
||||
composer require typo3/phar-stream-wrapper ^2.0
|
||||
```
|
||||
|
||||
## Example
|
||||
|
||||
The following example is bundled within this package, the shown
|
||||
`PharExtensionInterceptor` denies all stream wrapper invocations files
|
||||
not having the `.phar` suffix. Interceptor logic has to be individual and
|
||||
adjusted to according requirements.
|
||||
|
||||
```
|
||||
$behavior = new \TYPO3\PharStreamWrapper\Behavior();
|
||||
\TYPO3\PharStreamWrapper\Manager::initialize(
|
||||
$behavior->withAssertion(new PharExtensionInterceptor())
|
||||
);
|
||||
|
||||
if (in_array('phar', stream_get_wrappers())) {
|
||||
stream_wrapper_unregister('phar');
|
||||
stream_wrapper_register('phar', 'TYPO3\\PharStreamWrapper\\PharStreamWrapper');
|
||||
}
|
||||
```
|
||||
|
||||
* `PharStreamWrapper` defined as class reference will be instantiated each time
|
||||
`phar://` streams shall be processed.
|
||||
* `Manager` as singleton pattern being called by `PharStreamWrapper` instances
|
||||
in order to retrieve individual behavior and settings.
|
||||
* `Behavior` holds reference to interceptor(s) that shall assert correct/allowed
|
||||
invocation of a given `$path` for a given `$command`. Interceptors implement
|
||||
the interface `Assertable`. Interceptors can act individually on following
|
||||
commands or handle all of them in case not defined specifically:
|
||||
+ `COMMAND_DIR_OPENDIR`
|
||||
+ `COMMAND_MKDIR`
|
||||
+ `COMMAND_RENAME`
|
||||
+ `COMMAND_RMDIR`
|
||||
+ `COMMAND_STEAM_METADATA`
|
||||
+ `COMMAND_STREAM_OPEN`
|
||||
+ `COMMAND_UNLINK`
|
||||
+ `COMMAND_URL_STAT`
|
||||
|
||||
## Interceptors
|
||||
|
||||
The following interceptor is shipped with the package and ready to use in order
|
||||
to block any Phar invocation of files not having a `.phar` suffix. Besides that
|
||||
individual interceptors are possible of course.
|
||||
|
||||
```
|
||||
class PharExtensionInterceptor implements Assertable
|
||||
{
|
||||
/**
|
||||
* Determines whether the base file name has a ".phar" suffix.
|
||||
*
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
* @throws Exception
|
||||
*/
|
||||
public function assert($path, $command)
|
||||
{
|
||||
if ($this->baseFileContainsPharExtension($path)) {
|
||||
return true;
|
||||
}
|
||||
throw new Exception(
|
||||
sprintf(
|
||||
'Unexpected file extension in "%s"',
|
||||
$path
|
||||
),
|
||||
1535198703
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return bool
|
||||
*/
|
||||
private function baseFileContainsPharExtension($path)
|
||||
{
|
||||
$baseFile = Helper::determineBaseFile($path);
|
||||
if ($baseFile === null) {
|
||||
return false;
|
||||
}
|
||||
$fileExtension = pathinfo($baseFile, PATHINFO_EXTENSION);
|
||||
return strtolower($fileExtension) === 'phar';
|
||||
}
|
||||
}
|
||||
```
|
||||
|
||||
### ConjunctionInterceptor
|
||||
|
||||
This interceptor combines multiple interceptors implementing `Assertable`.
|
||||
It succeeds when all nested interceptors succeed as well (logical `AND`).
|
||||
|
||||
```
|
||||
$behavior = new \TYPO3\PharStreamWrapper\Behavior();
|
||||
\TYPO3\PharStreamWrapper\Manager::initialize(
|
||||
$behavior->withAssertion(new ConjunctionInterceptor(array(
|
||||
new PharExtensionInterceptor(),
|
||||
new PharMetaDataInterceptor()
|
||||
)))
|
||||
);
|
||||
```
|
||||
|
||||
### PharExtensionInterceptor
|
||||
|
||||
This (basic) interceptor just checks whether the invoked Phar archive has
|
||||
an according `.phar` file extension. Resolving symbolic links as well as
|
||||
Phar internal alias resolving are considered as well.
|
||||
|
||||
```
|
||||
$behavior = new \TYPO3\PharStreamWrapper\Behavior();
|
||||
\TYPO3\PharStreamWrapper\Manager::initialize(
|
||||
$behavior->withAssertion(new PharExtensionInterceptor())
|
||||
);
|
||||
```
|
||||
|
||||
### PharMetaDataInterceptor
|
||||
|
||||
This interceptor is actually checking serialized Phar meta-data against
|
||||
PHP objects and would consider a Phar archive malicious in case not only
|
||||
scalar values are found. A custom low-level `Phar\Reader` is used in order to
|
||||
avoid using PHP's `Phar` object which would trigger the initial vulnerability.
|
||||
|
||||
```
|
||||
$behavior = new \TYPO3\PharStreamWrapper\Behavior();
|
||||
\TYPO3\PharStreamWrapper\Manager::initialize(
|
||||
$behavior->withAssertion(new PharMetaDataInterceptor())
|
||||
);
|
||||
```
|
||||
|
||||
## Reader
|
||||
|
||||
* `Phar\Reader::__construct(string $fileName)`: Creates low-level reader for Phar archive
|
||||
* `Phar\Reader::resolveContainer(): Phar\Container`: Resolves model representing Phar archive
|
||||
* `Phar\Container::getStub(): Phar\Stub`: Resolves (plain PHP) stub section of Phar archive
|
||||
* `Phar\Container::getManifest(): Phar\Manifest`: Resolves parsed Phar archive manifest as
|
||||
documented at http://php.net/manual/en/phar.fileformat.manifestfile.php
|
||||
* `Phar\Stub::getMappedAlias(): string`: Resolves internal Phar archive alias defined in stub
|
||||
using `Phar::mapPhar('alias.phar')` - actually the plain PHP source is analyzed here
|
||||
* `Phar\Manifest::getAlias(): string` - Resolves internal Phar archive alias defined in manifest
|
||||
using `Phar::setAlias('alias.phar')`
|
||||
* `Phar\Manifest::getMetaData(): string`: Resolves serialized Phar archive meta-data
|
||||
* `Phar\Manifest::deserializeMetaData(): mixed`: Resolves deserialized Phar archive meta-data
|
||||
containing only scalar values - in case an object is determined, an according
|
||||
`Phar\DeserializationException` will be thrown
|
||||
|
||||
```
|
||||
$reader = new Phar\Reader('example.phar');
|
||||
var_dump($reader->resolveContainer()->getManifest()->deserializeMetaData());
|
||||
```
|
||||
|
||||
## Helper
|
||||
|
||||
* `Helper::determineBaseFile(string $path): string`: Determines base file that can be
|
||||
accessed using the regular file system. For instance the following path
|
||||
`phar:///home/user/bundle.phar/content.txt` would be resolved to
|
||||
`/home/user/bundle.phar`.
|
||||
* `Helper::resetOpCache()`: Resets PHP's OPcache if enabled as work-around for
|
||||
issues in `include()` or `require()` calls and OPcache delivering wrong
|
||||
results. More details can be found in PHP's bug tracker, for instance like
|
||||
https://bugs.php.net/bug.php?id=66569
|
||||
|
||||
## Security Contact
|
||||
|
||||
In case of finding additional security issues in the TYPO3 project or in this
|
||||
`PharStreamWrapper` package in particular, please get in touch with the
|
||||
[TYPO3 Security Team](mailto:security@typo3.org).
|
||||
@@ -0,0 +1,30 @@
|
||||
{
|
||||
"name": "typo3/phar-stream-wrapper",
|
||||
"description": "Interceptors for PHP's native phar:// stream handling",
|
||||
"type": "library",
|
||||
"license": "MIT",
|
||||
"homepage": "https://typo3.org/",
|
||||
"keywords": ["php", "phar", "stream-wrapper", "security"],
|
||||
"require": {
|
||||
"php": "^5.3.3|^7.0",
|
||||
"ext-json": "*",
|
||||
"brumann/polyfill-unserialize": "^1.0"
|
||||
},
|
||||
"require-dev": {
|
||||
"ext-xdebug": "*",
|
||||
"phpunit/phpunit": "^4.8.36"
|
||||
},
|
||||
"suggest": {
|
||||
"ext-fileinfo": "For PHP builtin file type guessing, otherwise uses internal processing"
|
||||
},
|
||||
"autoload": {
|
||||
"psr-4": {
|
||||
"TYPO3\\PharStreamWrapper\\": "src/"
|
||||
}
|
||||
},
|
||||
"autoload-dev": {
|
||||
"psr-4": {
|
||||
"TYPO3\\PharStreamWrapper\\Tests\\": "tests/"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,22 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
interface Assertable
|
||||
{
|
||||
/**
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
*/
|
||||
public function assert($path, $command);
|
||||
}
|
||||
@@ -0,0 +1,124 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
class Behavior implements Assertable
|
||||
{
|
||||
const COMMAND_DIR_OPENDIR = 'dir_opendir';
|
||||
const COMMAND_MKDIR = 'mkdir';
|
||||
const COMMAND_RENAME = 'rename';
|
||||
const COMMAND_RMDIR = 'rmdir';
|
||||
const COMMAND_STEAM_METADATA = 'stream_metadata';
|
||||
const COMMAND_STREAM_OPEN = 'stream_open';
|
||||
const COMMAND_UNLINK = 'unlink';
|
||||
const COMMAND_URL_STAT = 'url_stat';
|
||||
|
||||
/**
|
||||
* @var string[]
|
||||
*/
|
||||
private $availableCommands = array(
|
||||
self::COMMAND_DIR_OPENDIR,
|
||||
self::COMMAND_MKDIR,
|
||||
self::COMMAND_RENAME,
|
||||
self::COMMAND_RMDIR,
|
||||
self::COMMAND_STEAM_METADATA,
|
||||
self::COMMAND_STREAM_OPEN,
|
||||
self::COMMAND_UNLINK,
|
||||
self::COMMAND_URL_STAT,
|
||||
);
|
||||
|
||||
/**
|
||||
* @var Assertable[]
|
||||
*/
|
||||
private $assertions;
|
||||
|
||||
/**
|
||||
* @param Assertable $assertable
|
||||
* @return static
|
||||
*/
|
||||
public function withAssertion(Assertable $assertable)
|
||||
{
|
||||
$commands = func_get_args();
|
||||
array_shift($commands);
|
||||
$this->assertCommands($commands);
|
||||
$commands = $commands ?: $this->availableCommands;
|
||||
|
||||
$target = clone $this;
|
||||
foreach ($commands as $command) {
|
||||
$target->assertions[$command] = $assertable;
|
||||
}
|
||||
return $target;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
*/
|
||||
public function assert($path, $command)
|
||||
{
|
||||
$this->assertCommand($command);
|
||||
$this->assertAssertionCompleteness();
|
||||
|
||||
return $this->assertions[$command]->assert($path, $command);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array $commands
|
||||
*/
|
||||
private function assertCommands(array $commands)
|
||||
{
|
||||
$unknownCommands = array_diff($commands, $this->availableCommands);
|
||||
if (empty($unknownCommands)) {
|
||||
return;
|
||||
}
|
||||
throw new \LogicException(
|
||||
sprintf(
|
||||
'Unknown commands: %s',
|
||||
implode(', ', $unknownCommands)
|
||||
),
|
||||
1535189881
|
||||
);
|
||||
}
|
||||
|
||||
private function assertCommand($command)
|
||||
{
|
||||
if (in_array($command, $this->availableCommands, true)) {
|
||||
return;
|
||||
}
|
||||
throw new \LogicException(
|
||||
sprintf(
|
||||
'Unknown command "%s"',
|
||||
$command
|
||||
),
|
||||
1535189882
|
||||
);
|
||||
}
|
||||
|
||||
private function assertAssertionCompleteness()
|
||||
{
|
||||
$undefinedAssertions = array_diff(
|
||||
$this->availableCommands,
|
||||
array_keys($this->assertions)
|
||||
);
|
||||
if (empty($undefinedAssertions)) {
|
||||
return;
|
||||
}
|
||||
throw new \LogicException(
|
||||
sprintf(
|
||||
'Missing assertions for commands: %s',
|
||||
implode(', ', $undefinedAssertions)
|
||||
),
|
||||
1535189883
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,37 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Resolver\PharInvocation;
|
||||
|
||||
interface Collectable
|
||||
{
|
||||
/**
|
||||
* @param PharInvocation $invocation
|
||||
* @return bool
|
||||
*/
|
||||
public function has(PharInvocation $invocation);
|
||||
|
||||
/**
|
||||
* @param PharInvocation $invocation
|
||||
* @param null $flags
|
||||
* @return bool
|
||||
*/
|
||||
public function collect(PharInvocation $invocation, $flags = null);
|
||||
|
||||
/**
|
||||
* @param callable $callback
|
||||
* @param bool $reverse
|
||||
* @return null|PharInvocation
|
||||
*/
|
||||
public function findByCallback($callback, $reverse = false);
|
||||
}
|
||||
@@ -0,0 +1,16 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
class Exception extends \RuntimeException
|
||||
{
|
||||
}
|
||||
@@ -0,0 +1,199 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
/**
|
||||
* Helper provides low-level tools on file name resolving. However it does not
|
||||
* (and should not) maintain any runtime state information. In order to resolve
|
||||
* Phar archive paths according resolvers have to be used.
|
||||
*
|
||||
* @see \TYPO3\PharStreamWrapper\Resolvable::resolve()
|
||||
*/
|
||||
class Helper
|
||||
{
|
||||
/*
|
||||
* Resets PHP's OPcache if enabled as work-around for issues in `include()`
|
||||
* or `require()` calls and OPcache delivering wrong results.
|
||||
*
|
||||
* @see https://bugs.php.net/bug.php?id=66569
|
||||
*/
|
||||
public static function resetOpCache()
|
||||
{
|
||||
if (function_exists('opcache_reset')
|
||||
&& function_exists('opcache_get_status')
|
||||
) {
|
||||
$status = opcache_get_status();
|
||||
if (!empty($status['opcache_enabled'])) {
|
||||
opcache_reset();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Determines base file that can be accessed using the regular file system.
|
||||
* For e.g. "phar:///home/user/bundle.phar/content.txt" that would result
|
||||
* into "/home/user/bundle.phar".
|
||||
*
|
||||
* @param string $path
|
||||
* @return string|null
|
||||
*/
|
||||
public static function determineBaseFile($path)
|
||||
{
|
||||
$parts = explode('/', static::normalizePath($path));
|
||||
|
||||
while (count($parts)) {
|
||||
$currentPath = implode('/', $parts);
|
||||
if (@is_file($currentPath) && realpath($currentPath) !== false) {
|
||||
return $currentPath;
|
||||
}
|
||||
array_pop($parts);
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return bool
|
||||
*/
|
||||
public static function hasPharPrefix($path)
|
||||
{
|
||||
return stripos($path, 'phar://') === 0;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return string
|
||||
*/
|
||||
public static function removePharPrefix($path)
|
||||
{
|
||||
$path = trim($path);
|
||||
if (!static::hasPharPrefix($path)) {
|
||||
return $path;
|
||||
}
|
||||
return substr($path, 7);
|
||||
}
|
||||
|
||||
/**
|
||||
* Normalizes a path, removes phar:// prefix, fixes Windows directory
|
||||
* separators. Result is without trailing slash.
|
||||
*
|
||||
* @param string $path
|
||||
* @return string
|
||||
*/
|
||||
public static function normalizePath($path)
|
||||
{
|
||||
return rtrim(
|
||||
static::normalizeWindowsPath(
|
||||
static::removePharPrefix($path)
|
||||
),
|
||||
'/'
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Fixes a path for windows-backslashes and reduces double-slashes to single slashes
|
||||
*
|
||||
* @param string $path File path to process
|
||||
* @return string
|
||||
*/
|
||||
public static function normalizeWindowsPath($path)
|
||||
{
|
||||
return str_replace('\\', '/', $path);
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolves all dots, slashes and removes spaces after or before a path...
|
||||
*
|
||||
* @param string $path Input string
|
||||
* @return string Canonical path, always without trailing slash
|
||||
*/
|
||||
private static function getCanonicalPath($path)
|
||||
{
|
||||
$path = static::normalizeWindowsPath($path);
|
||||
|
||||
$absolutePathPrefix = '';
|
||||
if (static::isAbsolutePath($path)) {
|
||||
if (static::isWindows() && strpos($path, ':/') === 1) {
|
||||
$absolutePathPrefix = substr($path, 0, 3);
|
||||
$path = substr($path, 3);
|
||||
} else {
|
||||
$path = ltrim($path, '/');
|
||||
$absolutePathPrefix = '/';
|
||||
}
|
||||
}
|
||||
|
||||
$pathParts = explode('/', $path);
|
||||
$pathPartsLength = count($pathParts);
|
||||
for ($partCount = 0; $partCount < $pathPartsLength; $partCount++) {
|
||||
// double-slashes in path: remove element
|
||||
if ($pathParts[$partCount] === '') {
|
||||
array_splice($pathParts, $partCount, 1);
|
||||
$partCount--;
|
||||
$pathPartsLength--;
|
||||
}
|
||||
// "." in path: remove element
|
||||
if ((isset($pathParts[$partCount]) ? $pathParts[$partCount] : '') === '.') {
|
||||
array_splice($pathParts, $partCount, 1);
|
||||
$partCount--;
|
||||
$pathPartsLength--;
|
||||
}
|
||||
// ".." in path:
|
||||
if ((isset($pathParts[$partCount]) ? $pathParts[$partCount] : '') === '..') {
|
||||
if ($partCount === 0) {
|
||||
array_splice($pathParts, $partCount, 1);
|
||||
$partCount--;
|
||||
$pathPartsLength--;
|
||||
} elseif ($partCount >= 1) {
|
||||
// Rremove this and previous element
|
||||
array_splice($pathParts, $partCount - 1, 2);
|
||||
$partCount -= 2;
|
||||
$pathPartsLength -= 2;
|
||||
} elseif ($absolutePathPrefix) {
|
||||
// can't go higher than root dir
|
||||
// simply remove this part and continue
|
||||
array_splice($pathParts, $partCount, 1);
|
||||
$partCount--;
|
||||
$pathPartsLength--;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return $absolutePathPrefix . implode('/', $pathParts);
|
||||
}
|
||||
|
||||
/**
|
||||
* Checks if the $path is absolute or relative (detecting either '/' or
|
||||
* 'x:/' as first part of string) and returns TRUE if so.
|
||||
*
|
||||
* @param string $path File path to evaluate
|
||||
* @return bool
|
||||
*/
|
||||
private static function isAbsolutePath($path)
|
||||
{
|
||||
// Path starting with a / is always absolute, on every system
|
||||
// On Windows also a path starting with a drive letter is absolute: X:/
|
||||
return (isset($path[0]) ? $path[0] : null) === '/'
|
||||
|| static::isWindows() && (
|
||||
strpos($path, ':/') === 1
|
||||
|| strpos($path, ':\\') === 1
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
private static function isWindows()
|
||||
{
|
||||
return stripos(PHP_OS, 'WIN') === 0;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,88 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Interceptor;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Assertable;
|
||||
use TYPO3\PharStreamWrapper\Exception;
|
||||
|
||||
class ConjunctionInterceptor implements Assertable
|
||||
{
|
||||
/**
|
||||
* @var Assertable[]
|
||||
*/
|
||||
private $assertions;
|
||||
|
||||
public function __construct(array $assertions)
|
||||
{
|
||||
$this->assertAssertions($assertions);
|
||||
$this->assertions = $assertions;
|
||||
}
|
||||
|
||||
/**
|
||||
* Executes assertions based on all contained assertions.
|
||||
*
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
* @throws Exception
|
||||
*/
|
||||
public function assert($path, $command)
|
||||
{
|
||||
if ($this->invokeAssertions($path, $command)) {
|
||||
return true;
|
||||
}
|
||||
throw new Exception(
|
||||
sprintf(
|
||||
'Assertion failed in "%s"',
|
||||
$path
|
||||
),
|
||||
1539625084
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param Assertable[] $assertions
|
||||
*/
|
||||
private function assertAssertions(array $assertions)
|
||||
{
|
||||
foreach ($assertions as $assertion) {
|
||||
if (!$assertion instanceof Assertable) {
|
||||
throw new \InvalidArgumentException(
|
||||
sprintf(
|
||||
'Instance %s must implement Assertable',
|
||||
get_class($assertion)
|
||||
),
|
||||
1539624719
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
*/
|
||||
private function invokeAssertions($path, $command)
|
||||
{
|
||||
try {
|
||||
foreach ($this->assertions as $assertion) {
|
||||
if (!$assertion->assert($path, $command)) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
} catch (Exception $exception) {
|
||||
return false;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,55 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Interceptor;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Assertable;
|
||||
use TYPO3\PharStreamWrapper\Exception;
|
||||
use TYPO3\PharStreamWrapper\Manager;
|
||||
|
||||
class PharExtensionInterceptor implements Assertable
|
||||
{
|
||||
/**
|
||||
* Determines whether the base file name has a ".phar" suffix.
|
||||
*
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
* @throws Exception
|
||||
*/
|
||||
public function assert($path, $command)
|
||||
{
|
||||
if ($this->baseFileContainsPharExtension($path)) {
|
||||
return true;
|
||||
}
|
||||
throw new Exception(
|
||||
sprintf(
|
||||
'Unexpected file extension in "%s"',
|
||||
$path
|
||||
),
|
||||
1535198703
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return bool
|
||||
*/
|
||||
private function baseFileContainsPharExtension($path)
|
||||
{
|
||||
$invocation = Manager::instance()->resolve($path);
|
||||
if ($invocation === null) {
|
||||
return false;
|
||||
}
|
||||
$fileExtension = pathinfo($invocation->getBaseName(), PATHINFO_EXTENSION);
|
||||
return strtolower($fileExtension) === 'phar';
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,73 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Interceptor;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Assertable;
|
||||
use TYPO3\PharStreamWrapper\Exception;
|
||||
use TYPO3\PharStreamWrapper\Manager;
|
||||
use TYPO3\PharStreamWrapper\Phar\DeserializationException;
|
||||
use TYPO3\PharStreamWrapper\Phar\Reader;
|
||||
|
||||
/**
|
||||
* @internal Experimental implementation of checking against serialized objects in Phar meta-data
|
||||
* @internal This functionality has not been 100% pentested...
|
||||
*/
|
||||
class PharMetaDataInterceptor implements Assertable
|
||||
{
|
||||
/**
|
||||
* Determines whether the according Phar archive contains
|
||||
* (potential insecure) serialized objects.
|
||||
*
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
* @throws Exception
|
||||
*/
|
||||
public function assert($path, $command)
|
||||
{
|
||||
if ($this->baseFileDoesNotHaveMetaDataIssues($path)) {
|
||||
return true;
|
||||
}
|
||||
throw new Exception(
|
||||
sprintf(
|
||||
'Problematic meta-data in "%s"',
|
||||
$path
|
||||
),
|
||||
1539632368
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return bool
|
||||
*/
|
||||
private function baseFileDoesNotHaveMetaDataIssues($path)
|
||||
{
|
||||
$invocation = Manager::instance()->resolve($path);
|
||||
if ($invocation === null) {
|
||||
return false;
|
||||
}
|
||||
// directly return in case invocation was checked before
|
||||
if ($invocation->getVariable(__CLASS__) === true) {
|
||||
return true;
|
||||
}
|
||||
// otherwise analyze meta-data
|
||||
try {
|
||||
$reader = new Reader($invocation->getBaseName());
|
||||
$reader->resolveContainer()->getManifest()->deserializeMetaData();
|
||||
$invocation->setVariable(__CLASS__, true);
|
||||
} catch (DeserializationException $exception) {
|
||||
return false;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,135 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Resolver\PharInvocation;
|
||||
use TYPO3\PharStreamWrapper\Resolver\PharInvocationCollection;
|
||||
use TYPO3\PharStreamWrapper\Resolver\PharInvocationResolver;
|
||||
|
||||
class Manager
|
||||
{
|
||||
/**
|
||||
* @var self
|
||||
*/
|
||||
private static $instance;
|
||||
|
||||
/**
|
||||
* @var Behavior
|
||||
*/
|
||||
private $behavior;
|
||||
|
||||
/**
|
||||
* @var Resolvable
|
||||
*/
|
||||
private $resolver;
|
||||
|
||||
/**
|
||||
* @var Collectable
|
||||
*/
|
||||
private $collection;
|
||||
|
||||
/**
|
||||
* @param Behavior $behaviour
|
||||
* @param Resolvable $resolver
|
||||
* @param Collectable $collection
|
||||
* @return self
|
||||
*/
|
||||
public static function initialize(
|
||||
Behavior $behaviour,
|
||||
Resolvable $resolver = null,
|
||||
Collectable $collection = null
|
||||
) {
|
||||
if (self::$instance === null) {
|
||||
self::$instance = new self($behaviour, $resolver, $collection);
|
||||
return self::$instance;
|
||||
}
|
||||
throw new \LogicException(
|
||||
'Manager can only be initialized once',
|
||||
1535189871
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return self
|
||||
*/
|
||||
public static function instance()
|
||||
{
|
||||
if (self::$instance !== null) {
|
||||
return self::$instance;
|
||||
}
|
||||
throw new \LogicException(
|
||||
'Manager needs to be initialized first',
|
||||
1535189872
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
public static function destroy()
|
||||
{
|
||||
if (self::$instance === null) {
|
||||
return false;
|
||||
}
|
||||
self::$instance = null;
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param Behavior $behaviour
|
||||
* @param Resolvable $resolver
|
||||
* @param Collectable $collection
|
||||
*/
|
||||
private function __construct(
|
||||
Behavior $behaviour,
|
||||
Resolvable $resolver = null,
|
||||
Collectable $collection = null
|
||||
) {
|
||||
if ($collection === null) {
|
||||
$collection = new PharInvocationCollection();
|
||||
}
|
||||
if ($resolver === null) {
|
||||
$resolver = new PharInvocationResolver();
|
||||
}
|
||||
$this->collection = $collection;
|
||||
$this->resolver = $resolver;
|
||||
$this->behavior = $behaviour;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
* @return bool
|
||||
*/
|
||||
public function assert($path, $command)
|
||||
{
|
||||
return $this->behavior->assert($path, $command);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param null|int $flags
|
||||
* @return null|PharInvocation
|
||||
*/
|
||||
public function resolve($path, $flags = null)
|
||||
{
|
||||
return $this->resolver->resolve($path, $flags);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Collectable
|
||||
*/
|
||||
public function getCollection()
|
||||
{
|
||||
return $this->collection;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,59 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Phar;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
class Container
|
||||
{
|
||||
/**
|
||||
* @var Stub
|
||||
*/
|
||||
private $stub;
|
||||
|
||||
/**
|
||||
* @var Manifest
|
||||
*/
|
||||
private $manifest;
|
||||
|
||||
/**
|
||||
* @param Stub $stub
|
||||
* @param Manifest $manifest
|
||||
*/
|
||||
public function __construct(Stub $stub, Manifest $manifest)
|
||||
{
|
||||
$this->stub = $stub;
|
||||
$this->manifest = $manifest;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Stub
|
||||
*/
|
||||
public function getStub()
|
||||
{
|
||||
return $this->stub;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Manifest
|
||||
*/
|
||||
public function getManifest()
|
||||
{
|
||||
return $this->manifest;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getAlias()
|
||||
{
|
||||
return $this->manifest->getAlias() ?: $this->stub->getMappedAlias();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,18 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Phar;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Exception;
|
||||
|
||||
class DeserializationException extends Exception
|
||||
{
|
||||
}
|
||||
@@ -0,0 +1,176 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Phar;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use Brumann\Polyfill\Unserialize;
|
||||
|
||||
class Manifest
|
||||
{
|
||||
/**
|
||||
* @param string $content
|
||||
* @return self
|
||||
* @see http://php.net/manual/en/phar.fileformat.phar.php
|
||||
*/
|
||||
public static function fromContent($content)
|
||||
{
|
||||
$target = new static();
|
||||
$target->manifestLength = Reader::resolveFourByteLittleEndian($content, 0);
|
||||
$target->amountOfFiles = Reader::resolveFourByteLittleEndian($content, 4);
|
||||
$target->flags = Reader::resolveFourByteLittleEndian($content, 10);
|
||||
$target->aliasLength = Reader::resolveFourByteLittleEndian($content, 14);
|
||||
$target->alias = substr($content, 18, $target->aliasLength);
|
||||
$target->metaDataLength = Reader::resolveFourByteLittleEndian($content, 18 + $target->aliasLength);
|
||||
$target->metaData = substr($content, 22 + $target->aliasLength, $target->metaDataLength);
|
||||
|
||||
$apiVersionNibbles = Reader::resolveTwoByteBigEndian($content, 8);
|
||||
$target->apiVersion = implode('.', array(
|
||||
($apiVersionNibbles & 0xf000) >> 12,
|
||||
($apiVersionNibbles & 0x0f00) >> 8,
|
||||
($apiVersionNibbles & 0x00f0) >> 4,
|
||||
));
|
||||
|
||||
return $target;
|
||||
}
|
||||
|
||||
/**
|
||||
* @var int
|
||||
*/
|
||||
private $manifestLength;
|
||||
|
||||
/**
|
||||
* @var int
|
||||
*/
|
||||
private $amountOfFiles;
|
||||
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $apiVersion;
|
||||
|
||||
/**
|
||||
* @var int
|
||||
*/
|
||||
private $flags;
|
||||
|
||||
/**
|
||||
* @var int
|
||||
*/
|
||||
private $aliasLength;
|
||||
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $alias;
|
||||
|
||||
/**
|
||||
* @var int
|
||||
*/
|
||||
private $metaDataLength;
|
||||
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $metaData;
|
||||
|
||||
/**
|
||||
* Avoid direct instantiation.
|
||||
*/
|
||||
private function __construct()
|
||||
{
|
||||
}
|
||||
|
||||
/**
|
||||
* @return int
|
||||
*/
|
||||
public function getManifestLength()
|
||||
{
|
||||
return $this->manifestLength;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return int
|
||||
*/
|
||||
public function getAmountOfFiles()
|
||||
{
|
||||
return $this->amountOfFiles;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getApiVersion()
|
||||
{
|
||||
return $this->apiVersion;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return int
|
||||
*/
|
||||
public function getFlags()
|
||||
{
|
||||
return $this->flags;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return int
|
||||
*/
|
||||
public function getAliasLength()
|
||||
{
|
||||
return $this->aliasLength;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getAlias()
|
||||
{
|
||||
return $this->alias;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return int
|
||||
*/
|
||||
public function getMetaDataLength()
|
||||
{
|
||||
return $this->metaDataLength;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getMetaData()
|
||||
{
|
||||
return $this->metaData;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return mixed|null
|
||||
*/
|
||||
public function deserializeMetaData()
|
||||
{
|
||||
if (empty($this->metaData)) {
|
||||
return null;
|
||||
}
|
||||
|
||||
$result = Unserialize::unserialize($this->metaData, array('allowed_classes' => false));
|
||||
|
||||
$serialized = json_encode($result);
|
||||
if (strpos($serialized, '__PHP_Incomplete_Class_Name') !== false) {
|
||||
throw new DeserializationException(
|
||||
'Meta-data contains serialized object',
|
||||
1539623382
|
||||
);
|
||||
}
|
||||
|
||||
return $result;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,254 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Phar;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
class Reader
|
||||
{
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $fileName;
|
||||
|
||||
/**
|
||||
* Mime-type in order to use zlib, bzip2 or no compression.
|
||||
* In case ext-fileinfo is not present only the relevant types
|
||||
* 'application/x-gzip' and 'application/x-bzip2' are assigned
|
||||
* to this class property.
|
||||
*
|
||||
* @var string
|
||||
*/
|
||||
private $fileType;
|
||||
|
||||
/**
|
||||
* @param string $fileName
|
||||
*/
|
||||
public function __construct($fileName)
|
||||
{
|
||||
if (strpos($fileName, '://') !== false) {
|
||||
throw new ReaderException(
|
||||
'File name must not contain stream prefix',
|
||||
1539623708
|
||||
);
|
||||
}
|
||||
|
||||
$this->fileName = $fileName;
|
||||
$this->fileType = $this->determineFileType();
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Container
|
||||
*/
|
||||
public function resolveContainer()
|
||||
{
|
||||
$data = $this->extractData($this->resolveStream() . $this->fileName);
|
||||
|
||||
if ($data['stubContent'] === null) {
|
||||
throw new ReaderException(
|
||||
'Cannot resolve stub',
|
||||
1547807881
|
||||
);
|
||||
}
|
||||
if ($data['manifestContent'] === null || $data['manifestLength'] === null) {
|
||||
throw new ReaderException(
|
||||
'Cannot resolve manifest',
|
||||
1547807882
|
||||
);
|
||||
}
|
||||
if (strlen($data['manifestContent']) < $data['manifestLength']) {
|
||||
throw new ReaderException(
|
||||
sprintf(
|
||||
'Exected manifest length %d, got %d',
|
||||
strlen($data['manifestContent']),
|
||||
$data['manifestLength']
|
||||
),
|
||||
1547807883
|
||||
);
|
||||
}
|
||||
|
||||
return new Container(
|
||||
Stub::fromContent($data['stubContent']),
|
||||
Manifest::fromContent($data['manifestContent'])
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $fileName e.g. '/path/file.phar' or 'compress.zlib:///path/file.phar'
|
||||
* @return array
|
||||
*/
|
||||
private function extractData($fileName)
|
||||
{
|
||||
$stubContent = null;
|
||||
$manifestContent = null;
|
||||
$manifestLength = null;
|
||||
|
||||
$resource = fopen($fileName, 'r');
|
||||
if (!is_resource($resource)) {
|
||||
throw new ReaderException(
|
||||
sprintf('Resource %s could not be opened', $fileName),
|
||||
1547902055
|
||||
);
|
||||
}
|
||||
|
||||
while (!feof($resource)) {
|
||||
$line = fgets($resource);
|
||||
// stop reading file when manifest can be extracted
|
||||
if ($manifestLength !== null && $manifestContent !== null && strlen($manifestContent) >= $manifestLength) {
|
||||
break;
|
||||
}
|
||||
|
||||
$manifestPosition = strpos($line, '__HALT_COMPILER();');
|
||||
|
||||
// first line contains start of manifest
|
||||
if ($stubContent === null && $manifestContent === null && $manifestPosition !== false) {
|
||||
$stubContent = substr($line, 0, $manifestPosition - 1);
|
||||
$manifestContent = preg_replace('#^.*__HALT_COMPILER\(\);(?>[ \n]\?>(?>\r\n|\n)?)?#', '', $line);
|
||||
$manifestLength = $this->resolveManifestLength($manifestContent);
|
||||
// line contains start of stub
|
||||
} elseif ($stubContent === null) {
|
||||
$stubContent = $line;
|
||||
// line contains start of manifest
|
||||
} elseif ($manifestContent === null && $manifestPosition !== false) {
|
||||
$manifestContent = preg_replace('#^.*__HALT_COMPILER\(\);(?>[ \n]\?>(?>\r\n|\n)?)?#', '', $line);
|
||||
$manifestLength = $this->resolveManifestLength($manifestContent);
|
||||
// manifest has been started (thus is cannot be stub anymore), add content
|
||||
} elseif ($manifestContent !== null) {
|
||||
$manifestContent .= $line;
|
||||
$manifestLength = $this->resolveManifestLength($manifestContent);
|
||||
// stub has been started (thus cannot be manifest here, yet), add content
|
||||
} elseif ($stubContent !== null) {
|
||||
$stubContent .= $line;
|
||||
}
|
||||
}
|
||||
fclose($resource);
|
||||
|
||||
return array(
|
||||
'stubContent' => $stubContent,
|
||||
'manifestContent' => $manifestContent,
|
||||
'manifestLength' => $manifestLength,
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolves stream in order to handle compressed Phar archives.
|
||||
*
|
||||
* @return string
|
||||
*/
|
||||
private function resolveStream()
|
||||
{
|
||||
if ($this->fileType === 'application/x-gzip' || $this->fileType === 'application/gzip') {
|
||||
return 'compress.zlib://';
|
||||
} elseif ($this->fileType === 'application/x-bzip2') {
|
||||
return 'compress.bzip2://';
|
||||
}
|
||||
return '';
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
private function determineFileType()
|
||||
{
|
||||
if (class_exists('\\finfo')) {
|
||||
$fileInfo = new \finfo();
|
||||
return $fileInfo->file($this->fileName, FILEINFO_MIME_TYPE);
|
||||
}
|
||||
return $this->determineFileTypeByHeader();
|
||||
}
|
||||
|
||||
/**
|
||||
* In case ext-fileinfo is not present only the relevant types
|
||||
* 'application/x-gzip' and 'application/x-bzip2' are resolved.
|
||||
*
|
||||
* @return string
|
||||
*/
|
||||
private function determineFileTypeByHeader()
|
||||
{
|
||||
$resource = fopen($this->fileName, 'r');
|
||||
if (!is_resource($resource)) {
|
||||
throw new ReaderException(
|
||||
sprintf('Resource %s could not be opened', $this->fileName),
|
||||
1557753055
|
||||
);
|
||||
}
|
||||
$header = fgets($resource, 4);
|
||||
fclose($resource);
|
||||
$mimeType = '';
|
||||
if (strpos($header, "\x42\x5a\x68") === 0) {
|
||||
$mimeType = 'application/x-bzip2';
|
||||
} elseif (strpos($header, "\x1f\x8b") === 0) {
|
||||
$mimeType = 'application/x-gzip';
|
||||
}
|
||||
return $mimeType;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $content
|
||||
* @return int|null
|
||||
*/
|
||||
private function resolveManifestLength($content)
|
||||
{
|
||||
if (strlen($content) < 4) {
|
||||
return null;
|
||||
}
|
||||
return static::resolveFourByteLittleEndian($content, 0);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $content
|
||||
* @param int $start
|
||||
* @return int
|
||||
*/
|
||||
public static function resolveFourByteLittleEndian($content, $start)
|
||||
{
|
||||
$payload = substr($content, $start, 4);
|
||||
if (!is_string($payload)) {
|
||||
throw new ReaderException(
|
||||
sprintf('Cannot resolve value at offset %d', $start),
|
||||
1539614260
|
||||
);
|
||||
}
|
||||
|
||||
$value = unpack('V', $payload);
|
||||
if (!isset($value[1])) {
|
||||
throw new ReaderException(
|
||||
sprintf('Cannot resolve value at offset %d', $start),
|
||||
1539614261
|
||||
);
|
||||
}
|
||||
return $value[1];
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $content
|
||||
* @param int $start
|
||||
* @return int
|
||||
*/
|
||||
public static function resolveTwoByteBigEndian($content, $start)
|
||||
{
|
||||
$payload = substr($content, $start, 2);
|
||||
if (!is_string($payload)) {
|
||||
throw new ReaderException(
|
||||
sprintf('Cannot resolve value at offset %d', $start),
|
||||
1539614263
|
||||
);
|
||||
}
|
||||
|
||||
$value = unpack('n', $payload);
|
||||
if (!isset($value[1])) {
|
||||
throw new ReaderException(
|
||||
sprintf('Cannot resolve value at offset %d', $start),
|
||||
1539614264
|
||||
);
|
||||
}
|
||||
return $value[1];
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,18 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Phar;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Exception;
|
||||
|
||||
class ReaderException extends Exception
|
||||
{
|
||||
}
|
||||
@@ -0,0 +1,65 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Phar;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
/**
|
||||
* @internal Experimental implementation of Phar archive internals
|
||||
*/
|
||||
class Stub
|
||||
{
|
||||
/**
|
||||
* @param string $content
|
||||
* @return self
|
||||
*/
|
||||
public static function fromContent($content)
|
||||
{
|
||||
$target = new static();
|
||||
$target->content = $content;
|
||||
|
||||
if (
|
||||
stripos($content, 'Phar::mapPhar(') !== false
|
||||
&& preg_match('#Phar\:\:mapPhar\(([^)]+)\)#', $content, $matches)
|
||||
) {
|
||||
// remove spaces, single & double quotes
|
||||
// @todo `'my' . 'alias' . '.phar'` is not evaluated here
|
||||
$target->mappedAlias = trim($matches[1], ' \'"');
|
||||
}
|
||||
|
||||
return $target;
|
||||
}
|
||||
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $content;
|
||||
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $mappedAlias = '';
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getContent()
|
||||
{
|
||||
return $this->content;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getMappedAlias()
|
||||
{
|
||||
return $this->mappedAlias;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,511 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Resolver\PharInvocation;
|
||||
|
||||
class PharStreamWrapper
|
||||
{
|
||||
/**
|
||||
* Internal stream constants that are not exposed to PHP, but used...
|
||||
* @see https://github.com/php/php-src/blob/e17fc0d73c611ad0207cac8a4a01ded38251a7dc/main/php_streams.h
|
||||
*/
|
||||
const STREAM_OPEN_FOR_INCLUDE = 128;
|
||||
|
||||
/**
|
||||
* @var resource
|
||||
*/
|
||||
public $context;
|
||||
|
||||
/**
|
||||
* @var resource
|
||||
*/
|
||||
protected $internalResource;
|
||||
|
||||
/**
|
||||
* @var PharInvocation
|
||||
*/
|
||||
protected $invocation;
|
||||
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
public function dir_closedir()
|
||||
{
|
||||
if (!is_resource($this->internalResource)) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$this->invokeInternalStreamWrapper(
|
||||
'closedir',
|
||||
$this->internalResource
|
||||
);
|
||||
return !is_resource($this->internalResource);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param int $options
|
||||
* @return bool
|
||||
*/
|
||||
public function dir_opendir($path, $options)
|
||||
{
|
||||
$this->assert($path, Behavior::COMMAND_DIR_OPENDIR);
|
||||
$this->internalResource = $this->invokeInternalStreamWrapper(
|
||||
'opendir',
|
||||
$path,
|
||||
$this->context
|
||||
);
|
||||
return is_resource($this->internalResource);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string|false
|
||||
*/
|
||||
public function dir_readdir()
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'readdir',
|
||||
$this->internalResource
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
public function dir_rewinddir()
|
||||
{
|
||||
if (!is_resource($this->internalResource)) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$this->invokeInternalStreamWrapper(
|
||||
'rewinddir',
|
||||
$this->internalResource
|
||||
);
|
||||
return is_resource($this->internalResource);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param int $mode
|
||||
* @param int $options
|
||||
* @return bool
|
||||
*/
|
||||
public function mkdir($path, $mode, $options)
|
||||
{
|
||||
$this->assert($path, Behavior::COMMAND_MKDIR);
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'mkdir',
|
||||
$path,
|
||||
$mode,
|
||||
(bool) ($options & STREAM_MKDIR_RECURSIVE),
|
||||
$this->context
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path_from
|
||||
* @param string $path_to
|
||||
* @return bool
|
||||
*/
|
||||
public function rename($path_from, $path_to)
|
||||
{
|
||||
$this->assert($path_from, Behavior::COMMAND_RENAME);
|
||||
$this->assert($path_to, Behavior::COMMAND_RENAME);
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'rename',
|
||||
$path_from,
|
||||
$path_to,
|
||||
$this->context
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param int $options
|
||||
* @return bool
|
||||
*/
|
||||
public function rmdir($path, $options)
|
||||
{
|
||||
$this->assert($path, Behavior::COMMAND_RMDIR);
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'rmdir',
|
||||
$path,
|
||||
$this->context
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $cast_as
|
||||
*/
|
||||
public function stream_cast($cast_as)
|
||||
{
|
||||
throw new Exception(
|
||||
'Method stream_select() cannot be used',
|
||||
1530103999
|
||||
);
|
||||
}
|
||||
|
||||
public function stream_close()
|
||||
{
|
||||
$this->invokeInternalStreamWrapper(
|
||||
'fclose',
|
||||
$this->internalResource
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_eof()
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'feof',
|
||||
$this->internalResource
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_flush()
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'fflush',
|
||||
$this->internalResource
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $operation
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_lock($operation)
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'flock',
|
||||
$this->internalResource,
|
||||
$operation
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param int $option
|
||||
* @param string|int $value
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_metadata($path, $option, $value)
|
||||
{
|
||||
$this->assert($path, Behavior::COMMAND_STEAM_METADATA);
|
||||
if ($option === STREAM_META_TOUCH) {
|
||||
return call_user_func_array(
|
||||
array($this, 'invokeInternalStreamWrapper'),
|
||||
array_merge(array('touch', $path), (array) $value)
|
||||
);
|
||||
}
|
||||
if ($option === STREAM_META_OWNER_NAME || $option === STREAM_META_OWNER) {
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'chown',
|
||||
$path,
|
||||
$value
|
||||
);
|
||||
}
|
||||
if ($option === STREAM_META_GROUP_NAME || $option === STREAM_META_GROUP) {
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'chgrp',
|
||||
$path,
|
||||
$value
|
||||
);
|
||||
}
|
||||
if ($option === STREAM_META_ACCESS) {
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'chmod',
|
||||
$path,
|
||||
$value
|
||||
);
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param string $mode
|
||||
* @param int $options
|
||||
* @param string|null $opened_path
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_open(
|
||||
$path,
|
||||
$mode,
|
||||
$options,
|
||||
&$opened_path = null
|
||||
) {
|
||||
$this->assert($path, Behavior::COMMAND_STREAM_OPEN);
|
||||
$arguments = array($path, $mode, (bool) ($options & STREAM_USE_PATH));
|
||||
// only add stream context for non include/require calls
|
||||
if (!($options & static::STREAM_OPEN_FOR_INCLUDE)) {
|
||||
$arguments[] = $this->context;
|
||||
// work around https://bugs.php.net/bug.php?id=66569
|
||||
// for including files from Phar stream with OPcache enabled
|
||||
} else {
|
||||
Helper::resetOpCache();
|
||||
}
|
||||
$this->internalResource = call_user_func_array(
|
||||
array($this, 'invokeInternalStreamWrapper'),
|
||||
array_merge(array('fopen'), $arguments)
|
||||
);
|
||||
if (!is_resource($this->internalResource)) {
|
||||
return false;
|
||||
}
|
||||
if ($opened_path !== null) {
|
||||
$metaData = stream_get_meta_data($this->internalResource);
|
||||
$opened_path = $metaData['uri'];
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $count
|
||||
* @return string
|
||||
*/
|
||||
public function stream_read($count)
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'fread',
|
||||
$this->internalResource,
|
||||
$count
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $offset
|
||||
* @param int $whence
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_seek($offset, $whence = SEEK_SET)
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'fseek',
|
||||
$this->internalResource,
|
||||
$offset,
|
||||
$whence
|
||||
) !== -1;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $option
|
||||
* @param int $arg1
|
||||
* @param int $arg2
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_set_option($option, $arg1, $arg2)
|
||||
{
|
||||
if ($option === STREAM_OPTION_BLOCKING) {
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'stream_set_blocking',
|
||||
$this->internalResource,
|
||||
$arg1
|
||||
);
|
||||
}
|
||||
if ($option === STREAM_OPTION_READ_TIMEOUT) {
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'stream_set_timeout',
|
||||
$this->internalResource,
|
||||
$arg1,
|
||||
$arg2
|
||||
);
|
||||
}
|
||||
if ($option === STREAM_OPTION_WRITE_BUFFER) {
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'stream_set_write_buffer',
|
||||
$this->internalResource,
|
||||
$arg2
|
||||
) === 0;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array
|
||||
*/
|
||||
public function stream_stat()
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'fstat',
|
||||
$this->internalResource
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return int
|
||||
*/
|
||||
public function stream_tell()
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'ftell',
|
||||
$this->internalResource
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param int $new_size
|
||||
* @return bool
|
||||
*/
|
||||
public function stream_truncate($new_size)
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'ftruncate',
|
||||
$this->internalResource,
|
||||
$new_size
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $data
|
||||
* @return int
|
||||
*/
|
||||
public function stream_write($data)
|
||||
{
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'fwrite',
|
||||
$this->internalResource,
|
||||
$data
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return bool
|
||||
*/
|
||||
public function unlink($path)
|
||||
{
|
||||
$this->assert($path, Behavior::COMMAND_UNLINK);
|
||||
return $this->invokeInternalStreamWrapper(
|
||||
'unlink',
|
||||
$path,
|
||||
$this->context
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param int $flags
|
||||
* @return array|false
|
||||
*/
|
||||
public function url_stat($path, $flags)
|
||||
{
|
||||
$this->assert($path, Behavior::COMMAND_URL_STAT);
|
||||
$functionName = $flags & STREAM_URL_STAT_QUIET ? '@stat' : 'stat';
|
||||
return $this->invokeInternalStreamWrapper($functionName, $path);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param string $command
|
||||
*/
|
||||
protected function assert($path, $command)
|
||||
{
|
||||
if (Manager::instance()->assert($path, $command) === true) {
|
||||
$this->collectInvocation($path);
|
||||
return;
|
||||
}
|
||||
|
||||
throw new Exception(
|
||||
sprintf(
|
||||
'Denied invocation of "%s" for command "%s"',
|
||||
$path,
|
||||
$command
|
||||
),
|
||||
1535189880
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
*/
|
||||
protected function collectInvocation($path)
|
||||
{
|
||||
if (isset($this->invocation)) {
|
||||
return;
|
||||
}
|
||||
|
||||
$manager = Manager::instance();
|
||||
$this->invocation = $manager->resolve($path);
|
||||
if ($this->invocation === null) {
|
||||
throw new Exception(
|
||||
'Expected invocation could not be resolved',
|
||||
1556389591
|
||||
);
|
||||
}
|
||||
// confirm, previous interceptor(s) validated invocation
|
||||
$this->invocation->confirm();
|
||||
$collection = $manager->getCollection();
|
||||
if (!$collection->has($this->invocation)) {
|
||||
$collection->collect($this->invocation);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Manager|Assertable
|
||||
* @deprecated Use Manager::instance() directly
|
||||
*/
|
||||
protected function resolveAssertable()
|
||||
{
|
||||
return Manager::instance();
|
||||
}
|
||||
|
||||
/**
|
||||
* Invokes commands on the native PHP Phar stream wrapper.
|
||||
*
|
||||
* @param string $functionName
|
||||
* @param mixed ...$arguments
|
||||
* @return mixed
|
||||
*/
|
||||
private function invokeInternalStreamWrapper($functionName)
|
||||
{
|
||||
$arguments = func_get_args();
|
||||
array_shift($arguments);
|
||||
$silentExecution = $functionName[0] === '@';
|
||||
$functionName = ltrim($functionName, '@');
|
||||
$this->restoreInternalSteamWrapper();
|
||||
|
||||
try {
|
||||
if ($silentExecution) {
|
||||
$result = @call_user_func_array($functionName, $arguments);
|
||||
} else {
|
||||
$result = call_user_func_array($functionName, $arguments);
|
||||
}
|
||||
} catch (\Exception $exception) {
|
||||
$this->registerStreamWrapper();
|
||||
throw $exception;
|
||||
} catch (\Throwable $throwable) {
|
||||
$this->registerStreamWrapper();
|
||||
throw $throwable;
|
||||
}
|
||||
|
||||
$this->registerStreamWrapper();
|
||||
return $result;
|
||||
}
|
||||
|
||||
private function restoreInternalSteamWrapper()
|
||||
{
|
||||
stream_wrapper_restore('phar');
|
||||
}
|
||||
|
||||
private function registerStreamWrapper()
|
||||
{
|
||||
stream_wrapper_unregister('phar');
|
||||
stream_wrapper_register('phar', get_class($this));
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,24 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Resolver\PharInvocation;
|
||||
|
||||
interface Resolvable
|
||||
{
|
||||
/**
|
||||
* @param string $path
|
||||
* @param null|int $flags
|
||||
* @return null|PharInvocation
|
||||
*/
|
||||
public function resolve($path, $flags = null);
|
||||
}
|
||||
@@ -0,0 +1,125 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Resolver;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Exception;
|
||||
|
||||
class PharInvocation
|
||||
{
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $baseName;
|
||||
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
private $alias;
|
||||
|
||||
/**
|
||||
* @var bool
|
||||
* @see \TYPO3\PharStreamWrapper\PharStreamWrapper::collectInvocation()
|
||||
*/
|
||||
private $confirmed = false;
|
||||
|
||||
/**
|
||||
* Arbitrary variables to be used by interceptors as registry
|
||||
* (e.g. in order to avoid duplicate processing and assertions)
|
||||
*
|
||||
* @var array
|
||||
*/
|
||||
private $variables;
|
||||
|
||||
/**
|
||||
* @param string $baseName
|
||||
* @param string $alias
|
||||
*/
|
||||
public function __construct($baseName, $alias = '')
|
||||
{
|
||||
if ($baseName === '') {
|
||||
throw new Exception(
|
||||
'Base-name cannot be empty',
|
||||
1551283689
|
||||
);
|
||||
}
|
||||
$this->baseName = $baseName;
|
||||
$this->alias = $alias;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function __toString()
|
||||
{
|
||||
return $this->baseName;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getBaseName()
|
||||
{
|
||||
return $this->baseName;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return null|string
|
||||
*/
|
||||
public function getAlias()
|
||||
{
|
||||
return $this->alias;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
public function isConfirmed()
|
||||
{
|
||||
return $this->confirmed;
|
||||
}
|
||||
|
||||
public function confirm()
|
||||
{
|
||||
$this->confirmed = true;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $name
|
||||
* @return mixed|null
|
||||
*/
|
||||
public function getVariable($name)
|
||||
{
|
||||
if (!isset($this->variables[$name])) {
|
||||
return null;
|
||||
}
|
||||
return $this->variables[$name];
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $name
|
||||
* @param mixed $value
|
||||
*/
|
||||
public function setVariable($name, $value)
|
||||
{
|
||||
$this->variables[$name] = $value;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param PharInvocation $other
|
||||
* @return bool
|
||||
*/
|
||||
public function equals(PharInvocation $other)
|
||||
{
|
||||
return $other->baseName === $this->baseName
|
||||
&& $other->alias === $this->alias;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,156 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Resolver;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Collectable;
|
||||
|
||||
class PharInvocationCollection implements Collectable
|
||||
{
|
||||
const UNIQUE_INVOCATION = 1;
|
||||
const UNIQUE_BASE_NAME = 2;
|
||||
const DUPLICATE_ALIAS_WARNING = 32;
|
||||
|
||||
/**
|
||||
* @var PharInvocation[]
|
||||
*/
|
||||
private $invocations = array();
|
||||
|
||||
/**
|
||||
* @param PharInvocation $invocation
|
||||
* @return bool
|
||||
*/
|
||||
public function has(PharInvocation $invocation)
|
||||
{
|
||||
return in_array($invocation, $this->invocations, true);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param PharInvocation $invocation
|
||||
* @param null|int $flags
|
||||
* @return bool
|
||||
*/
|
||||
public function collect(PharInvocation $invocation, $flags = null)
|
||||
{
|
||||
if ($flags === null) {
|
||||
$flags = static::UNIQUE_INVOCATION | static::DUPLICATE_ALIAS_WARNING;
|
||||
}
|
||||
if ($invocation->getBaseName() === ''
|
||||
|| $invocation->getAlias() === ''
|
||||
|| !$this->assertUniqueBaseName($invocation, $flags)
|
||||
|| !$this->assertUniqueInvocation($invocation, $flags)
|
||||
) {
|
||||
return false;
|
||||
}
|
||||
if ($flags & static::DUPLICATE_ALIAS_WARNING) {
|
||||
$this->triggerDuplicateAliasWarning($invocation);
|
||||
}
|
||||
|
||||
$this->invocations[] = $invocation;
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param callable $callback
|
||||
* @param bool $reverse
|
||||
* @return null|PharInvocation
|
||||
*/
|
||||
public function findByCallback($callback, $reverse = false)
|
||||
{
|
||||
foreach ($this->getInvocations($reverse) as $invocation) {
|
||||
if (call_user_func($callback, $invocation) === true) {
|
||||
return $invocation;
|
||||
}
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
* Asserts that base-name is unique. This disallows having multiple invocations for
|
||||
* same base-name but having different alias names.
|
||||
*
|
||||
* @param PharInvocation $invocation
|
||||
* @param int $flags
|
||||
* @return bool
|
||||
*/
|
||||
private function assertUniqueBaseName(PharInvocation $invocation, $flags)
|
||||
{
|
||||
if (!($flags & static::UNIQUE_BASE_NAME)) {
|
||||
return true;
|
||||
}
|
||||
return $this->findByCallback(
|
||||
function (PharInvocation $candidate) use ($invocation) {
|
||||
return $candidate->getBaseName() === $invocation->getBaseName();
|
||||
}
|
||||
) === null;
|
||||
}
|
||||
|
||||
/**
|
||||
* Asserts that combination of base-name and alias is unique. This allows having multiple
|
||||
* invocations for same base-name but having different alias names (for whatever reason).
|
||||
*
|
||||
* @param PharInvocation $invocation
|
||||
* @param int $flags
|
||||
* @return bool
|
||||
*/
|
||||
private function assertUniqueInvocation(PharInvocation $invocation, $flags)
|
||||
{
|
||||
if (!($flags & static::UNIQUE_INVOCATION)) {
|
||||
return true;
|
||||
}
|
||||
return $this->findByCallback(
|
||||
function (PharInvocation $candidate) use ($invocation) {
|
||||
return $candidate->equals($invocation);
|
||||
}
|
||||
) === null;
|
||||
}
|
||||
|
||||
/**
|
||||
* Triggers warning for invocations with same alias and same confirmation state.
|
||||
*
|
||||
* @param PharInvocation $invocation
|
||||
* @see \TYPO3\PharStreamWrapper\PharStreamWrapper::collectInvocation()
|
||||
*/
|
||||
private function triggerDuplicateAliasWarning(PharInvocation $invocation)
|
||||
{
|
||||
$sameAliasInvocation = $this->findByCallback(
|
||||
function (PharInvocation $candidate) use ($invocation) {
|
||||
return $candidate->isConfirmed() === $invocation->isConfirmed()
|
||||
&& $candidate->getAlias() === $invocation->getAlias();
|
||||
},
|
||||
true
|
||||
);
|
||||
if ($sameAliasInvocation === null) {
|
||||
return;
|
||||
}
|
||||
trigger_error(
|
||||
sprintf(
|
||||
'Alias %s cannot be used by %s, already used by %s',
|
||||
$invocation->getAlias(),
|
||||
$invocation->getBaseName(),
|
||||
$sameAliasInvocation->getBaseName()
|
||||
),
|
||||
E_USER_WARNING
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param bool $reverse
|
||||
* @return PharInvocation[]
|
||||
*/
|
||||
private function getInvocations($reverse = false)
|
||||
{
|
||||
if ($reverse) {
|
||||
return array_reverse($this->invocations);
|
||||
}
|
||||
return $this->invocations;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,249 @@
|
||||
<?php
|
||||
namespace TYPO3\PharStreamWrapper\Resolver;
|
||||
|
||||
/*
|
||||
* This file is part of the TYPO3 project.
|
||||
*
|
||||
* It is free software; you can redistribute it and/or modify it under the terms
|
||||
* of the MIT License (MIT). For the full copyright and license information,
|
||||
* please read the LICENSE file that was distributed with this source code.
|
||||
*
|
||||
* The TYPO3 project - inspiring people to share!
|
||||
*/
|
||||
|
||||
use TYPO3\PharStreamWrapper\Helper;
|
||||
use TYPO3\PharStreamWrapper\Manager;
|
||||
use TYPO3\PharStreamWrapper\Phar\Reader;
|
||||
use TYPO3\PharStreamWrapper\Phar\ReaderException;
|
||||
use TYPO3\PharStreamWrapper\Resolvable;
|
||||
|
||||
class PharInvocationResolver implements Resolvable
|
||||
{
|
||||
const RESOLVE_REALPATH = 1;
|
||||
const RESOLVE_ALIAS = 2;
|
||||
const ASSERT_INTERNAL_INVOCATION = 32;
|
||||
|
||||
/**
|
||||
* @var string[]
|
||||
*/
|
||||
private $invocationFunctionNames = array(
|
||||
'include',
|
||||
'include_once',
|
||||
'require',
|
||||
'require_once'
|
||||
);
|
||||
|
||||
/**
|
||||
* Contains resolved base names in order to reduce file IO.
|
||||
*
|
||||
* @var string[]
|
||||
*/
|
||||
private $baseNames = array();
|
||||
|
||||
/**
|
||||
* Resolves PharInvocation value object (baseName and optional alias).
|
||||
*
|
||||
* Phar aliases are intended to be used only inside Phar archives, however
|
||||
* PharStreamWrapper needs this information exposed outside of Phar as well
|
||||
* It is possible that same alias is used for different $baseName values.
|
||||
* That's why PharInvocationCollection behaves like a stack when resolving
|
||||
* base-name for a given alias. On the other hand it is not possible that
|
||||
* one $baseName is referring to multiple aliases.
|
||||
* @see https://secure.php.net/manual/en/phar.setalias.php
|
||||
* @see https://secure.php.net/manual/en/phar.mapphar.php
|
||||
*
|
||||
* @param string $path
|
||||
* @param int|null $flags
|
||||
* @return null|PharInvocation
|
||||
*/
|
||||
public function resolve($path, $flags = null)
|
||||
{
|
||||
$hasPharPrefix = Helper::hasPharPrefix($path);
|
||||
if ($flags === null) {
|
||||
$flags = static::RESOLVE_REALPATH | static::RESOLVE_ALIAS;
|
||||
}
|
||||
|
||||
if ($hasPharPrefix && $flags & static::RESOLVE_ALIAS) {
|
||||
$invocation = $this->findByAlias($path);
|
||||
if ($invocation !== null) {
|
||||
return $invocation;
|
||||
}
|
||||
}
|
||||
|
||||
$baseName = $this->resolveBaseName($path, $flags);
|
||||
if ($baseName === null) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if ($flags & static::RESOLVE_REALPATH) {
|
||||
$baseName = $this->baseNames[$baseName];
|
||||
}
|
||||
|
||||
return $this->retrieveInvocation($baseName, $flags);
|
||||
}
|
||||
|
||||
/**
|
||||
* Retrieves PharInvocation, either existing in collection or created on demand
|
||||
* with resolving a potential alias name used in the according Phar archive.
|
||||
*
|
||||
* @param string $baseName
|
||||
* @param int $flags
|
||||
* @return PharInvocation
|
||||
*/
|
||||
private function retrieveInvocation($baseName, $flags)
|
||||
{
|
||||
$invocation = $this->findByBaseName($baseName);
|
||||
if ($invocation !== null) {
|
||||
return $invocation;
|
||||
}
|
||||
|
||||
if ($flags & static::RESOLVE_ALIAS) {
|
||||
$reader = new Reader($baseName);
|
||||
$alias = $reader->resolveContainer()->getAlias();
|
||||
} else {
|
||||
$alias = '';
|
||||
}
|
||||
// add unconfirmed(!) new invocation to collection
|
||||
$invocation = new PharInvocation($baseName, $alias);
|
||||
Manager::instance()->getCollection()->collect($invocation);
|
||||
return $invocation;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @param int $flags
|
||||
* @return null|string
|
||||
*/
|
||||
private function resolveBaseName($path, $flags)
|
||||
{
|
||||
$baseName = $this->findInBaseNames($path);
|
||||
if ($baseName !== null) {
|
||||
return $baseName;
|
||||
}
|
||||
|
||||
$baseName = Helper::determineBaseFile($path);
|
||||
if ($baseName !== null) {
|
||||
$this->addBaseName($baseName);
|
||||
return $baseName;
|
||||
}
|
||||
|
||||
$possibleAlias = $this->resolvePossibleAlias($path);
|
||||
if (!($flags & static::RESOLVE_ALIAS) || $possibleAlias === null) {
|
||||
return null;
|
||||
}
|
||||
|
||||
$trace = debug_backtrace();
|
||||
foreach ($trace as $item) {
|
||||
if (!isset($item['function']) || !isset($item['args'][0])
|
||||
|| !in_array($item['function'], $this->invocationFunctionNames, true)) {
|
||||
continue;
|
||||
}
|
||||
$currentPath = $item['args'][0];
|
||||
if (Helper::hasPharPrefix($currentPath)) {
|
||||
continue;
|
||||
}
|
||||
$currentBaseName = Helper::determineBaseFile($currentPath);
|
||||
if ($currentBaseName === null) {
|
||||
continue;
|
||||
}
|
||||
// ensure the possible alias name (how we have been called initially) matches
|
||||
// the resolved alias name that was retrieved by the current possible base name
|
||||
try {
|
||||
$reader = new Reader($currentBaseName);
|
||||
$currentAlias = $reader->resolveContainer()->getAlias();
|
||||
} catch (ReaderException $exception) {
|
||||
// most probably that was not a Phar file
|
||||
continue;
|
||||
}
|
||||
if (empty($currentAlias) || $currentAlias !== $possibleAlias) {
|
||||
continue;
|
||||
}
|
||||
$this->addBaseName($currentBaseName);
|
||||
return $currentBaseName;
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return null|string
|
||||
*/
|
||||
private function resolvePossibleAlias($path)
|
||||
{
|
||||
$normalizedPath = Helper::normalizePath($path);
|
||||
return strstr($normalizedPath, '/', true) ?: null;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $baseName
|
||||
* @return null|PharInvocation
|
||||
*/
|
||||
private function findByBaseName($baseName)
|
||||
{
|
||||
return Manager::instance()->getCollection()->findByCallback(
|
||||
function (PharInvocation $candidate) use ($baseName) {
|
||||
return $candidate->getBaseName() === $baseName;
|
||||
},
|
||||
true
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $path
|
||||
* @return null|string
|
||||
*/
|
||||
private function findInBaseNames($path)
|
||||
{
|
||||
// return directly if the resolved base name was submitted
|
||||
if (in_array($path, $this->baseNames, true)) {
|
||||
return $path;
|
||||
}
|
||||
|
||||
$parts = explode('/', Helper::normalizePath($path));
|
||||
|
||||
while (count($parts)) {
|
||||
$currentPath = implode('/', $parts);
|
||||
if (isset($this->baseNames[$currentPath])) {
|
||||
return $currentPath;
|
||||
}
|
||||
array_pop($parts);
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param string $baseName
|
||||
*/
|
||||
private function addBaseName($baseName)
|
||||
{
|
||||
if (isset($this->baseNames[$baseName])) {
|
||||
return;
|
||||
}
|
||||
$this->baseNames[$baseName] = Helper::normalizeWindowsPath(
|
||||
realpath($baseName)
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Finds confirmed(!) invocations by alias.
|
||||
*
|
||||
* @param string $path
|
||||
* @return null|PharInvocation
|
||||
* @see \TYPO3\PharStreamWrapper\PharStreamWrapper::collectInvocation()
|
||||
*/
|
||||
private function findByAlias($path)
|
||||
{
|
||||
$possibleAlias = $this->resolvePossibleAlias($path);
|
||||
if ($possibleAlias === null) {
|
||||
return null;
|
||||
}
|
||||
return Manager::instance()->getCollection()->findByCallback(
|
||||
function (PharInvocation $candidate) use ($possibleAlias) {
|
||||
return $candidate->isConfirmed() && $candidate->getAlias() === $possibleAlias;
|
||||
},
|
||||
true
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -7,8 +7,7 @@ files[] = aggregator.test
|
||||
configure = admin/config/services/aggregator/settings
|
||||
stylesheets[all][] = aggregator.css
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -5,8 +5,7 @@ version = VERSION
|
||||
core = 7.x
|
||||
hidden = TRUE
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -6,8 +6,7 @@ core = 7.x
|
||||
files[] = block.test
|
||||
configure = admin/structure/block
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -263,7 +263,7 @@ function block_page_build(&$page) {
|
||||
$all_regions = system_region_list($theme);
|
||||
|
||||
$item = menu_get_item();
|
||||
if ($item['path'] != 'admin/structure/block/demo/' . $theme) {
|
||||
if ($item === FALSE || $item['path'] != 'admin/structure/block/demo/' . $theme) {
|
||||
// Load all region content assigned via blocks.
|
||||
foreach (array_keys($all_regions) as $region) {
|
||||
// Assign blocks to region.
|
||||
@@ -283,7 +283,6 @@ function block_page_build(&$page) {
|
||||
}
|
||||
else {
|
||||
// Append region description if we are rendering the regions demo page.
|
||||
$item = menu_get_item();
|
||||
if ($item['path'] == 'admin/structure/block/demo/' . $theme) {
|
||||
foreach (system_region_list($theme, REGIONS_VISIBLE, FALSE) as $region) {
|
||||
$description = '<div class="block-region">' . $all_regions[$region] . '</div>';
|
||||
|
||||
@@ -5,8 +5,7 @@ version = VERSION
|
||||
core = 7.x
|
||||
hidden = TRUE
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -13,8 +13,7 @@ regions[footer] = Footer
|
||||
regions[highlighted] = Highlighted
|
||||
regions[help] = Help
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -5,8 +5,7 @@ version = VERSION
|
||||
core = 7.x
|
||||
files[] = blog.test
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -7,8 +7,7 @@ files[] = book.test
|
||||
configure = admin/content/book/settings
|
||||
stylesheets[all][] = book.css
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -768,11 +768,13 @@ function book_prev($book_link) {
|
||||
return NULL;
|
||||
}
|
||||
$flat = book_get_flat_menu($book_link);
|
||||
// Assigning the array to $flat resets the array pointer for use with each().
|
||||
reset($flat);
|
||||
$curr = NULL;
|
||||
do {
|
||||
$prev = $curr;
|
||||
list($key, $curr) = each($flat);
|
||||
$curr = current($flat);
|
||||
$key = key($flat);
|
||||
next($flat);
|
||||
} while ($key && $key != $book_link['mlid']);
|
||||
|
||||
if ($key == $book_link['mlid']) {
|
||||
@@ -806,9 +808,10 @@ function book_prev($book_link) {
|
||||
*/
|
||||
function book_next($book_link) {
|
||||
$flat = book_get_flat_menu($book_link);
|
||||
// Assigning the array to $flat resets the array pointer for use with each().
|
||||
reset($flat);
|
||||
do {
|
||||
list($key, $curr) = each($flat);
|
||||
$key = key($flat);
|
||||
next($flat);
|
||||
}
|
||||
while ($key && $key != $book_link['mlid']);
|
||||
|
||||
|
||||
@@ -101,7 +101,7 @@ class BookTestCase extends DrupalWebTestCase {
|
||||
|
||||
// Check that book pages display along with the correct outlines and
|
||||
// previous/next links.
|
||||
$this->checkBookNode($book, array($nodes[0], $nodes[3], $nodes[4]), FALSE, FALSE, $nodes[0], array());
|
||||
$this->checkBookNode($book, array($nodes[0], $nodes[3], $nodes[4]), FALSE, FALSE, $nodes[0]);
|
||||
$this->checkBookNode($nodes[0], array($nodes[1], $nodes[2]), $book, $book, $nodes[1], array($book));
|
||||
$this->checkBookNode($nodes[1], NULL, $nodes[0], $nodes[0], $nodes[2], array($book, $nodes[0]));
|
||||
$this->checkBookNode($nodes[2], NULL, $nodes[1], $nodes[0], $nodes[3], array($book, $nodes[0]));
|
||||
@@ -124,7 +124,7 @@ class BookTestCase extends DrupalWebTestCase {
|
||||
// First we must set $this->book to the second book, so that the
|
||||
// correct regex will be generated for testing the outline.
|
||||
$this->book = $other_book;
|
||||
$this->checkBookNode($other_book, array($node), FALSE, FALSE, $node, array());
|
||||
$this->checkBookNode($other_book, array($node), FALSE, FALSE, $node);
|
||||
$this->checkBookNode($node, NULL, $other_book, $other_book, FALSE, array($other_book));
|
||||
}
|
||||
|
||||
@@ -144,9 +144,9 @@ class BookTestCase extends DrupalWebTestCase {
|
||||
* @param $next
|
||||
* (optional) Next link node. Defaults to FALSE.
|
||||
* @param $breadcrumb
|
||||
* The nodes that should be displayed in the breadcrumb.
|
||||
* (optional) The nodes that should be displayed in the breadcrumb.
|
||||
*/
|
||||
function checkBookNode($node, $nodes, $previous = FALSE, $up = FALSE, $next = FALSE, array $breadcrumb) {
|
||||
function checkBookNode($node, $nodes = NULL, $previous = FALSE, $up = FALSE, $next = FALSE, array $breadcrumb = array()) {
|
||||
// $number does not use drupal_static as it should not be reset
|
||||
// since it uniquely identifies each call to checkBookNode().
|
||||
static $number = 0;
|
||||
|
||||
@@ -5,8 +5,7 @@ version = VERSION
|
||||
core = 7.x
|
||||
files[] = color.test
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -734,8 +734,9 @@ function _color_blend($img, $hex1, $hex2, $alpha) {
|
||||
* Converts a hex color into an RGB triplet.
|
||||
*/
|
||||
function _color_unpack($hex, $normalize = FALSE) {
|
||||
if (strlen($hex) == 4) {
|
||||
$hex = $hex[1] . $hex[1] . $hex[2] . $hex[2] . $hex[3] . $hex[3];
|
||||
$hex = substr($hex, 1);
|
||||
if (strlen($hex) == 3) {
|
||||
$hex = $hex[0] . $hex[0] . $hex[1] . $hex[1] . $hex[2] . $hex[2];
|
||||
}
|
||||
$c = hexdec($hex);
|
||||
for ($i = 16; $i >= 0; $i -= 8) {
|
||||
|
||||
@@ -9,8 +9,7 @@ files[] = comment.test
|
||||
configure = admin/content/comment
|
||||
stylesheets[all][] = comment.css
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -9,9 +9,6 @@
|
||||
* Implements hook_uninstall().
|
||||
*/
|
||||
function comment_uninstall() {
|
||||
// Delete comment_body field.
|
||||
field_delete_field('comment_body');
|
||||
|
||||
// Remove variables.
|
||||
variable_del('comment_block_count');
|
||||
$node_types = array_keys(node_type_get_types());
|
||||
|
||||
@@ -6,6 +6,7 @@
|
||||
*/
|
||||
|
||||
class CommentHelperCase extends DrupalWebTestCase {
|
||||
protected $super_user;
|
||||
protected $admin_user;
|
||||
protected $web_user;
|
||||
protected $node;
|
||||
@@ -19,6 +20,7 @@ class CommentHelperCase extends DrupalWebTestCase {
|
||||
parent::setUp($modules);
|
||||
|
||||
// Create users and test node.
|
||||
$this->super_user = $this->drupalCreateUser(array('access administration pages', 'administer modules'));
|
||||
$this->admin_user = $this->drupalCreateUser(array('administer content types', 'administer comments', 'administer blocks', 'administer actions', 'administer fields'));
|
||||
$this->web_user = $this->drupalCreateUser(array('access comments', 'post comments', 'create article content', 'edit own comments'));
|
||||
$this->node = $this->drupalCreateNode(array('type' => 'article', 'promote' => 1, 'uid' => $this->web_user->uid));
|
||||
@@ -2264,3 +2266,56 @@ class CommentNodeChangesTestCase extends CommentHelperCase {
|
||||
$this->assertFalse(comment_load($comment->id), 'The comment could not be loaded after the node was deleted.');
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests uninstalling the comment module.
|
||||
*/
|
||||
class CommentUninstallTestCase extends CommentHelperCase {
|
||||
|
||||
public static function getInfo() {
|
||||
return array(
|
||||
'name' => 'Comment module uninstallation',
|
||||
'description' => 'Tests that the comments module can be properly uninstalled.',
|
||||
'group' => 'Comment',
|
||||
);
|
||||
}
|
||||
|
||||
function testCommentUninstall() {
|
||||
$this->drupalLogin($this->super_user);
|
||||
|
||||
// Disable comment module.
|
||||
$edit['modules[Core][comment][enable]'] = FALSE;
|
||||
$this->drupalPost('admin/modules', $edit, t('Save configuration'));
|
||||
$this->assertText(t('The configuration options have been saved.'), 'Comment module was disabled.');
|
||||
|
||||
// Uninstall comment module.
|
||||
$edit = array('uninstall[comment]' => 'comment');
|
||||
$this->drupalPost('admin/modules/uninstall', $edit, t('Uninstall'));
|
||||
$this->drupalPost(NULL, NULL, t('Uninstall'));
|
||||
$this->assertText(t('The selected modules have been uninstalled.'), 'Comment module was uninstalled.');
|
||||
|
||||
// Run cron and clear field cache so that comment fields and instances
|
||||
// marked for deletion are actually removed.
|
||||
$this->cronRun();
|
||||
field_cache_clear();
|
||||
|
||||
// Verify that comment fields have been removed.
|
||||
$all_fields = array_keys(field_info_field_map());
|
||||
$this->assertFalse(in_array('comment_body', $all_fields), 'Comment fields were removed by uninstall.');
|
||||
|
||||
// Verify that comment field instances have been removed (or at least marked
|
||||
// for deletion).
|
||||
// N.B. field_read_instances does an INNER JOIN on field_config so if the
|
||||
// comment_body row has been removed successfully from there no instances
|
||||
// will be returned, but that does not guarantee that no rows are left over
|
||||
// in the field_config_instance table.
|
||||
$count = db_select('field_config_instance', 'fci')
|
||||
->condition('entity_type', 'comment')
|
||||
->condition('field_name', 'comment_body')
|
||||
->condition('deleted', 0)
|
||||
->countQuery()
|
||||
->execute()
|
||||
->fetchField();
|
||||
$this->assertTrue($count == 0, 'Comment field instances were removed by uninstall.');
|
||||
}
|
||||
}
|
||||
|
||||
@@ -6,8 +6,7 @@ core = 7.x
|
||||
files[] = contact.test
|
||||
configure = admin/structure/contact
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -5,8 +5,7 @@ version = VERSION
|
||||
core = 7.x
|
||||
files[] = contextual.test
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -7,8 +7,7 @@ files[] = dashboard.test
|
||||
dependencies[] = block
|
||||
configure = admin/dashboard/customize
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -5,8 +5,7 @@ version = VERSION
|
||||
core = 7.x
|
||||
files[] = dblog.test
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -11,8 +11,7 @@ dependencies[] = field_sql_storage
|
||||
required = TRUE
|
||||
stylesheets[all][] = theme/field.css
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -7,8 +7,7 @@ dependencies[] = field
|
||||
files[] = field_sql_storage.test
|
||||
required = TRUE
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -434,6 +434,81 @@ function field_sql_storage_field_storage_load($entity_type, $entities, $age, $fi
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Callback for array_filter().
|
||||
*/
|
||||
function _field_sql_storage_write_compare_filter_callback($value) {
|
||||
return NULL !== $value && '' !== $value;
|
||||
}
|
||||
|
||||
/**
|
||||
* Cleanup field values for later values comparison.
|
||||
*
|
||||
* @param array $field
|
||||
* Field info as returned by field_info_field_by_id().
|
||||
*
|
||||
* @param array $array
|
||||
* Field values to cleanup.
|
||||
*
|
||||
* @return array
|
||||
* Filtered values.
|
||||
*/
|
||||
function _field_sql_storage_write_compare_filter($field, $array) {
|
||||
foreach ($array as $language => $items) {
|
||||
if (empty($items)) {
|
||||
unset($array[$language]);
|
||||
}
|
||||
else {
|
||||
foreach ($items as $delta => $item) {
|
||||
// This should not happen but some modules provide invalid data to the
|
||||
// field API.
|
||||
if (!is_array($item)) {
|
||||
continue;
|
||||
}
|
||||
// Let's start by pruning empty values and non storable values.
|
||||
$array[$language][$delta] = array_filter(array_intersect_key($item, $field['columns']), '_field_sql_storage_write_compare_filter_callback');
|
||||
// Ordering is important because for widget elements and loaded columns
|
||||
// from database order might differ and give false positives on field
|
||||
// value change, especially with complex fields such as image fields.
|
||||
ksort($array[$language][$delta]);
|
||||
}
|
||||
}
|
||||
}
|
||||
return $array;
|
||||
}
|
||||
|
||||
/**
|
||||
* Compare a single field value for both entities and tell us if it changed.
|
||||
*
|
||||
* @param array $field
|
||||
* Loaded field structure.
|
||||
* @param object $entity1
|
||||
* First entity to compare.
|
||||
* @param object $entity2
|
||||
* Second entity to compare.
|
||||
*
|
||||
* @return bool
|
||||
* True if field value changed, false otherwise.
|
||||
*/
|
||||
function _field_sql_storage_write_compare($field, $entity1, $entity2) {
|
||||
$field_name = $field['field_name'];
|
||||
if (empty($entity1->$field_name) && empty($entity2->$field_name)) {
|
||||
// Both are empty we can safely assume that it did not change.
|
||||
return FALSE;
|
||||
}
|
||||
if (!isset($entity1->$field_name) || !isset($entity2->$field_name)) {
|
||||
// One of them is missing but not the other the value changed.
|
||||
return TRUE;
|
||||
}
|
||||
// We need to proceed to deep array comparison, but we cannot do it naively:
|
||||
// in most cases the field values come from the edit form, and some Form API
|
||||
// widget values that are not field columns may be present. We need to clean
|
||||
// up both original and new field values before comparison.
|
||||
$items1 = _field_sql_storage_write_compare_filter($field, (array) $entity1->$field_name);
|
||||
$items2 = _field_sql_storage_write_compare_filter($field, (array) $entity2->$field_name);
|
||||
return $items1 != $items2;
|
||||
}
|
||||
|
||||
/**
|
||||
* Implements hook_field_storage_write().
|
||||
*/
|
||||
@@ -443,8 +518,29 @@ function field_sql_storage_field_storage_write($entity_type, $entity, $op, $fiel
|
||||
$vid = $id;
|
||||
}
|
||||
|
||||
// Check if the given entity is a new revision or not. In case of a new
|
||||
// revision creation, we cannot skip any field.
|
||||
if (!empty($vid) && !empty($entity->original)) {
|
||||
list(, $original_vid) = entity_extract_ids($entity_type, $entity->original);
|
||||
if (NULL === $original_vid) {
|
||||
$original_vid = $id;
|
||||
}
|
||||
$is_new_revision = $original_vid != $vid;
|
||||
}
|
||||
else {
|
||||
$is_new_revision = FALSE;
|
||||
}
|
||||
|
||||
// Allow this optimization to be optional.
|
||||
$skip_unchanged_fields = variable_get('field_sql_storage_skip_writing_unchanged_fields', FALSE);
|
||||
|
||||
foreach ($fields as $field_id) {
|
||||
$field = field_info_field_by_id($field_id);
|
||||
|
||||
if ($skip_unchanged_fields && !$is_new_revision && !empty($entity->original) && !_field_sql_storage_write_compare($field, $entity, $entity->original)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
$field_name = $field['field_name'];
|
||||
$table_name = _field_sql_storage_tablename($field);
|
||||
$revision_name = _field_sql_storage_revision_tablename($field);
|
||||
|
||||
@@ -281,6 +281,69 @@ class FieldSqlStorageTestCase extends DrupalWebTestCase {
|
||||
$this->assertEqual($count, 1, 'NULL field translation is wiped.');
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests the expected return values of _field_sql_storage_write_compare().
|
||||
*/
|
||||
public function testFieldCompareDataModification() {
|
||||
$langcode = LANGUAGE_NONE;
|
||||
$field_info = field_info_field($this->field_name);
|
||||
|
||||
// Make sure we have 2 sample field values that are unique.
|
||||
$value1 = 0;
|
||||
$value2 = 0;
|
||||
while ($value1 == $value2) {
|
||||
$value1 = mt_rand();
|
||||
$value2 = (string) mt_rand();
|
||||
}
|
||||
|
||||
// Create the 2 entities to compare.
|
||||
$entity = field_test_create_stub_entity();
|
||||
$entity->{$this->field_name}[$langcode][]['value'] = $value1;
|
||||
$entity1 = clone $entity;
|
||||
$entity2 = clone $entity;
|
||||
|
||||
// Make sure that it correctly compares identical entities.
|
||||
$this->assert(!_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'The entities are identical.');
|
||||
|
||||
// Compare to an empty object.
|
||||
$this->assert(_field_sql_storage_write_compare($field_info, $entity1, new stdClass()), 'The entity is not the same as an empty object.');
|
||||
|
||||
// Change one of the values.
|
||||
$entity2->{$this->field_name}[$langcode][0]['value'] = $value2;
|
||||
$this->assert(_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'The values are not the same.');
|
||||
|
||||
// Reset $entity2.
|
||||
$entity2 = clone $entity;
|
||||
|
||||
// Duplicate the value on one of the entities.
|
||||
$entity1->{$this->field_name}[$langcode][]['value'] = $value1;
|
||||
$this->assert(_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'The fields do not have the same number of values.');
|
||||
|
||||
// Add a second value to both entities.
|
||||
$entity2->{$this->field_name}[$langcode][]['value'] = $value2;
|
||||
$this->assert(_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'The values are not the same.');
|
||||
|
||||
// Replace the array containing the value with the actual value.
|
||||
$entity2->{$this->field_name}[$langcode] = $entity2->{$this->field_name}[$langcode][0];
|
||||
$this->assert(_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'The array to hold field values is replaced by the value.');
|
||||
|
||||
// Null one value.
|
||||
$entity2->{$this->field_name}[$langcode] = NULL;
|
||||
$this->assert(_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'One field is NULL and the other is not.');
|
||||
|
||||
// Null both values.
|
||||
$entity1->{$this->field_name}[$langcode] = NULL;
|
||||
$this->assert(!_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'Both fields are NULL.');
|
||||
|
||||
// Unset one of the fields.
|
||||
unset($entity2->{$this->field_name});
|
||||
$this->assert(_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'One field structure is unset.');
|
||||
|
||||
// Unset both of the fields.
|
||||
unset($entity1->{$this->field_name});
|
||||
$this->assert(!_field_sql_storage_write_compare($field_info, $entity1, $entity2), 'Both field structures are unset.');
|
||||
}
|
||||
|
||||
/**
|
||||
* Test trying to update a field with data.
|
||||
*/
|
||||
@@ -313,9 +376,13 @@ class FieldSqlStorageTestCase extends DrupalWebTestCase {
|
||||
$field = array('field_name' => 'test_text', 'type' => 'text', 'settings' => array('max_length' => 255));
|
||||
$field = field_create_field($field);
|
||||
|
||||
// Attempt to update the field in a way that would break the storage.
|
||||
// Attempt to update the field in a way that would break the storage. The
|
||||
// parenthesis suffix is needed because SQLite has *very* relaxed rules for
|
||||
// data types, so we actually need to provide an invalid SQL syntax in order
|
||||
// to break it.
|
||||
// @see https://www.sqlite.org/datatype3.html
|
||||
$prior_field = $field;
|
||||
$field['settings']['max_length'] = -1;
|
||||
$field['settings']['max_length'] = '-1)';
|
||||
try {
|
||||
field_update_field($field);
|
||||
$this->fail(t('Update succeeded.'));
|
||||
|
||||
@@ -7,8 +7,7 @@ dependencies[] = field
|
||||
dependencies[] = options
|
||||
files[] = tests/list.test
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -61,7 +61,7 @@ function list_update_7001() {
|
||||
|
||||
// Additionally, float keys need to be disambiguated ('.5' is '0.5').
|
||||
if ($field['type'] == 'list_number' && !empty($allowed_values)) {
|
||||
$keys = array_map(create_function('$a', 'return (string) (float) $a;'), array_keys($allowed_values));
|
||||
$keys = array_map('_list_update_7001_float_string_cast', array_keys($allowed_values));
|
||||
$allowed_values = array_combine($keys, array_values($allowed_values));
|
||||
}
|
||||
|
||||
@@ -88,6 +88,13 @@ function list_update_7001() {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Helper callback function to cast the array element.
|
||||
*/
|
||||
function _list_update_7001_float_string_cast($element) {
|
||||
return (string) (float) $element;
|
||||
}
|
||||
|
||||
/**
|
||||
* Helper function for list_update_7001: extract allowed values from a string.
|
||||
*
|
||||
|
||||
@@ -5,8 +5,7 @@ package = Testing
|
||||
version = VERSION
|
||||
hidden = TRUE
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -6,8 +6,7 @@ core = 7.x
|
||||
dependencies[] = field
|
||||
files[] = number.test
|
||||
|
||||
; Information added by Drupal.org packaging script on 2018-03-28
|
||||
version = "7.58"
|
||||
; Information added by Drupal.org packaging script on 2021-04-21
|
||||
version = "7.80"
|
||||
project = "drupal"
|
||||
datestamp = "1522264019"
|
||||
|
||||
datestamp = "1619021862"
|
||||
|
||||
@@ -69,7 +69,7 @@ class NumberFieldTestCase extends DrupalWebTestCase {
|
||||
preg_match('|test-entity/manage/(\d+)/edit|', $this->url, $match);
|
||||
$id = $match[1];
|
||||
$this->assertRaw(t('test_entity @id has been created.', array('@id' => $id)), 'Entity was created');
|
||||
$this->assertRaw(round($value, 2), 'Value is displayed.');
|
||||
$this->assertRaw($value, 'Value is displayed.');
|
||||
|
||||
// Try to create entries with more than one decimal separator; assert fail.
|
||||
$wrong_entries = array(
|
||||
@@ -174,7 +174,7 @@ class NumberFieldTestCase extends DrupalWebTestCase {
|
||||
),
|
||||
'display' => array(
|
||||
'default' => array(
|
||||
'type' => 'number_float',
|
||||
'type' => 'number_decimal',
|
||||
),
|
||||
),
|
||||
);
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user