Bachir Soussi Chiadmi 31cfa90501 updated core to 7.63 | 5 yıl önce | |
---|---|---|
.. | ||
src | 5 yıl önce | |
LICENSE | 5 yıl önce | |
README.md | 5 yıl önce | |
composer.json | 5 yıl önce |
Based on Sam Thomas' findings concerning
insecure deserialization in combination with obfuscation strategies
allowing to hide Phar files inside valid image resources, the TYPO3 project
decided back then to introduce a PharStreamWrapper
to intercept invocations
of the phar://
stream in PHP and only allow usage for defined locations in
the file system.
Since the TYPO3 mission statement is inspiring people to share, we thought
it would be helpful for others to release our PharStreamWrapper
as standalone
package to the PHP community.
The mentioned security issue was reported to TYPO3 on 10th June 2018 by Sam Thomas
and has been addressed concerning the specific attack vector and for this generic
PharStreamWrapper
in TYPO3 versions 7.6.30 LTS, 8.7.17 LTS and 9.3.1 on 12th
July 2018.
In general the TYPO3 core is released under the GNU General Public License version
2 or any later version (GPL-2.0-or-later
). In order to avoid licensing issues and
incompatibilities this PharStreamWrapper
is licenced under the MIT License. In case
you duplicate or modify source code, credits are not required but really appreciated.
Thanks to Alex Pott, Drupal for creating back-ports of all sources in order to provide compatibility with PHP v5.3.
The PharStreamWrapper
is provided as composer package typo3/phar-stream-wrapper
and has minimum requirements of PHP v5.3 (v2
branch) and PHP v7.0 (master
branch).
composer require typo3/phar-stream-wrapper ^3.0
composer require typo3/phar-stream-wrapper ^2.0
The following example is bundled within this package, the shown
PharExtensionInterceptor
denies all stream wrapper invocations files
not having the .phar
suffix. Interceptor logic has to be individual and
adjusted to according requirements.
$behavior = new \TYPO3\PharStreamWrapper\Behavior();
Manager::initialize(
$behavior->withAssertion(new PharExtensionInterceptor())
);
if (in_array('phar', stream_get_wrappers())) {
stream_wrapper_unregister('phar');
stream_wrapper_register('phar', 'TYPO3\\PharStreamWrapper\\PharStreamWrapper');
}
PharStreamWrapper
defined as class reference will be instantiated each time
phar://
streams shall be processed.Manager
as singleton pattern being called by PharStreamWrapper
instances
in order to retrieve individual behavior and settings.Behavior
holds reference to interceptor(s) that shall assert correct/allowed
invocation of a given $path
for a given $command
. Interceptors implement
the interface Assertable
. Interceptors can act individually on following
commands or handle all of them in case not defined specifically:COMMAND_DIR_OPENDIR
COMMAND_MKDIR
COMMAND_RENAME
COMMAND_RMDIR
COMMAND_STEAM_METADATA
COMMAND_STREAM_OPEN
COMMAND_UNLINK
COMMAND_URL_STAT
The following interceptor is shipped with the package and ready to use in order
to block any Phar invocation of files not having a .phar
suffix. Besides that
individual interceptors are possible of course.
class PharExtensionInterceptor implements Assertable
{
/**
* Determines whether the base file name has a ".phar" suffix.
*
* @param string $path
* @param string $command
* @return bool
* @throws Exception
*/
public function assert($path, $command)
{
if ($this->baseFileContainsPharExtension($path)) {
return true;
}
throw new Exception(
sprintf(
'Unexpected file extension in "%s"',
$path
),
1535198703
);
}
/**
* @param string $path
* @return bool
*/
private function baseFileContainsPharExtension($path)
{
$baseFile = Helper::determineBaseFile($path);
if ($baseFile === null) {
return false;
}
$fileExtension = pathinfo($baseFile, PATHINFO_EXTENSION);
return strtolower($fileExtension) === 'phar';
}
}
Helper::determineBaseFile(string $path)
: Determines base file that can be
accessed using the regular file system. For instance the following path
phar:///home/user/bundle.phar/content.txt
would be resolved to
/home/user/bundle.phar
.Helper::resetOpCache()
: Resets PHP's OPcache if enabled as work-around for
issues in include()
or require()
calls and OPcache delivering wrong
results. More details can be found in PHP's bug tracker, for instance like
https://bugs.php.net/bug.php?id=66569In case of finding additional security issues in the TYPO3 project or in this
PharStreamWrapper
package in particular, please get in touch with the
TYPO3 Security Team.