Browse Source

added and configured menu_admin_per_menu module

Bachir Soussi Chiadmi 7 years ago
parent
commit
54c135a573
17 changed files with 977 additions and 0 deletions
  1. 339 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/LICENSE.txt
  2. 14 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/README.txt
  3. 42 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.api.php
  4. 13 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.info.yml
  5. 14 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.install
  6. 97 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.module
  7. 2 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.permissions.yml
  8. 7 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.services.yml
  9. 91 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/src/Access/MenuAdminPerMenuAccess.php
  10. 67 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/src/Controller/MenuAdminPerMenuController.php
  11. 76 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/src/MenuAdminPerMenuAccessInterface.php
  12. 37 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/src/MenuAdminPerMenuPermissions.php
  13. 58 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/src/Routing/RouteSubscriber.php
  14. 116 0
      sites/all/modules/contrib/admin/menu_admin_per_menu/src/Tests/MenuAdminPerMenuNodeSave.php
  15. 2 0
      sites/default/config/sync/core.extension.yml
  16. 1 0
      sites/default/config/sync/user.role.admin.yml
  17. 1 0
      sites/default/config/sync/user.role.root.yml

+ 339 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/LICENSE.txt

@@ -0,0 +1,339 @@
+                    GNU GENERAL PUBLIC LICENSE
+                       Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+                            Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+License is intended to guarantee your freedom to share and change free
+software--to make sure the software is free for all its users.  This
+General Public License applies to most of the Free Software
+Foundation's software and to any other program whose authors commit to
+using it.  (Some other Free Software Foundation software is covered by
+the GNU Lesser General Public License instead.)  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+this service if you wish), that you receive source code or can get it
+if you want it, that you can change the software or use pieces of it
+in new free programs; and that you know you can do these things.
+
+  To protect your rights, we need to make restrictions that forbid
+anyone to deny you these rights or to ask you to surrender the rights.
+These restrictions translate to certain responsibilities for you if you
+distribute copies of the software, or if you modify it.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must give the recipients all the rights that
+you have.  You must make sure that they, too, receive or can get the
+source code.  And you must show them these terms so they know their
+rights.
+
+  We protect your rights with two steps: (1) copyright the software, and
+(2) offer you this license which gives you legal permission to copy,
+distribute and/or modify the software.
+
+  Also, for each author's protection and ours, we want to make certain
+that everyone understands that there is no warranty for this free
+software.  If the software is modified by someone else and passed on, we
+want its recipients to know that what they have is not the original, so
+that any problems introduced by others will not reflect on the original
+authors' reputations.
+
+  Finally, any free program is threatened constantly by software
+patents.  We wish to avoid the danger that redistributors of a free
+program will individually obtain patent licenses, in effect making the
+program proprietary.  To prevent this, we have made it clear that any
+patent must be licensed for everyone's free use or not licensed at all.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+                    GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License applies to any program or other work which contains
+a notice placed by the copyright holder saying it may be distributed
+under the terms of this General Public License.  The "Program", below,
+refers to any such program or work, and a "work based on the Program"
+means either the Program or any derivative work under copyright law:
+that is to say, a work containing the Program or a portion of it,
+either verbatim or with modifications and/or translated into another
+language.  (Hereinafter, translation is included without limitation in
+the term "modification".)  Each licensee is addressed as "you".
+
+Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running the Program is not restricted, and the output from the Program
+is covered only if its contents constitute a work based on the
+Program (independent of having been made by running the Program).
+Whether that is true depends on what the Program does.
+
+  1. You may copy and distribute verbatim copies of the Program's
+source code as you receive it, in any medium, provided that you
+conspicuously and appropriately publish on each copy an appropriate
+copyright notice and disclaimer of warranty; keep intact all the
+notices that refer to this License and to the absence of any warranty;
+and give any other recipients of the Program a copy of this License
+along with the Program.
+
+You may charge a fee for the physical act of transferring a copy, and
+you may at your option offer warranty protection in exchange for a fee.
+
+  2. You may modify your copy or copies of the Program or any portion
+of it, thus forming a work based on the Program, and copy and
+distribute such modifications or work under the terms of Section 1
+above, provided that you also meet all of these conditions:
+
+    a) You must cause the modified files to carry prominent notices
+    stating that you changed the files and the date of any change.
+
+    b) You must cause any work that you distribute or publish, that in
+    whole or in part contains or is derived from the Program or any
+    part thereof, to be licensed as a whole at no charge to all third
+    parties under the terms of this License.
+
+    c) If the modified program normally reads commands interactively
+    when run, you must cause it, when started running for such
+    interactive use in the most ordinary way, to print or display an
+    announcement including an appropriate copyright notice and a
+    notice that there is no warranty (or else, saying that you provide
+    a warranty) and that users may redistribute the program under
+    these conditions, and telling the user how to view a copy of this
+    License.  (Exception: if the Program itself is interactive but
+    does not normally print such an announcement, your work based on
+    the Program is not required to print an announcement.)
+
+These requirements apply to the modified work as a whole.  If
+identifiable sections of that work are not derived from the Program,
+and can be reasonably considered independent and separate works in
+themselves, then this License, and its terms, do not apply to those
+sections when you distribute them as separate works.  But when you
+distribute the same sections as part of a whole which is a work based
+on the Program, the distribution of the whole must be on the terms of
+this License, whose permissions for other licensees extend to the
+entire whole, and thus to each and every part regardless of who wrote it.
+
+Thus, it is not the intent of this section to claim rights or contest
+your rights to work written entirely by you; rather, the intent is to
+exercise the right to control the distribution of derivative or
+collective works based on the Program.
+
+In addition, mere aggregation of another work not based on the Program
+with the Program (or with a work based on the Program) on a volume of
+a storage or distribution medium does not bring the other work under
+the scope of this License.
+
+  3. You may copy and distribute the Program (or a work based on it,
+under Section 2) in object code or executable form under the terms of
+Sections 1 and 2 above provided that you also do one of the following:
+
+    a) Accompany it with the complete corresponding machine-readable
+    source code, which must be distributed under the terms of Sections
+    1 and 2 above on a medium customarily used for software interchange; or,
+
+    b) Accompany it with a written offer, valid for at least three
+    years, to give any third party, for a charge no more than your
+    cost of physically performing source distribution, a complete
+    machine-readable copy of the corresponding source code, to be
+    distributed under the terms of Sections 1 and 2 above on a medium
+    customarily used for software interchange; or,
+
+    c) Accompany it with the information you received as to the offer
+    to distribute corresponding source code.  (This alternative is
+    allowed only for noncommercial distribution and only if you
+    received the program in object code or executable form with such
+    an offer, in accord with Subsection b above.)
+
+The source code for a work means the preferred form of the work for
+making modifications to it.  For an executable work, complete source
+code means all the source code for all modules it contains, plus any
+associated interface definition files, plus the scripts used to
+control compilation and installation of the executable.  However, as a
+special exception, the source code distributed need not include
+anything that is normally distributed (in either source or binary
+form) with the major components (compiler, kernel, and so on) of the
+operating system on which the executable runs, unless that component
+itself accompanies the executable.
+
+If distribution of executable or object code is made by offering
+access to copy from a designated place, then offering equivalent
+access to copy the source code from the same place counts as
+distribution of the source code, even though third parties are not
+compelled to copy the source along with the object code.
+
+  4. You may not copy, modify, sublicense, or distribute the Program
+except as expressly provided under this License.  Any attempt
+otherwise to copy, modify, sublicense or distribute the Program is
+void, and will automatically terminate your rights under this License.
+However, parties who have received copies, or rights, from you under
+this License will not have their licenses terminated so long as such
+parties remain in full compliance.
+
+  5. You are not required to accept this License, since you have not
+signed it.  However, nothing else grants you permission to modify or
+distribute the Program or its derivative works.  These actions are
+prohibited by law if you do not accept this License.  Therefore, by
+modifying or distributing the Program (or any work based on the
+Program), you indicate your acceptance of this License to do so, and
+all its terms and conditions for copying, distributing or modifying
+the Program or works based on it.
+
+  6. Each time you redistribute the Program (or any work based on the
+Program), the recipient automatically receives a license from the
+original licensor to copy, distribute or modify the Program subject to
+these terms and conditions.  You may not impose any further
+restrictions on the recipients' exercise of the rights granted herein.
+You are not responsible for enforcing compliance by third parties to
+this License.
+
+  7. If, as a consequence of a court judgment or allegation of patent
+infringement or for any other reason (not limited to patent issues),
+conditions are imposed on you (whether by court order, agreement or
+otherwise) that contradict the conditions of this License, they do not
+excuse you from the conditions of this License.  If you cannot
+distribute so as to satisfy simultaneously your obligations under this
+License and any other pertinent obligations, then as a consequence you
+may not distribute the Program at all.  For example, if a patent
+license would not permit royalty-free redistribution of the Program by
+all those who receive copies directly or indirectly through you, then
+the only way you could satisfy both it and this License would be to
+refrain entirely from distribution of the Program.
+
+If any portion of this section is held invalid or unenforceable under
+any particular circumstance, the balance of the section is intended to
+apply and the section as a whole is intended to apply in other
+circumstances.
+
+It is not the purpose of this section to induce you to infringe any
+patents or other property right claims or to contest validity of any
+such claims; this section has the sole purpose of protecting the
+integrity of the free software distribution system, which is
+implemented by public license practices.  Many people have made
+generous contributions to the wide range of software distributed
+through that system in reliance on consistent application of that
+system; it is up to the author/donor to decide if he or she is willing
+to distribute software through any other system and a licensee cannot
+impose that choice.
+
+This section is intended to make thoroughly clear what is believed to
+be a consequence of the rest of this License.
+
+  8. If the distribution and/or use of the Program is restricted in
+certain countries either by patents or by copyrighted interfaces, the
+original copyright holder who places the Program under this License
+may add an explicit geographical distribution limitation excluding
+those countries, so that distribution is permitted only in or among
+countries not thus excluded.  In such case, this License incorporates
+the limitation as if written in the body of this License.
+
+  9. The Free Software Foundation may publish revised and/or new versions
+of the General Public License from time to time.  Such new versions will
+be similar in spirit to the present version, but may differ in detail to
+address new problems or concerns.
+
+Each version is given a distinguishing version number.  If the Program
+specifies a version number of this License which applies to it and "any
+later version", you have the option of following the terms and conditions
+either of that version or of any later version published by the Free
+Software Foundation.  If the Program does not specify a version number of
+this License, you may choose any version ever published by the Free Software
+Foundation.
+
+  10. If you wish to incorporate parts of the Program into other free
+programs whose distribution conditions are different, write to the author
+to ask for permission.  For software which is copyrighted by the Free
+Software Foundation, write to the Free Software Foundation; we sometimes
+make exceptions for this.  Our decision will be guided by the two goals
+of preserving the free status of all derivatives of our free software and
+of promoting the sharing and reuse of software generally.
+
+                            NO WARRANTY
+
+  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
+OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
+OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
+TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
+PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
+REPAIR OR CORRECTION.
+
+  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
+INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
+OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
+TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
+YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
+PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGES.
+
+                     END OF TERMS AND CONDITIONS
+
+            How to Apply These Terms to Your New Programs
+
+  If you develop a new program, and you want it to be of the greatest
+possible use to the public, the best way to achieve this is to make it
+free software which everyone can redistribute and change under these terms.
+
+  To do so, attach the following notices to the program.  It is safest
+to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least
+the "copyright" line and a pointer to where the full notice is found.
+
+    <one line to give the program's name and a brief idea of what it does.>
+    Copyright (C) <year>  <name of author>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+Also add information on how to contact you by electronic and paper mail.
+
+If the program is interactive, make it output a short notice like this
+when it starts in an interactive mode:
+
+    Gnomovision version 69, Copyright (C) year name of author
+    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
+    This is free software, and you are welcome to redistribute it
+    under certain conditions; type `show c' for details.
+
+The hypothetical commands `show w' and `show c' should show the appropriate
+parts of the General Public License.  Of course, the commands you use may
+be called something other than `show w' and `show c'; they could even be
+mouse-clicks or menu items--whatever suits your program.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the program, if
+necessary.  Here is a sample; alter the names:
+
+  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
+  `Gnomovision' (which makes passes at compilers) written by James Hacker.
+
+  <signature of Ty Coon>, 1 April 1989
+  Ty Coon, President of Vice
+
+This General Public License does not permit incorporating your program into
+proprietary programs.  If your program is a subroutine library, you may
+consider it more useful to permit linking proprietary applications with the
+library.  If this is what you want to do, use the GNU Lesser General
+Public License instead of this License.

+ 14 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/README.txt

@@ -0,0 +1,14 @@
+
+MENU ADMIN PER MENU
+http://drupal.org/project/menu_admin_per_menu
+
+DESCRIPTION
+By default, Drupal 7 allows only users with "Administer menus and menu items" to add, modify or delete menu items.
+In case you want for instance to let certain users manage Main menu or Navigation menu but not Management menu, this module provides this functionality.
+
+INSTALLATION
+Please read instructions at: http://drupal.org/project/menu_admin_per_menu
+
+CONTACT
+Henri MEDOT <henri.medot[AT]absyx[DOT]fr>
+http://www.absyx.fr

+ 42 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.api.php

@@ -0,0 +1,42 @@
+<?php
+
+/**
+ * @file
+ * Hooks provided by the Menu Admin per Menu module.
+ */
+
+use Drupal\Core\Session\AccountInterface;
+
+/**
+ * @addtogroup hooks
+ * @{
+ */
+
+/**
+ * Alter the menus for which a user has per menu admin permissions.
+ *
+ * @param array $perm_menus
+ *   The $perm_menus array returned by getPerMenuPermissions()
+ *   for a user account. Values in array are menu machine names and keys are
+ *   permission name for appropriate menu.
+ *
+ * @param \Drupal\Core\Session\AccountInterface $account
+ *   The user account object.
+ *
+ * @see \Drupal\menu_admin_per_menu\MenuAdminPerMenuAccessInterface::getPerMenuPermissions()
+ * @ingroup menu
+ */
+function hook_menu_admin_per_menu_get_permissions_alter(&$perm_menus, AccountInterface $account) {
+  // Our sample module never allows certain roles to edit or delete
+  // content. Since some other node access modules might allow this
+  // permission, we expressly remove it by returning an empty $grants
+  // array for roles specified in our variable setting.
+
+  if ($account->id()) {
+    $perm_menus['administer custom-menu menu items'] = 'custom-menu';
+  }
+}
+
+/**
+ * @} End of "addtogroup hooks".
+ */

+ 13 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.info.yml

@@ -0,0 +1,13 @@
+name: Menu Admin per Menu
+type: module
+description: Allows to give roles per menu admin permissions without giving them full administer menu permission.
+package: Administration
+# core: 8.x
+dependencies:
+  - menu_ui
+
+# Information added by Drupal.org packaging script on 2017-10-05
+version: '8.x-1.0'
+core: '8.x'
+project: 'menu_admin_per_menu'
+datestamp: 1507184951

+ 14 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.install

@@ -0,0 +1,14 @@
+<?php
+
+/**
+ * @file
+ * Contains install and update functions for menu_admin_per_menu module.
+ */
+
+/**
+ * Implements hook_install().
+ */
+function menu_admin_per_menu_install() {
+  // Set module weight bigger than menu_ui module.
+  module_set_weight('menu_admin_per_menu', 1);
+}

+ 97 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.module

@@ -0,0 +1,97 @@
+<?php
+
+/**
+ * @file
+ * Module file for menu_admin_per_menu.
+ */
+
+use Drupal\Core\Entity\EntityInterface;
+use Drupal\Core\Form\FormStateInterface;
+use Drupal\Core\Session\AccountInterface;
+use Drupal\menu_link_content\Form\MenuLinkContentForm;
+use Drupal\menu_ui\Form\MenuLinkEditForm;
+use Drupal\menu_ui\MenuForm;
+
+/**
+ * Implementation of hook_form_alter().
+ */
+function menu_admin_per_menu_form_alter(&$form, FormStateInterface $form_state, $form_id) {
+  $form_object = $form_state->getFormObject();
+  if ($form_object instanceof MenuLinkEditForm
+    || $form_object instanceof MenuLinkContentForm) {
+    $account = \Drupal::currentUser();
+    if (!$account->hasPermission('administer menu')) {
+      $options = $form['menu_parent']['#options'];
+      $form['menu_parent']['#options'] = menu_admin_per_menu_filter_parent_options($account, $options);
+    }
+  }
+  if ($form_object instanceof MenuForm) {
+    $account = \Drupal::currentUser();
+    if (!$account->hasPermission('administer menu')) {
+      $form['id']['#access'] = FALSE;
+      $form['label']['#access'] = FALSE;
+      $form['description']['#access'] = FALSE;
+      $form['langcode']['#access'] = FALSE;
+    }
+  }
+}
+
+/**
+ * Implements hook_form_BASE_FORM_ID_alter() for node_form.
+ */
+function menu_admin_per_menu_form_node_form_alter(&$form, FormStateInterface $form_state) {
+  $account = \Drupal::currentUser();
+  if (!$account->hasPermission('administer menu')) {
+    /** @var \Drupal\menu_admin_per_menu\MenuAdminPerMenuAccessInterface $allowedMenusService */
+    $allowedMenusService = \Drupal::service('menu_admin_per_menu.allowed_menus');
+    $allowed_menus = $allowedMenusService->getPerMenuPermissions($account);
+
+    $default_value = &$form['menu']['link']['menu_parent']['#default_value'];
+    list($current_menu, ) = explode(':', $default_value, 2);
+    // Disallow editing the menu item if there is a pre-existing menu item
+    // belonging to a menu the user does not have permission to access.
+    if (!empty($current_menu) && !in_array($current_menu, $allowed_menus)) {
+      $form['menu']['#access'] = FALSE;
+      return;
+    }
+
+    $options = &$form['menu']['link']['menu_parent']['#options'];
+    $options = menu_admin_per_menu_filter_parent_options($account, $options ? $options : []);
+    $form['menu']['#access'] = count($options) > 0;
+  }
+}
+
+/**
+ * Removes menu items for menus a user does not have permission to access.
+ *
+ * @param \Drupal\Core\Session\AccountInterface
+ *   The user to check for access.
+ * @param array $options
+ *   An array of menu item labels keyed by menu item ID.
+ *
+ * @return array
+ *   Filtered menu item labels keyed by menu item ID.
+ */
+function menu_admin_per_menu_filter_parent_options(AccountInterface $account, array $options) {
+  /** @var \Drupal\menu_admin_per_menu\MenuAdminPerMenuAccessInterface $allowedMenusService */
+  $allowedMenusService = \Drupal::service('menu_admin_per_menu.allowed_menus');
+  $allowed_menus = $allowedMenusService->getPerMenuPermissions($account);
+
+  foreach ($options as $key => $option) {
+    list($menu, ) = explode(':', $key, 2);
+    if (!in_array($menu, $allowed_menus)) {
+      unset($options[$key]);
+    }
+  }
+
+  return $options;
+}
+
+/**
+ * Implements hook_ENTITY_TYPE_access() for entity type "menu_link_content".
+ */
+function menu_admin_per_menu_menu_link_content_access(EntityInterface $entity, $operation, AccountInterface $account) {
+  /** @var \Drupal\menu_admin_per_menu\MenuAdminPerMenuAccessInterface $allowedMenusService */
+  $allowedMenusService = \Drupal::service('menu_admin_per_menu.allowed_menus');
+  return $allowedMenusService->menuItemAccess($account, $entity);
+}

+ 2 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.permissions.yml

@@ -0,0 +1,2 @@
+permission_callbacks:
+  - \Drupal\menu_admin_per_menu\MenuAdminPerMenuPermissions::permissions

+ 7 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/menu_admin_per_menu.services.yml

@@ -0,0 +1,7 @@
+services:
+  menu_admin_per_menu.route_subscriber:
+    class: Drupal\menu_admin_per_menu\Routing\RouteSubscriber
+    tags:
+      - { name: event_subscriber }
+  menu_admin_per_menu.allowed_menus:
+      class: Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess

+ 91 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/src/Access/MenuAdminPerMenuAccess.php

@@ -0,0 +1,91 @@
+<?php
+
+namespace Drupal\menu_admin_per_menu\Access;
+
+use Drupal\Core\Access\AccessResult;
+use Drupal\Core\Menu\MenuLinkInterface;
+use Drupal\Core\Session\AccountInterface;
+use Drupal\menu_admin_per_menu\MenuAdminPerMenuAccessInterface;
+use Drupal\menu_link_content\Entity\MenuLinkContent;
+use Drupal\system\Entity\Menu;
+
+/**
+ * Checks access for displaying administer menu pages.
+ */
+class MenuAdminPerMenuAccess implements MenuAdminPerMenuAccessInterface {
+
+  /**
+   * {@inheritdoc}
+   */
+  public function getPerMenuPermissions(AccountInterface $account) {
+    $perms_menu = &drupal_static(__FUNCTION__, []);
+
+    if (!$perms_menu) {
+      $menus = menu_ui_get_menus();
+      foreach ($menus as $name => $title) {
+        $permission = 'administer ' . $name . ' menu items';
+        if ($account->hasPermission($permission)) {
+          $perms_menu[$permission] = $name;
+        }
+      }
+      \Drupal::moduleHandler()->alter('menu_admin_per_menu_get_permissions', $perms_menu, $account);
+    }
+
+
+    return $perms_menu;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public function menusOverviewAccess(AccountInterface $account) {
+    if ($account->hasPermission('administer menu')) {
+      return AccessResult::allowed();
+    }
+    $permissions = $this::getPerMenuPermissions($account);
+    if ($account->hasPermission('administer menu') || $permissions) {
+      return AccessResult::allowed();
+    }
+    return AccessResult::neutral();
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public function menuAccess(AccountInterface $account, Menu $menu) {
+    $permission = 'administer ' . $menu->get('id') . ' menu items';
+    $permissions = $this::getPerMenuPermissions($account);
+    if ($account->hasPermission('administer menu')
+      || isset($permissions[$permission])) {
+      return AccessResult::allowed();
+    }
+    return AccessResult::neutral();
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public function menuItemAccess(AccountInterface $account, MenuLinkContent $menu_link_content = NULL) {
+    $permission = 'administer ' . $menu_link_content->getMenuName() . ' menu items';
+    $permissions = $this::getPerMenuPermissions($account);
+    if ($account->hasPermission('administer menu')
+      || isset($permissions[$permission])) {
+      return AccessResult::allowed();
+    }
+    return AccessResult::neutral();
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public function menuLinkAccess(AccountInterface $account, MenuLinkInterface $menu_link_plugin = NULL) {
+    $permission = 'administer ' . $menu_link_plugin->getMenuName() . ' menu items';
+    $permissions = $this::getPerMenuPermissions($account);
+    if ($account->hasPermission('administer menu')
+      || isset($permissions[$permission])) {
+      return AccessResult::allowed();
+    }
+    return AccessResult::neutral();
+  }
+
+}

+ 67 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/src/Controller/MenuAdminPerMenuController.php

@@ -0,0 +1,67 @@
+<?php
+
+namespace Drupal\menu_admin_per_menu\Controller;
+
+use Drupal\Core\Controller\ControllerBase;
+use Drupal\Core\Url;
+use Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess;
+use Symfony\Component\DependencyInjection\ContainerInterface;
+
+/**
+ * Controller routines for menu overview route.
+ */
+class MenuAdminPerMenuController extends ControllerBase {
+
+  /**
+   * The allowed menus provider.
+   *
+   * @var \Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess
+   */
+  protected $allowedMenusService;
+
+  /**
+   * Constructs a new MenuAdminPerMenu instance.
+   *
+   * @param \Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess $allowed_menus
+   *   The check provider.
+   */
+  public function __construct(MenuAdminPerMenuAccess $allowed_menus) {
+    $this->allowedMenusService = $allowed_menus;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public static function create(ContainerInterface $container) {
+    return new static(
+      $container->get('menu_admin_per_menu.allowed_menus')
+    );
+  }
+
+  /**
+   * Constructs menus overview page.
+   */
+  public function menuOverviewPage() {
+    $account = $this->currentUser();
+    $menu_table = $this->entityTypeManager()->getListBuilder('menu')->render();
+    if ($account->hasPermission('administer menu')) {
+      return $menu_table;
+    }
+    $allowed_menus = $this->allowedMenusService->getPerMenuPermissions($account);
+    foreach ($menu_table['table']['#rows'] as $menu_key => $menu_item) {
+      if (!isset($allowed_menus["administer $menu_key menu items"])) {
+        unset($menu_table['table']['#rows'][$menu_key]);
+      }
+      else {
+        $menu_row = &$menu_table['table']['#rows'][$menu_key];
+        $menu_operations = &$menu_row['operations']['data']['#links'];
+        $menu_operations['list']['title'] = $this->t('List links');
+        $menu_operations['list']['url'] = Url::fromRoute('entity.menu.edit_form', ['menu' => $menu_key]);
+        $menu_operations['add']['title'] = $this->t('Add link');
+        $menu_operations['add']['url'] = Url::fromRoute('entity.menu.add_link_form', ['menu' => $menu_key]);
+      }
+    }
+    return $menu_table;
+  }
+
+}

+ 76 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/src/MenuAdminPerMenuAccessInterface.php

@@ -0,0 +1,76 @@
+<?php
+
+namespace Drupal\menu_admin_per_menu;
+
+use Drupal\Core\Session\AccountInterface;
+use Drupal\Core\Menu\MenuLinkInterface;
+use Drupal\menu_link_content\Entity\MenuLinkContent;
+use Drupal\system\Entity\Menu;
+
+/**
+ * Provides an interface defining a MenuAdminPerMenuAccess manager.
+ */
+interface MenuAdminPerMenuAccessInterface {
+
+  /**
+   * Return array of all specific menu permissions.
+   *
+   * @param \Drupal\Core\Session\AccountInterface $account
+   *   The user object for the user whose menu access is being checked.
+   *
+   * @return array
+   *   The array of allowed menus, keyed with permission.
+   */
+  public function getPerMenuPermissions(AccountInterface $account);
+
+  /**
+   * A custom access check for menu overview page
+   *
+   * @param \Drupal\Core\Session\AccountInterface $account
+   *   Run access checks for this account.
+   *
+   * @return \Drupal\Core\Access\AccessResult
+   *   The access result.
+   */
+  public function menusOverviewAccess(AccountInterface $account);
+
+  /**
+   * A custom access check for menu page and add link page.
+   *
+   * @param \Drupal\Core\Session\AccountInterface $account
+   *   Run access checks for this account.
+   * @param \Drupal\system\Entity\Menu $menu
+   *   Run access checks for this menu object.
+   *
+   * @return \Drupal\Core\Access\AccessResult
+   *   The access result.
+   */
+  public function menuAccess(AccountInterface $account, Menu $menu);
+
+  /**
+   * A custom access check for menu items page.
+   *
+   * @param \Drupal\Core\Session\AccountInterface $account
+   *   Run access checks for this account.
+   * @param \Drupal\menu_link_content\Entity\MenuLinkContent $menu_link_content
+   *   Run access checks for this menu item object.
+   *
+   * @return \Drupal\Core\Access\AccessResult
+   *   The access result.
+   */
+  public function menuItemAccess(AccountInterface $account, MenuLinkContent $menu_link_content = NULL);
+
+  /**
+   * A custom access check for menu link page.
+   *
+   * @param \Drupal\Core\Session\AccountInterface $account
+   *   Run access checks for this account.
+   * @param \Drupal\Core\Menu\MenuLinkInterface $menu_link_plugin
+   *   Run access checks for this menu link object.
+   *
+   * @return \Drupal\Core\Access\AccessResult
+   *   The access result.
+   */
+  public function menuLinkAccess(AccountInterface $account, MenuLinkInterface $menu_link_plugin = NULL);
+
+}

+ 37 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/src/MenuAdminPerMenuPermissions.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Drupal\menu_admin_per_menu;
+
+use Drupal\Core\StringTranslation\StringTranslationTrait;
+
+class MenuAdminPerMenuPermissions {
+
+  use StringTranslationTrait;
+
+  /**
+   * Returns an array of existing menus on site.
+   *
+   * @return array
+   */
+  protected function getExistingMenus() {
+    return menu_ui_get_menus();
+  }
+
+  /**
+   * Returns an array of menu_admin_per_menu permissions.
+   *
+   * @return array
+   */
+  public function permissions() {
+    $permissions = [];
+    $menus = $this->getExistingMenus();
+    foreach ($menus as $name => $title) {
+      $permission = 'administer ' . $name . ' menu items';
+      $permissions[$permission] = [
+        'title' => $this->t('Administer <em>@menu</em> menu items', ['@menu' => $title]),
+      ];
+    }
+    return $permissions;
+  }
+
+}

+ 58 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/src/Routing/RouteSubscriber.php

@@ -0,0 +1,58 @@
+<?php
+
+namespace Drupal\menu_admin_per_menu\Routing;
+
+use Drupal\Core\Routing\RouteSubscriberBase;
+use Drupal\Core\Routing\RoutingEvents;
+use Symfony\Component\Routing\RouteCollection;
+
+/**
+ * Listens to the dynamic route events.
+ */
+class RouteSubscriber extends RouteSubscriberBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function alterRoutes(RouteCollection $collection) {
+    $routes = $collection->all();
+    foreach ($routes as $route_name => $route) {
+      switch ($route_name) {
+        case 'entity.menu.collection':
+          $route->setDefaults(['_controller' => '\Drupal\menu_admin_per_menu\Controller\MenuAdminPerMenuController::menuOverviewPage']);
+          $route->setRequirements(['_custom_access' => '\Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess::menusOverviewAccess']);
+          break;
+
+        case 'entity.menu.edit_form':
+        case 'entity.menu.add_link_form':
+          $route->setRequirements(['_custom_access' => '\Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess::menuAccess']);
+          break;
+
+        case 'menu_ui.link_edit':
+        case 'menu_ui.link_reset':
+          $route->setRequirements(['_custom_access' => '\Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess::menuLinkAccess']);
+          break;
+
+        case 'entity.menu_link_content.canonical':
+        case 'entity.menu_link_content.delete_form':
+        case 'entity.menu_link_content.content_translation_overview':
+        case 'entity.menu_link_content.content_translation_add':
+        case 'entity.menu_link_content.content_translation_edit':
+        case 'entity.menu_link_content.content_translation_delete':
+          $route->setRequirements(['_custom_access' => '\Drupal\menu_admin_per_menu\Access\MenuAdminPerMenuAccess::menuItemAccess']);
+          break;
+
+      }
+    }
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public static function getSubscribedEvents() {
+    // Run after content_translation, which has priority -210.
+    $events[RoutingEvents::ALTER] = ['onAlterRoutes', -220];
+    return $events;
+  }
+
+}

+ 116 - 0
sites/all/modules/contrib/admin/menu_admin_per_menu/src/Tests/MenuAdminPerMenuNodeSave.php

@@ -0,0 +1,116 @@
+<?php
+
+namespace Drupal\menu_admin_per_menu\Tests;
+
+use Drupal\Tests\BrowserTestBase;
+
+/**
+ * Tests the interaction of the node system with menu links.
+ *
+ * @group node
+ */
+class MenuAdminPerMenuNodeSave extends BrowserTestBase {
+
+  /**
+   * Modules to enable.
+   *
+   * @var array
+   */
+  public static $modules = ['menu_ui', 'node', 'block', 'menu_admin_per_menu'];
+
+  /**
+   * A user with permission to create nodes but not administer menu.
+   *
+   * @var \Drupal\user\UserInterface
+   */
+  protected $contentOnlyUser;
+
+  /**
+   * A user with permission to create nodes and administer menu.
+   *
+   * @var \Drupal\user\UserInterface
+   */
+  protected $contentAndMenuUser;
+
+  /**
+   * A user with permission to access content only.
+   *
+   * @var \Drupal\user\UserInterface
+   */
+  protected $anonymousUser;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp() {
+    parent::setUp();
+
+    // Create Basic page node types.
+    if ($this->profile != 'standard') {
+      $this->drupalCreateContentType([
+        'type' => 'page',
+        'name' => 'Basic page',
+        'display_submitted' => FALSE,
+      ]);
+    }
+
+    $this->drupalPlaceBlock('system_menu_block:main');
+
+    $this->contentOnlyUser = $this->drupalCreateUser([
+      'access content',
+      'administer content types',
+    ]);
+    $this->contentAndMenuUser = $this->drupalCreateUser([
+      'access content',
+      'administer content types',
+      'administer main menu items',
+    ]);
+    $this->anonymousUser = $this->drupalCreateUser([
+      'access content',
+    ]);
+  }
+
+  /**
+   * Test menu re-save by users without permission.
+   *
+   * Tests that a menu still exists and remains existing if a user without the
+   * menu permissions resaves a node.
+   */
+  public function testResaveMenuLinkWithoutAccess() {
+    $menu_link_title = $this->randomString();
+
+    // Save the node with the menu.
+    $this->drupalLogin($this->contentAndMenuUser);
+    $edit = [
+      'title[0][value]' => $this->randomString(),
+      'body[0][value]' => $this->randomString(),
+      'menu[enabled]' => 1,
+      'menu[title]' => $menu_link_title,
+    ];
+    $this->drupalPostForm('node/add/page', $edit, t('Save'));
+
+    // Ensure the menu is in place.
+    $this->assertLink($menu_link_title);
+
+    // Logout.
+    $this->drupalLogout();
+
+    // Save the node again as someone without permission.
+    $this->drupalLogin($this->contentOnlyUser);
+    $edit = [
+      'title[0][value]' => $this->randomString(),
+      'body[0][value]' => $this->randomString(),
+    ];
+    $this->drupalPostForm('node/add/page', $edit, t('Save'));
+
+    // Ensure the menu is still in place.
+    $this->assertLink($menu_link_title);
+
+    // Ensure anonymous users with "access content" permission can see this
+    // menu.
+    $this->drupalLogout();
+    $this->drupalGet('');
+    $this->assertLink($menu_link_title);
+  }
+
+}

+ 2 - 0
sites/default/config/sync/core.extension.yml

@@ -59,6 +59,7 @@ module:
   page_cache: 0
   path: 0
   profile: 0
+  redis: 0
   responsive_image: 0
   system: 0
   taxonomy: 0
@@ -68,6 +69,7 @@ module:
   user: 0
   views: 0
   views_ui: 0
+  menu_admin_per_menu: 1
   menu_link_content: 1
   content_translation: 10
   minimal: 1000

+ 1 - 0
sites/default/config/sync/user.role.admin.yml

@@ -11,6 +11,7 @@ permissions:
   - 'access files overview'
   - 'access toolbar'
   - 'access user profiles'
+  - 'administer productions menu items'
   - 'administer users'
   - 'change own username'
   - 'create autre_son content'

+ 1 - 0
sites/default/config/sync/user.role.root.yml

@@ -43,6 +43,7 @@ permissions:
   - 'administer node form display'
   - 'administer nodes'
   - 'administer permissions'
+  - 'administer productions menu items'
   - 'administer profile'
   - 'administer profile display'
   - 'administer profile fields'