security update core+modules
This commit is contained in:
@@ -22,11 +22,11 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
* Tests for drupal_save_session() and drupal_session_regenerate().
|
||||
*/
|
||||
function testSessionSaveRegenerate() {
|
||||
$this->assertFalse(drupal_save_session(), t('drupal_save_session() correctly returns FALSE (inside of testing framework) when initially called with no arguments.'), t('Session'));
|
||||
$this->assertFalse(drupal_save_session(FALSE), t('drupal_save_session() correctly returns FALSE when called with FALSE.'), t('Session'));
|
||||
$this->assertFalse(drupal_save_session(), t('drupal_save_session() correctly returns FALSE when saving has been disabled.'), t('Session'));
|
||||
$this->assertTrue(drupal_save_session(TRUE), t('drupal_save_session() correctly returns TRUE when called with TRUE.'), t('Session'));
|
||||
$this->assertTrue(drupal_save_session(), t('drupal_save_session() correctly returns TRUE when saving has been enabled.'), t('Session'));
|
||||
$this->assertFalse(drupal_save_session(), 'drupal_save_session() correctly returns FALSE (inside of testing framework) when initially called with no arguments.', 'Session');
|
||||
$this->assertFalse(drupal_save_session(FALSE), 'drupal_save_session() correctly returns FALSE when called with FALSE.', 'Session');
|
||||
$this->assertFalse(drupal_save_session(), 'drupal_save_session() correctly returns FALSE when saving has been disabled.', 'Session');
|
||||
$this->assertTrue(drupal_save_session(TRUE), 'drupal_save_session() correctly returns TRUE when called with TRUE.', 'Session');
|
||||
$this->assertTrue(drupal_save_session(), 'drupal_save_session() correctly returns TRUE when saving has been enabled.', 'Session');
|
||||
|
||||
// Test session hardening code from SA-2008-044.
|
||||
$user = $this->drupalCreateUser(array('access content'));
|
||||
@@ -36,7 +36,7 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
|
||||
// Make sure the session cookie is set as HttpOnly.
|
||||
$this->drupalLogin($user);
|
||||
$this->assertTrue(preg_match('/HttpOnly/i', $this->drupalGetHeader('Set-Cookie', TRUE)), t('Session cookie is set as HttpOnly.'));
|
||||
$this->assertTrue(preg_match('/HttpOnly/i', $this->drupalGetHeader('Set-Cookie', TRUE)), 'Session cookie is set as HttpOnly.');
|
||||
$this->drupalLogout();
|
||||
|
||||
// Verify that the session is regenerated if a module calls exit
|
||||
@@ -46,7 +46,7 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
$this->drupalGet('session-test/id');
|
||||
$matches = array();
|
||||
preg_match('/\s*session_id:(.*)\n/', $this->drupalGetContent(), $matches);
|
||||
$this->assertTrue(!empty($matches[1]) , t('Found session ID before logging in.'));
|
||||
$this->assertTrue(!empty($matches[1]) , 'Found session ID before logging in.');
|
||||
$original_session = $matches[1];
|
||||
|
||||
// We cannot use $this->drupalLogin($user); because we exit in
|
||||
@@ -57,19 +57,18 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
);
|
||||
$this->drupalPost('user', $edit, t('Log in'));
|
||||
$this->drupalGet('user');
|
||||
$pass = $this->assertText($user->name, t('Found name: %name', array('%name' => $user->name)), t('User login'));
|
||||
$pass = $this->assertText($user->name, format_string('Found name: %name', array('%name' => $user->name)), 'User login');
|
||||
$this->_logged_in = $pass;
|
||||
|
||||
$this->drupalGet('session-test/id');
|
||||
$matches = array();
|
||||
preg_match('/\s*session_id:(.*)\n/', $this->drupalGetContent(), $matches);
|
||||
$this->assertTrue(!empty($matches[1]) , t('Found session ID after logging in.'));
|
||||
$this->assertTrue($matches[1] != $original_session, t('Session ID changed after login.'));
|
||||
$this->assertTrue(!empty($matches[1]) , 'Found session ID after logging in.');
|
||||
$this->assertTrue($matches[1] != $original_session, 'Session ID changed after login.');
|
||||
}
|
||||
|
||||
/**
|
||||
* Test data persistence via the session_test module callbacks. Also tests
|
||||
* drupal_session_count() since session data is already generated here.
|
||||
* Test data persistence via the session_test module callbacks.
|
||||
*/
|
||||
function testDataPersistence() {
|
||||
$user = $this->drupalCreateUser(array('access content'));
|
||||
@@ -80,48 +79,48 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
|
||||
$value_1 = $this->randomName();
|
||||
$this->drupalGet('session-test/set/' . $value_1);
|
||||
$this->assertText($value_1, t('The session value was stored.'), t('Session'));
|
||||
$this->assertText($value_1, 'The session value was stored.', 'Session');
|
||||
$this->drupalGet('session-test/get');
|
||||
$this->assertText($value_1, t('Session correctly returned the stored data for an authenticated user.'), t('Session'));
|
||||
$this->assertText($value_1, 'Session correctly returned the stored data for an authenticated user.', 'Session');
|
||||
|
||||
// Attempt to write over val_1. If drupal_save_session(FALSE) is working.
|
||||
// properly, val_1 will still be set.
|
||||
$value_2 = $this->randomName();
|
||||
$this->drupalGet('session-test/no-set/' . $value_2);
|
||||
$this->assertText($value_2, t('The session value was correctly passed to session-test/no-set.'), t('Session'));
|
||||
$this->assertText($value_2, 'The session value was correctly passed to session-test/no-set.', 'Session');
|
||||
$this->drupalGet('session-test/get');
|
||||
$this->assertText($value_1, t('Session data is not saved for drupal_save_session(FALSE).'), t('Session'));
|
||||
$this->assertText($value_1, 'Session data is not saved for drupal_save_session(FALSE).', 'Session');
|
||||
|
||||
// Switch browser cookie to anonymous user, then back to user 1.
|
||||
$this->sessionReset();
|
||||
$this->sessionReset($user->uid);
|
||||
$this->assertText($value_1, t('Session data persists through browser close.'), t('Session'));
|
||||
$this->assertText($value_1, 'Session data persists through browser close.', 'Session');
|
||||
|
||||
// Logout the user and make sure the stored value no longer persists.
|
||||
$this->drupalLogout();
|
||||
$this->sessionReset();
|
||||
$this->drupalGet('session-test/get');
|
||||
$this->assertNoText($value_1, t("After logout, previous user's session data is not available."), t('Session'));
|
||||
$this->assertNoText($value_1, "After logout, previous user's session data is not available.", 'Session');
|
||||
|
||||
// Now try to store some data as an anonymous user.
|
||||
$value_3 = $this->randomName();
|
||||
$this->drupalGet('session-test/set/' . $value_3);
|
||||
$this->assertText($value_3, t('Session data stored for anonymous user.'), t('Session'));
|
||||
$this->assertText($value_3, 'Session data stored for anonymous user.', 'Session');
|
||||
$this->drupalGet('session-test/get');
|
||||
$this->assertText($value_3, t('Session correctly returned the stored data for an anonymous user.'), t('Session'));
|
||||
$this->assertText($value_3, 'Session correctly returned the stored data for an anonymous user.', 'Session');
|
||||
|
||||
// Try to store data when drupal_save_session(FALSE).
|
||||
$value_4 = $this->randomName();
|
||||
$this->drupalGet('session-test/no-set/' . $value_4);
|
||||
$this->assertText($value_4, t('The session value was correctly passed to session-test/no-set.'), t('Session'));
|
||||
$this->assertText($value_4, 'The session value was correctly passed to session-test/no-set.', 'Session');
|
||||
$this->drupalGet('session-test/get');
|
||||
$this->assertText($value_3, t('Session data is not saved for drupal_save_session(FALSE).'), t('Session'));
|
||||
$this->assertText($value_3, 'Session data is not saved for drupal_save_session(FALSE).', 'Session');
|
||||
|
||||
// Login, the data should persist.
|
||||
$this->drupalLogin($user);
|
||||
$this->sessionReset($user->uid);
|
||||
$this->drupalGet('session-test/get');
|
||||
$this->assertNoText($value_1, t('Session has persisted for an authenticated user after logging out and then back in.'), t('Session'));
|
||||
$this->assertNoText($value_1, 'Session has persisted for an authenticated user after logging out and then back in.', 'Session');
|
||||
|
||||
// Change session and create another user.
|
||||
$user2 = $this->drupalCreateUser(array('access content'));
|
||||
@@ -143,29 +142,29 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
$this->drupalGet('');
|
||||
$this->assertSessionCookie(FALSE);
|
||||
$this->assertSessionEmpty(TRUE);
|
||||
$this->assertEqual($this->drupalGetHeader('X-Drupal-Cache'), 'MISS', t('Page was not cached.'));
|
||||
$this->assertEqual($this->drupalGetHeader('X-Drupal-Cache'), 'MISS', 'Page was not cached.');
|
||||
|
||||
// Start a new session by setting a message.
|
||||
$this->drupalGet('session-test/set-message');
|
||||
$this->assertSessionCookie(TRUE);
|
||||
$this->assertTrue($this->drupalGetHeader('Set-Cookie'), t('New session was started.'));
|
||||
$this->assertTrue($this->drupalGetHeader('Set-Cookie'), 'New session was started.');
|
||||
|
||||
// Display the message, during the same request the session is destroyed
|
||||
// and the session cookie is unset.
|
||||
$this->drupalGet('');
|
||||
$this->assertSessionCookie(FALSE);
|
||||
$this->assertSessionEmpty(FALSE);
|
||||
$this->assertFalse($this->drupalGetHeader('X-Drupal-Cache'), t('Caching was bypassed.'));
|
||||
$this->assertText(t('This is a dummy message.'), t('Message was displayed.'));
|
||||
$this->assertTrue(preg_match('/SESS\w+=deleted/', $this->drupalGetHeader('Set-Cookie')), t('Session cookie was deleted.'));
|
||||
$this->assertFalse($this->drupalGetHeader('X-Drupal-Cache'), 'Caching was bypassed.');
|
||||
$this->assertText(t('This is a dummy message.'), 'Message was displayed.');
|
||||
$this->assertTrue(preg_match('/SESS\w+=deleted/', $this->drupalGetHeader('Set-Cookie')), 'Session cookie was deleted.');
|
||||
|
||||
// Verify that session was destroyed.
|
||||
$this->drupalGet('');
|
||||
$this->assertSessionCookie(FALSE);
|
||||
$this->assertSessionEmpty(TRUE);
|
||||
$this->assertNoText(t('This is a dummy message.'), t('Message was not cached.'));
|
||||
$this->assertEqual($this->drupalGetHeader('X-Drupal-Cache'), 'HIT', t('Page was cached.'));
|
||||
$this->assertFalse($this->drupalGetHeader('Set-Cookie'), t('New session was not started.'));
|
||||
$this->assertNoText(t('This is a dummy message.'), 'Message was not cached.');
|
||||
$this->assertEqual($this->drupalGetHeader('X-Drupal-Cache'), 'HIT', 'Page was cached.');
|
||||
$this->assertFalse($this->drupalGetHeader('Set-Cookie'), 'New session was not started.');
|
||||
|
||||
// Verify that no session is created if drupal_save_session(FALSE) is called.
|
||||
$this->drupalGet('session-test/set-message-but-dont-save');
|
||||
@@ -176,7 +175,7 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
$this->drupalGet('');
|
||||
$this->assertSessionCookie(FALSE);
|
||||
$this->assertSessionEmpty(TRUE);
|
||||
$this->assertNoText(t('This is a dummy message.'), t('The message was not saved.'));
|
||||
$this->assertNoText(t('This is a dummy message.'), 'The message was not saved.');
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -196,29 +195,29 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
sleep(1);
|
||||
$this->drupalGet('session-test/set/foo');
|
||||
$times2 = db_query($sql, array(':uid' => $user->uid))->fetchObject();
|
||||
$this->assertEqual($times2->access, $times1->access, t('Users table was not updated.'));
|
||||
$this->assertNotEqual($times2->timestamp, $times1->timestamp, t('Sessions table was updated.'));
|
||||
$this->assertEqual($times2->access, $times1->access, 'Users table was not updated.');
|
||||
$this->assertNotEqual($times2->timestamp, $times1->timestamp, 'Sessions table was updated.');
|
||||
|
||||
// Write the same value again, i.e. do not modify the session.
|
||||
sleep(1);
|
||||
$this->drupalGet('session-test/set/foo');
|
||||
$times3 = db_query($sql, array(':uid' => $user->uid))->fetchObject();
|
||||
$this->assertEqual($times3->access, $times1->access, t('Users table was not updated.'));
|
||||
$this->assertEqual($times3->timestamp, $times2->timestamp, t('Sessions table was not updated.'));
|
||||
$this->assertEqual($times3->access, $times1->access, 'Users table was not updated.');
|
||||
$this->assertEqual($times3->timestamp, $times2->timestamp, 'Sessions table was not updated.');
|
||||
|
||||
// Do not change the session.
|
||||
sleep(1);
|
||||
$this->drupalGet('');
|
||||
$times4 = db_query($sql, array(':uid' => $user->uid))->fetchObject();
|
||||
$this->assertEqual($times4->access, $times3->access, t('Users table was not updated.'));
|
||||
$this->assertEqual($times4->timestamp, $times3->timestamp, t('Sessions table was not updated.'));
|
||||
$this->assertEqual($times4->access, $times3->access, 'Users table was not updated.');
|
||||
$this->assertEqual($times4->timestamp, $times3->timestamp, 'Sessions table was not updated.');
|
||||
|
||||
// Force updating of users and sessions table once per second.
|
||||
variable_set('session_write_interval', 0);
|
||||
$this->drupalGet('');
|
||||
$times5 = db_query($sql, array(':uid' => $user->uid))->fetchObject();
|
||||
$this->assertNotEqual($times5->access, $times4->access, t('Users table was updated.'));
|
||||
$this->assertNotEqual($times5->timestamp, $times4->timestamp, t('Sessions table was updated.'));
|
||||
$this->assertNotEqual($times5->access, $times4->access, 'Users table was updated.');
|
||||
$this->assertNotEqual($times5->timestamp, $times4->timestamp, 'Sessions table was updated.');
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -228,7 +227,7 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
$user = $this->drupalCreateUser(array('access content'));
|
||||
$this->drupalLogin($user);
|
||||
$this->drupalGet('session-test/is-logged-in');
|
||||
$this->assertResponse(200, t('User is logged in.'));
|
||||
$this->assertResponse(200, 'User is logged in.');
|
||||
|
||||
// Reset the sid in {sessions} to a blank string. This may exist in the
|
||||
// wild in some cases, although we normally prevent it from happening.
|
||||
@@ -239,10 +238,10 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
$this->curlClose();
|
||||
$this->additionalCurlOptions[CURLOPT_COOKIE] = rawurlencode($this->session_name) . '=;';
|
||||
$this->drupalGet('session-test/id-from-cookie');
|
||||
$this->assertRaw("session_id:\n", t('Session ID is blank as sent from cookie header.'));
|
||||
$this->assertRaw("session_id:\n", 'Session ID is blank as sent from cookie header.');
|
||||
// Assert that we have an anonymous session now.
|
||||
$this->drupalGet('session-test/is-logged-in');
|
||||
$this->assertResponse(403, t('An empty session ID is not allowed.'));
|
||||
$this->assertResponse(403, 'An empty session ID is not allowed.');
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -260,7 +259,7 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
$this->additionalCurlOptions[CURLOPT_COOKIEFILE] = $this->cookieFile;
|
||||
$this->additionalCurlOptions[CURLOPT_COOKIESESSION] = TRUE;
|
||||
$this->drupalGet('session-test/get');
|
||||
$this->assertResponse(200, t('Session test module is correctly enabled.'), t('Session'));
|
||||
$this->assertResponse(200, 'Session test module is correctly enabled.', 'Session');
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -268,10 +267,10 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
*/
|
||||
function assertSessionCookie($sent) {
|
||||
if ($sent) {
|
||||
$this->assertNotNull($this->session_id, t('Session cookie was sent.'));
|
||||
$this->assertNotNull($this->session_id, 'Session cookie was sent.');
|
||||
}
|
||||
else {
|
||||
$this->assertNull($this->session_id, t('Session cookie was not sent.'));
|
||||
$this->assertNull($this->session_id, 'Session cookie was not sent.');
|
||||
}
|
||||
}
|
||||
|
||||
@@ -280,10 +279,10 @@ class SessionTestCase extends DrupalWebTestCase {
|
||||
*/
|
||||
function assertSessionEmpty($empty) {
|
||||
if ($empty) {
|
||||
$this->assertIdentical($this->drupalGetHeader('X-Session-Empty'), '1', t('Session was empty.'));
|
||||
$this->assertIdentical($this->drupalGetHeader('X-Session-Empty'), '1', 'Session was empty.');
|
||||
}
|
||||
else {
|
||||
$this->assertIdentical($this->drupalGetHeader('X-Session-Empty'), '0', t('Session was not empty.'));
|
||||
$this->assertIdentical($this->drupalGetHeader('X-Session-Empty'), '0', 'Session was not empty.');
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user