diff --git a/sites/all/modules/contrib/fields/field_group/CHANGELOG.txt b/sites/all/modules/contrib/fields/field_group/CHANGELOG.txt index b4a64bba..5e3ea36f 100644 --- a/sites/all/modules/contrib/fields/field_group/CHANGELOG.txt +++ b/sites/all/modules/contrib/fields/field_group/CHANGELOG.txt @@ -1,12 +1,23 @@ /* $Id*/ CHANGELOG for field_group for Drupal 7 -Field_group 7.x-1.x-dev - o Issue #1095316: Field Groups disappear when Content Type is renamed. - o Issue #1095316 by swentel: Support for Entity API. - o Issue #1095002 by animelion: Upgrading removes all existing field groups. - o Issue #1095130 by willvincent: Features export not working with rc2. - +Field_group 7.x-1.3 + o Issue #2077695 by FreekVR | ChoY: Fixed field group entity display bug after update. + o Issue #2078201 by DeFr, eneko1907 | cmriley: Fixed Started getting a ton of notices. + o Issue #2085137 by ar-jan: Fixed Collapse speed no longer works with field_group() 1.2 + o Issue #2085225 by dtarc: Fixed Featurized Field Groups no longer have classes since marked optional. + o Issue #2080645 by bassthiam: Fixed Warning: Illegal string offset 'label' in field_group_unpack() line 1682 of field_group()/field_group().module. + o Issue #1942676 by Harlor | El Bandito: Added Change the text 'Mark group for required fields.'. + o Issue #1358430 by FriedJam: Fixed JS 'Error: uncaught exception: Syntax error, unrecognized expression:". + o Issue #2084999 by activelink: Fixed Empty field groups aren't being suppressed since move to 7.x-1.2. + o Issue #1557258 by Mark Trapp | Chris Gillis: Fixed Existing field groups disappear and Add Field Group UI is disabled when no fields are available. + o Issue #2000110 by bigjim: Fixed Comments on field_group_read_groups() wrong + o Issue #1169146 by ankur, Nephele | jeffrey.dalton: Fixed upgrade from 7.x-1.0-rc2 to 7.x-1.0 deletes all field_groups(). + o Vertical tabs always appear when children elements have no access + o #1966624 Feature 7.x-2.0-beta2 defines fields in a new way + o #2090415 Make horizontal tabs not dependent on form.js. Also change drupal_add_x to #attached + o + Field_group 7.x-1.0-rc2 o Ran through coder, minor. o Issue #1033036 by Stalski, swentel: Create a field_group.api.php. @@ -20,7 +31,7 @@ Field_group 7.x-1.0-rc2 o #1045526 by stalski: Make formatter options more user-friendly and logical. o #1041880 by robertgarrigos: duplicated entries in field_group table. o #1043834 by amsri: Field Group module just does not work with profiles 2. - + Field_group 7.x-1.0-rc1 o #1006464 Change #groups to #fieldgroups because of name collapsing with form_process_fieldset o #1024184 fix collapsible when mode is set to open @@ -34,7 +45,7 @@ Field_group 7.x-1.0-rc1 o #961106 Fixed notice on entity type and bundle check. o #962072 by mori: Improve CSS for horizontal tabs & accordion. o Changed Fieldgroup API: defaults and instance_settings are now merged. - o Changed save action so everything is gathered during form_state to + o Changed save action so everything is gathered during form_state to postpone saving until the save button is hit. o Changed some important variable name, so it makes more sense and easier to read. o Add basic crud functions. \ No newline at end of file diff --git a/sites/all/modules/contrib/fields/field_group/field_group.api.php b/sites/all/modules/contrib/fields/field_group/field_group.api.php index 0c18c603..cef5b0a8 100644 --- a/sites/all/modules/contrib/fields/field_group/field_group.api.php +++ b/sites/all/modules/contrib/fields/field_group/field_group.api.php @@ -2,7 +2,7 @@ /** * @file - * Hooks provided by the Field group module. + * Hooks provided by the Field Group module. * * Fieldgroup is a module that will wrap fields and other fieldgroups. Nothing more, nothing less. * For this there are formatters we can create on forms and view modes. diff --git a/sites/all/modules/contrib/fields/field_group/field_group.info b/sites/all/modules/contrib/fields/field_group/field_group.info index ffda04c4..96a60539 100644 --- a/sites/all/modules/contrib/fields/field_group/field_group.info +++ b/sites/all/modules/contrib/fields/field_group/field_group.info @@ -1,19 +1,14 @@ -name = Fieldgroup -description = Fieldgroup +name = Field Group +description = "Provides the ability to group your fields on both form and display." package = Fields dependencies[] = field dependencies[] = ctools core = 7.x -files[] = field_group.install -files[] = field_group.module -files[] = field_group.field_ui.inc -files[] = field_group.form.inc -files[] = field_group.features.inc files[] = tests/field_group.ui.test files[] = tests/field_group.display.test -; Information added by drupal.org packaging script on 2013-09-25 -version = "7.x-1.3" +; Information added by Drupal.org packaging script on 2014-06-04 +version = "7.x-1.4" core = "7.x" project = "field_group" -datestamp = "1380124361" +datestamp = "1401918529" diff --git a/sites/all/modules/contrib/fields/field_group/field_group.install b/sites/all/modules/contrib/fields/field_group/field_group.install index 2ee7f087..fa5371da 100644 --- a/sites/all/modules/contrib/fields/field_group/field_group.install +++ b/sites/all/modules/contrib/fields/field_group/field_group.install @@ -310,8 +310,14 @@ function field_group_update_7006() { // Only update feature field_groups this time. // Don't touch the fieldgroups in db. + if ($row->export_type == EXPORT_IN_CODE) { - $classes = explode(" ", $row->data['format_settings']['instance_settings']['classes']); + $classes = array(); + + if (isset($row->data['format_settings'], $row->data['format_settings']['instance_settings'], $row->data['format_settings']['instance_settings']['classes'])) { + $classes = explode(" ", $row->data['format_settings']['instance_settings']['classes']); + } + $optional_classes = array(str_replace("_", "-", $row->group_name), 'field-group-' . $row->data['format_type']); foreach ($optional_classes as $optional_class) { if (!in_array($optional_class, $classes)) { @@ -325,3 +331,33 @@ function field_group_update_7006() { } } + +/** + * Id attributes are now a setting. This update will insert the old id in the setting so old + * markup doesn't get broken. If you don't want an attribute, you can delete + * them on the fieldgroup settings. + */ +function field_group_update_7007() { + + ctools_include("export"); + + // Migrate the field groups so they have a unique identifier. + $field_groups = ctools_export_load_object("field_group"); + foreach ($field_groups as $row) { + if ($row->data['format_type'] == 'div' || $row->data['format_type'] == 'html5' || $row->data['format_type'] == 'html-element') { + + // If mode is default, we don't know what view mode it was. Take full then. + $view_mode = $row->mode == 'default' ? 'full' : $row->mode; + $id = $row->entity_type . '_' . $row->bundle . '_' . $view_mode . '_' . $row->group_name; + $row->data['format_settings']['instance_settings']['id'] = $id; + } + + if ($row->export_type == EXPORT_IN_CODE) { + unset($row->id); + drupal_write_record('field_group', $row); + } + else { + drupal_write_record('field_group', $row, array('id')); + } + } +} diff --git a/sites/all/modules/contrib/fields/field_group/field_group.js b/sites/all/modules/contrib/fields/field_group/field_group.js index 08249681..eef6aaaf 100644 --- a/sites/all/modules/contrib/fields/field_group/field_group.js +++ b/sites/all/modules/contrib/fields/field_group/field_group.js @@ -183,6 +183,7 @@ Drupal.FieldGroup.Effects.processDiv = { */ Drupal.behaviors.fieldGroup = { attach: function (context, settings) { + settings.field_group = settings.field_group || Drupal.settings.field_group; if (settings.field_group == undefined) { return; } diff --git a/sites/all/modules/contrib/fields/field_group/field_group.module b/sites/all/modules/contrib/fields/field_group/field_group.module index 99570049..da1a791a 100644 --- a/sites/all/modules/contrib/fields/field_group/field_group.module +++ b/sites/all/modules/contrib/fields/field_group/field_group.module @@ -244,6 +244,7 @@ function field_group_field_attach_delete_bundle($entity_type, $bundle) { * Implements hook_field_attach_form(). */ function field_group_field_attach_form($entity_type, $entity, &$form, &$form_state, $langcode) { + $form['#attached']['css'][] = drupal_get_path('module', 'field_group') . '/field_group.field_ui.css'; field_group_attach_groups($form, 'form', $form_state); $form['#pre_render'][] = 'field_group_form_pre_render'; @@ -291,7 +292,7 @@ function field_group_field_group_formatter_info() { 'html-element' => array( 'label' => t('HTML element'), 'description' => t('This fieldgroup renders the inner content in a HTML element with classes and attributes.'), - 'instance_settings' => array('element' => 'div', 'classes' => '', 'attributes' => '', 'required_fields' => 1), + 'instance_settings' => array('element' => 'div', 'show_label' => 0, 'label_element' => 'div', 'classes' => '', 'attributes' => '', 'required_fields' => 1), ), 'div' => array( 'label' => t('Div'), @@ -303,7 +304,7 @@ function field_group_field_group_formatter_info() { 'html5' => array( 'label' => t('HTML5'), 'description' => t('This fieldgroup renders the inner content in a semantic HTML5 wrapper'), - 'instance_settings' => array('wrapper' => '', 'classes' => ''), + 'instance_settings' => array('wrapper' => '', 'classes' => '', 'id' => ''), ), 'fieldset' => array( 'label' => t('Fieldset'), @@ -365,19 +366,19 @@ function field_group_field_group_formatter_info() { 'html-element' => array( 'label' => t('HTML element'), 'description' => t('This fieldgroup renders the inner content in a HTML element with classes and attributes.'), - 'instance_settings' => array('element' => 'div', 'classes' => '', 'attributes' => '', 'required_fields' => 1), + 'instance_settings' => array('element' => 'div', 'show_label' => 0, 'label_element' => 'div', 'classes' => '', 'attributes' => '', 'required_fields' => 1), ), 'div' => array( 'label' => t('Div'), 'description' => t('This fieldgroup renders the inner content in a simple div with the title as legend.'), 'format_types' => array('open', 'collapsible', 'collapsed'), - 'instance_settings' => array('description' => '', 'show_label' => 1, 'label_element' => 'h3', 'effect' => 'none', 'speed' => 'fast', 'classes' => ''), + 'instance_settings' => array('description' => '', 'show_label' => 1, 'label_element' => 'h3', 'effect' => 'none', 'speed' => 'fast', 'classes' => '', 'id' => ''), 'default_formatter' => 'collapsible', ), 'html5' => array( 'label' => t('HTML5'), 'description' => t('This fieldgroup renders the inner content in a semantic HTML5 wrapper'), - 'instance_settings' => array('wrapper' => '', 'classes' => ''), + 'instance_settings' => array('wrapper' => '', 'classes' => '', 'id' => ''), ), 'fieldset' => array( 'label' => t('Fieldset'), @@ -452,7 +453,7 @@ function field_group_field_group_format_settings($group) { '#type' => 'select', '#options' => drupal_map_assoc($formatter['format_types']), '#default_value' => isset($group->format_settings['formatter']) ? $group->format_settings['formatter'] : $formatter['default_formatter'], - '#weight' => 1, + '#weight' => -4, ); } @@ -470,7 +471,7 @@ function field_group_field_group_format_settings($group) { '#title' => t('ID'), '#type' => 'textfield', '#default_value' => isset($group->format_settings['instance_settings']['id']) ? $group->format_settings['instance_settings']['id'] : (isset($formatter['instance_settings']['id']) ? $formatter['instance_settings']['id'] : ''), - '#weight' => 3, + '#weight' => 10, '#element_validate' => array('field_group_validate_id'), ); } @@ -479,7 +480,7 @@ function field_group_field_group_format_settings($group) { '#title' => t('Extra CSS classes'), '#type' => 'textfield', '#default_value' => isset($group->format_settings['instance_settings']['classes']) ? $group->format_settings['instance_settings']['classes'] : (isset($formatter['instance_settings']['classes']) ? $formatter['instance_settings']['classes'] : ''), - '#weight' => 4, + '#weight' => 11, '#element_validate' => array('field_group_validate_css_class'), ); } @@ -501,9 +502,24 @@ function field_group_field_group_format_settings($group) { '#type' => 'textfield', '#default_value' => isset($group->format_settings['instance_settings']['element']) ? $group->format_settings['instance_settings']['element'] : $formatter['instance_settings']['element'], '#description' => t('E.g. div, section, aside etc.'), + '#weight' => 1, + ); + + $form['instance_settings']['show_label'] = array( + '#title' => t('Show label'), + '#type' => 'select', + '#options' => array(0 => t('No'), 1 => t('Yes')), + '#default_value' => isset($group->format_settings['instance_settings']['show_label']) ? $group->format_settings['instance_settings']['show_label'] : $formatter['instance_settings']['show_label'], '#weight' => 2, ); + $form['instance_settings']['label_element'] = array( + '#title' => t('Label element'), + '#type' => 'textfield', + '#default_value' => isset($group->format_settings['instance_settings']['label_element']) ? $group->format_settings['instance_settings']['label_element'] : $formatter['instance_settings']['label_element'], + '#weight' => 3, + ); + $form['instance_settings']['attributes'] = array( '#title' => t('Attributes'), '#type' => 'textfield', @@ -533,7 +549,7 @@ function field_group_field_group_format_settings($group) { '#type' => 'select', '#options' => array('none' => t('None'), 'blind' => t('Blind')), '#default_value' => isset($group->format_settings['instance_settings']['effect']) ? $group->format_settings['instance_settings']['effect'] : $formatter['instance_settings']['effect'], - '#weight' => 2, + '#weight' => 3, ); $form['instance_settings']['speed'] = array( '#title' => t('Speed'), @@ -617,7 +633,7 @@ function field_group_pre_render_prepare(&$group) { $classes = _field_group_get_html_classes($group); $group->classes = implode(' ', $classes->required); - $group->description = isset($group->format_settings['instance_settings']['description']) ? filter_xss_admin(t($group->format_settings['instance_settings']['description'])) : ''; + $group->description = !empty($group->format_settings['instance_settings']['description']) ? filter_xss_admin(t($group->format_settings['instance_settings']['description'])) : ''; } @@ -627,7 +643,7 @@ function field_group_pre_render_prepare(&$group) { * @param Array $elements by address. * @param Object $group The Field group info. */ -function field_group_field_group_pre_render(& $element, &$group, & $form) { +function field_group_field_group_pre_render(&$element, &$group, & $form) { field_group_pre_render_prepare($group); @@ -640,10 +656,7 @@ function field_group_field_group_pre_render(& $element, &$group, & $form) { ); if (isset($group->format_settings['instance_settings']['id']) && !empty($group->format_settings['instance_settings']['id'])) { - $element['#id'] = $group->format_settings['instance_settings']['id']; - } - else { - $element['#id'] = $form['#entity_type'] . '_' . $form['#bundle'] . '_' . $view_mode . '_' . $group->group_name; + $element['#id'] = drupal_html_id($group->format_settings['instance_settings']['id']); } $element['#weight'] = $group->weight; @@ -691,6 +704,8 @@ function field_group_pre_render_fieldset(&$element, $group, &$form) { */ function field_group_pre_render_html_element(&$element, $group, &$form) { $html_element = isset($group->format_settings['instance_settings']['element']) ? $group->format_settings['instance_settings']['element'] : 'div'; + $show_label = isset($group->format_settings['instance_settings']['show_label']) ? $group->format_settings['instance_settings']['show_label'] : 0; + $label_element = isset($group->format_settings['instance_settings']['label_element']) ? $group->format_settings['instance_settings']['label_element'] : 'div'; $attributes = isset($group->format_settings['instance_settings']['attributes']) ? ' ' . $group->format_settings['instance_settings']['attributes'] : ''; $group->classes = trim($group->classes); @@ -715,6 +730,9 @@ function field_group_pre_render_html_element(&$element, $group, &$form) { $attributes = drupal_attributes($element_attributes); $element['#prefix'] = '<' . $html_element . $attributes . '>'; + if ($show_label) { + $element['#prefix'] .= '<' . $label_element . '>' . check_plain(t($group->label)) . '' . $label_element . '>'; + } $element['#suffix'] = '' . $html_element . '>'; } @@ -733,18 +751,19 @@ function field_group_pre_render_div(&$element, $group, &$form) { $effect = isset($group->format_settings['instance_settings']['effect']) ? $group->format_settings['instance_settings']['effect'] : 'none'; $element['#type'] = 'markup'; + $id = isset($element['#id']) ? ' id="' . $element['#id'] . '"' : ''; + if ($group->format_settings['formatter'] != 'open') { - $element['#prefix'] = '