updated core

core/modules/aggregator/aggregator.info.yml

@@ -9,8 +9,8 @@ dependencies:
   - file
   - options
 
-# Information added by Drupal.org packaging script on 2017-11-03
-version: '8.4.2'
+# Information added by Drupal.org packaging script on 2018-01-03
+version: '8.4.4'
 core: '8.x'
 project: 'drupal'
-datestamp: 1509719929
+datestamp: 1515021228

core/modules/aggregator/aggregator.install

@@ -40,3 +40,13 @@ function aggregator_update_8200() {
   $field_definition->setRequired(TRUE);
   $definition_update_manager->updateFieldStorageDefinition($field_definition);
 }
+
+/**
+ * Add a default value for the 'Refresh' field for aggregator feed entities.
+ */
+function aggregator_update_8501() {
+  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();
+  $field_definition = $definition_update_manager->getFieldStorageDefinition('refresh', 'aggregator_feed');
+  $field_definition->setDefaultValue(3600);
+  $definition_update_manager->updateFieldStorageDefinition($field_definition);
+}

core/modules/aggregator/src/Controller/AggregatorController.php

@@ -47,10 +47,7 @@ class AggregatorController extends ControllerBase {
    *   A form array as expected by drupal_render().
    */
   public function feedAdd() {
-    $feed = $this->entityManager()->getStorage('aggregator_feed')
-      ->create([
-        'refresh' => 3600,
-      ]);
+    $feed = $this->entityManager()->getStorage('aggregator_feed')->create();
     return $this->entityFormBuilder()->getForm($feed);
   }
 

core/modules/aggregator/src/Entity/Feed.php

@@ -168,6 +168,7 @@ class Feed extends ContentEntityBase implements FeedInterface {
     $fields['refresh'] = BaseFieldDefinition::create('list_integer')
       ->setLabel(t('Update interval'))
       ->setDescription(t('The length of time between feed updates. Requires a correctly configured cron maintenance task.'))
+      ->setDefaultValue(3600)
       ->setSetting('unsigned', TRUE)
       ->setRequired(TRUE)
       ->setSetting('allowed_values', $period)

core/modules/aggregator/src/Tests/AddFeedTest.php

@@ -1,95 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Add feed test.
- *
- * @group aggregator
- */
-class AddFeedTest extends AggregatorTestBase {
-
-  protected function setUp() {
-    parent::setUp();
-
-    $this->drupalPlaceBlock('page_title_block');
-  }
-
-  /**
-   * Creates and ensures that a feed is unique, checks source, and deletes feed.
-   */
-  public function testAddFeed() {
-    $feed = $this->createFeed();
-    $feed->refreshItems();
-
-    // Check feed data.
-    $this->assertUrl(\Drupal::url('aggregator.feed_add', [], ['absolute' => TRUE]), [], 'Directed to correct URL.');
-    $this->assertTrue($this->uniqueFeed($feed->label(), $feed->getUrl()), 'The feed is unique.');
-
-    // Check feed source.
-    $this->drupalGet('aggregator/sources/' . $feed->id());
-    $this->assertResponse(200, 'Feed source exists.');
-    $this->assertText($feed->label(), 'Page title');
-    $this->assertRaw($feed->getWebsiteUrl());
-
-    // Try to add a duplicate.
-    $edit = [
-      'title[0][value]' => $feed->label(),
-      'url[0][value]' => $feed->getUrl(),
-      'refresh' => '900',
-    ];
-    $this->drupalPostForm('aggregator/sources/add', $edit, t('Save'));
-    $this->assertRaw(t('A feed named %feed already exists. Enter a unique title.', array('%feed' => $feed->label())));
-    $this->assertRaw(t('A feed with this URL %url already exists. Enter a unique URL.', array('%url' => $feed->getUrl())));
-
-    // Delete feed.
-    $this->deleteFeed($feed);
-  }
-
-  /**
-   * Ensures that the feed label is escaping when rendering the feed icon.
-   */
-  public function testFeedLabelEscaping() {
-    $feed = $this->createFeed(NULL, ['title[0][value]' => 'Test feed title <script>alert(123);</script>']);
-    $this->checkForMetaRefresh();
-
-    $this->drupalGet('aggregator/sources/' . $feed->id());
-    $this->assertResponse(200);
-
-    $this->assertEscaped('Test feed title <script>alert(123);</script>');
-    $this->assertNoRaw('Test feed title <script>alert(123);</script>');
-
-    // Ensure the feed icon title is escaped.
-    $this->assertTrue(strpos(str_replace(["\n", "\r"], '', $this->getRawContent()), 'class="feed-icon">  Subscribe to Test feed title &lt;script&gt;alert(123);&lt;/script&gt; feed</a>') !== FALSE);
-  }
-
-  /**
-   * Tests feeds with very long URLs.
-   */
-  public function testAddLongFeed() {
-    // Create a feed with a URL of > 255 characters.
-    $long_url = "https://www.google.com/search?ix=heb&sourceid=chrome&ie=UTF-8&q=angie+byron#sclient=psy-ab&hl=en&safe=off&source=hp&q=angie+byron&pbx=1&oq=angie+byron&aq=f&aqi=&aql=&gs_sm=3&gs_upl=0l0l0l10534l0l0l0l0l0l0l0l0ll0l0&bav=on.2,or.r_gc.r_pw.r_cp.,cf.osb&fp=a70b6b1f0abe28d8&biw=1629&bih=889&ix=heb";
-    $feed = $this->createFeed($long_url);
-    $feed->refreshItems();
-
-    // Create a second feed of > 255 characters, where the only difference is
-    // after the 255th character.
-    $long_url_2 = "https://www.google.com/search?ix=heb&sourceid=chrome&ie=UTF-8&q=angie+byron#sclient=psy-ab&hl=en&safe=off&source=hp&q=angie+byron&pbx=1&oq=angie+byron&aq=f&aqi=&aql=&gs_sm=3&gs_upl=0l0l0l10534l0l0l0l0l0l0l0l0ll0l0&bav=on.2,or.r_gc.r_pw.r_cp.,cf.osb&fp=a70b6b1f0abe28d8&biw=1629&bih=889";
-    $feed_2 = $this->createFeed($long_url_2);
-    $feed->refreshItems();
-
-    // Check feed data.
-    $this->assertTrue($this->uniqueFeed($feed->label(), $feed->getUrl()), 'The first long URL feed is unique.');
-    $this->assertTrue($this->uniqueFeed($feed_2->label(), $feed_2->getUrl()), 'The second long URL feed is unique.');
-
-    // Check feed source.
-    $this->drupalGet('aggregator/sources/' . $feed->id());
-    $this->assertResponse(200, 'Long URL feed source exists.');
-    $this->assertText($feed->label(), 'Page title');
-
-    // Delete feeds.
-    $this->deleteFeed($feed);
-    $this->deleteFeed($feed_2);
-  }
-
-}

core/modules/aggregator/src/Tests/AggregatorAdminTest.php

@@ -1,84 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Tests aggregator admin pages.
- *
- * @group aggregator
- */
-class AggregatorAdminTest extends AggregatorTestBase {
-
-  /**
-   * Tests the settings form to ensure the correct default values are used.
-   */
-  public function testSettingsPage() {
-    $this->drupalGet('admin/config');
-    $this->clickLink('Feed aggregator');
-    $this->clickLink('Settings');
-    // Make sure that test plugins are present.
-    $this->assertText('Test fetcher');
-    $this->assertText('Test parser');
-    $this->assertText('Test processor');
-
-    // Set new values and enable test plugins.
-    $edit = array(
-      'aggregator_allowed_html_tags' => '<a>',
-      'aggregator_summary_items' => 10,
-      'aggregator_clear' => 3600,
-      'aggregator_teaser_length' => 200,
-      'aggregator_fetcher' => 'aggregator_test_fetcher',
-      'aggregator_parser' => 'aggregator_test_parser',
-      'aggregator_processors[aggregator_test_processor]' => 'aggregator_test_processor',
-    );
-    $this->drupalPostForm('admin/config/services/aggregator/settings', $edit, t('Save configuration'));
-    $this->assertText(t('The configuration options have been saved.'));
-
-    foreach ($edit as $name => $value) {
-      $this->assertFieldByName($name, $value, format_string('"@name" has correct default value.', array('@name' => $name)));
-    }
-
-    // Check for our test processor settings form.
-    $this->assertText(t('Dummy length setting'));
-    // Change its value to ensure that settingsSubmit is called.
-    $edit = array(
-      'dummy_length' => 100,
-    );
-    $this->drupalPostForm('admin/config/services/aggregator/settings', $edit, t('Save configuration'));
-    $this->assertText(t('The configuration options have been saved.'));
-    $this->assertFieldByName('dummy_length', 100, '"dummy_length" has correct default value.');
-
-    // Make sure settings form is still accessible even after uninstalling a module
-    // that provides the selected plugins.
-    $this->container->get('module_installer')->uninstall(array('aggregator_test'));
-    $this->resetAll();
-    $this->drupalGet('admin/config/services/aggregator/settings');
-    $this->assertResponse(200);
-  }
-
-  /**
-   * Tests the overview page.
-   */
-  function testOverviewPage() {
-    $feed = $this->createFeed($this->getRSS091Sample());
-    $this->drupalGet('admin/config/services/aggregator');
-
-    $result = $this->xpath('//table/tbody/tr');
-    // Check if the amount of feeds in the overview matches the amount created.
-    $this->assertEqual(1, count($result), 'Created feed is found in the overview');
-    // Check if the fields in the table match with what's expected.
-    $this->assertEqual($feed->label(), (string) $result[0]->td[0]->a);
-    $count = $this->container->get('entity.manager')->getStorage('aggregator_item')->getItemCount($feed);
-    $this->assertEqual(\Drupal::translation()->formatPlural($count, '1 item', '@count items'), (string) $result[0]->td[1]);
-
-    // Update the items of the first feed.
-    $feed->refreshItems();
-    $this->drupalGet('admin/config/services/aggregator');
-    $result = $this->xpath('//table/tbody/tr');
-    // Check if the fields in the table match with what's expected.
-    $this->assertEqual($feed->label(), (string) $result[0]->td[0]->a);
-    $count = $this->container->get('entity.manager')->getStorage('aggregator_item')->getItemCount($feed);
-    $this->assertEqual(\Drupal::translation()->formatPlural($count, '1 item', '@count items'), (string) $result[0]->td[1]);
-  }
-
-}

core/modules/aggregator/src/Tests/AggregatorCronTest.php

@@ -1,45 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Update feeds on cron.
- *
- * @group aggregator
- */
-class AggregatorCronTest extends AggregatorTestBase {
-  /**
-   * Adds feeds and updates them via cron process.
-   */
-  public function testCron() {
-    // Create feed and test basic updating on cron.
-    $this->createSampleNodes();
-    $feed = $this->createFeed();
-    $this->cronRun();
-    $this->assertEqual(5, db_query('SELECT COUNT(*) FROM {aggregator_item} WHERE fid = :fid', array(':fid' => $feed->id()))->fetchField());
-    $this->deleteFeedItems($feed);
-    $this->assertEqual(0, db_query('SELECT COUNT(*) FROM {aggregator_item} WHERE fid = :fid', array(':fid' => $feed->id()))->fetchField());
-    $this->cronRun();
-    $this->assertEqual(5, db_query('SELECT COUNT(*) FROM {aggregator_item} WHERE fid = :fid', array(':fid' => $feed->id()))->fetchField());
-
-    // Test feed locking when queued for update.
-    $this->deleteFeedItems($feed);
-    db_update('aggregator_feed')
-      ->condition('fid', $feed->id())
-      ->fields(array(
-        'queued' => REQUEST_TIME,
-      ))
-      ->execute();
-    $this->cronRun();
-    $this->assertEqual(0, db_query('SELECT COUNT(*) FROM {aggregator_item} WHERE fid = :fid', array(':fid' => $feed->id()))->fetchField());
-    db_update('aggregator_feed')
-      ->condition('fid', $feed->id())
-      ->fields(array(
-        'queued' => 0,
-      ))
-      ->execute();
-    $this->cronRun();
-    $this->assertEqual(5, db_query('SELECT COUNT(*) FROM {aggregator_item} WHERE fid = :fid', array(':fid' => $feed->id()))->fetchField());
-  }
-
-}

core/modules/aggregator/src/Tests/AggregatorRenderingTest.php

@@ -1,149 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-use Drupal\Component\Utility\SafeMarkup;
-
-/**
- * Tests display of aggregator items on the page.
- *
- * @group aggregator
- */
-class AggregatorRenderingTest extends AggregatorTestBase {
-
-  /**
-   * Modules to install.
-   *
-   * @var array
-   */
-  public static $modules = array('block', 'test_page_test');
-
-  protected function setUp() {
-    parent::setUp();
-
-    $this->drupalPlaceBlock('page_title_block');
-  }
-
-  /**
-   * Adds a feed block to the page and checks its links.
-   */
-  public function testBlockLinks() {
-    // Create feed.
-    $this->createSampleNodes();
-    $feed = $this->createFeed();
-    $this->updateFeedItems($feed, $this->getDefaultFeedItemCount());
-
-    // Need admin user to be able to access block admin.
-    $admin_user = $this->drupalCreateUser(array(
-      'administer blocks',
-      'access administration pages',
-      'administer news feeds',
-      'access news feeds',
-    ));
-    $this->drupalLogin($admin_user);
-
-    $block = $this->drupalPlaceBlock("aggregator_feed_block", array('label' => 'feed-' . $feed->label()));
-
-    // Configure the feed that should be displayed.
-    $block->getPlugin()->setConfigurationValue('feed', $feed->id());
-    $block->getPlugin()->setConfigurationValue('block_count', 2);
-    $block->save();
-
-    // Confirm that the block is now being displayed on pages.
-    $this->drupalGet('test-page');
-    $this->assertText($block->label(), 'Feed block is displayed on the page.');
-
-    // Confirm items appear as links.
-    $items = $this->container->get('entity.manager')->getStorage('aggregator_item')->loadByFeed($feed->id(), 1);
-    $links = $this->xpath('//a[@href = :href]', array(':href' => reset($items)->getLink()));
-    $this->assert(isset($links[0]), 'Item link found.');
-
-    // Find the expected read_more link.
-    $href = $feed->url();
-    $links = $this->xpath('//a[@href = :href]', array(':href' => $href));
-    $this->assert(isset($links[0]), format_string('Link to href %href found.', array('%href' => $href)));
-    $cache_tags_header = $this->drupalGetHeader('X-Drupal-Cache-Tags');
-    $cache_tags = explode(' ', $cache_tags_header);
-    $this->assertTrue(in_array('aggregator_feed:' . $feed->id(), $cache_tags));
-
-    // Visit that page.
-    $this->drupalGet($feed->urlInfo()->getInternalPath());
-    $correct_titles = $this->xpath('//h1[normalize-space(text())=:title]', array(':title' => $feed->label()));
-    $this->assertFalse(empty($correct_titles), 'Aggregator feed page is available and has the correct title.');
-    $cache_tags = explode(' ', $this->drupalGetHeader('X-Drupal-Cache-Tags'));
-    $this->assertTrue(in_array('aggregator_feed:' . $feed->id(), $cache_tags));
-    $this->assertTrue(in_array('aggregator_feed_view', $cache_tags));
-    $this->assertTrue(in_array('aggregator_item_view', $cache_tags));
-
-    // Set the number of news items to 0 to test that the block does not show
-    // up.
-    $block->getPlugin()->setConfigurationValue('block_count', 0);
-    $block->save();
-    // Check that the block is no longer displayed.
-    $this->drupalGet('test-page');
-    $this->assertNoText($block->label(), 'Feed block is not displayed on the page when number of items is set to 0.');
-  }
-
-  /**
-   * Creates a feed and checks that feed's page.
-   */
-  public function testFeedPage() {
-    // Increase the number of items published in the rss.xml feed so we have
-    // enough articles to test paging.
-    $view = entity_load('view', 'frontpage');
-    $display = &$view->getDisplay('feed_1');
-    $display['display_options']['pager']['options']['items_per_page'] = 30;
-    $view->save();
-
-    // Create a feed with 30 items.
-    $this->createSampleNodes(30);
-    $feed = $this->createFeed();
-    $this->updateFeedItems($feed, 30);
-
-    // Check for presence of an aggregator pager.
-    $this->drupalGet('aggregator');
-    $elements = $this->xpath("//ul[contains(@class, :class)]", array(':class' => 'pager__items'));
-    $this->assertTrue(!empty($elements), 'Individual source page contains a pager.');
-
-    // Check for sources page title.
-    $this->drupalGet('aggregator/sources');
-    $titles = $this->xpath('//h1[normalize-space(text())=:title]', array(':title' => 'Sources'));
-    $this->assertTrue(!empty($titles), 'Source page contains correct title.');
-
-    // Find the expected read_more link on the sources page.
-    $href = $feed->url();
-    $links = $this->xpath('//a[@href = :href]', array(':href' => $href));
-    $this->assertTrue(isset($links[0]), SafeMarkup::format('Link to href %href found.', array('%href' => $href)));
-    $cache_tags_header = $this->drupalGetHeader('X-Drupal-Cache-Tags');
-    $cache_tags = explode(' ', $cache_tags_header);
-    $this->assertTrue(in_array('aggregator_feed:' . $feed->id(), $cache_tags));
-
-    // Check the rss aggregator page as anonymous user.
-    $this->drupalLogout();
-    $this->drupalGet('aggregator/rss');
-    $this->assertResponse(403);
-
-    // Check the rss aggregator page as admin.
-    $this->drupalLogin($this->adminUser);
-    $this->drupalGet('aggregator/rss');
-    $this->assertResponse(200);
-    $this->assertEqual($this->drupalGetHeader('Content-type'), 'application/rss+xml; charset=utf-8');
-
-    // Check the opml aggregator page.
-    $this->drupalGet('aggregator/opml');
-    $outline = $this->xpath('//outline[1]');
-    $this->assertEqual($outline[0]['type'], 'rss', 'The correct type attribute is used for rss OPML.');
-    $this->assertEqual($outline[0]['text'], $feed->label(), 'The correct text attribute is used for rss OPML.');
-    $this->assertEqual($outline[0]['xmlurl'], $feed->getUrl(), 'The correct xmlUrl attribute is used for rss OPML.');
-
-    // Check for the presence of a pager.
-    $this->drupalGet('aggregator/sources/' . $feed->id());
-    $elements = $this->xpath("//ul[contains(@class, :class)]", array(':class' => 'pager__items'));
-    $this->assertTrue(!empty($elements), 'Individual source page contains a pager.');
-    $cache_tags = explode(' ', $this->drupalGetHeader('X-Drupal-Cache-Tags'));
-    $this->assertTrue(in_array('aggregator_feed:' . $feed->id(), $cache_tags));
-    $this->assertTrue(in_array('aggregator_feed_view', $cache_tags));
-    $this->assertTrue(in_array('aggregator_item_view', $cache_tags));
-  }
-
-}

core/modules/aggregator/src/Tests/DeleteFeedItemTest.php

@@ -1,40 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Delete feed items from a feed.
- *
- * @group aggregator
- */
-class DeleteFeedItemTest extends AggregatorTestBase {
-  /**
-   * Tests running "delete items" from 'admin/config/services/aggregator' page.
-   */
-  public function testDeleteFeedItem() {
-    // Create a bunch of test feeds.
-    $feed_urls = array();
-    // No last-modified, no etag.
-    $feed_urls[] = \Drupal::url('aggregator_test.feed', array(), array('absolute' => TRUE));
-    // Last-modified, but no etag.
-    $feed_urls[] = \Drupal::url('aggregator_test.feed', array('use_last_modified' => 1), array('absolute' => TRUE));
-    // No Last-modified, but etag.
-    $feed_urls[] = \Drupal::url('aggregator_test.feed', array('use_last_modified' => 0, 'use_etag' => 1), array('absolute' => TRUE));
-    // Last-modified and etag.
-    $feed_urls[] = \Drupal::url('aggregator_test.feed', array('use_last_modified' => 1, 'use_etag' => 1), array('absolute' => TRUE));
-
-    foreach ($feed_urls as $feed_url) {
-      $feed = $this->createFeed($feed_url);
-      // Update and delete items two times in a row to make sure that removal
-      // resets all 'modified' information (modified, etag, hash) and allows for
-      // immediate update. There's 8 items in the feed, but one has an empty
-      // title and is skipped.
-      $this->updateAndDelete($feed, 7);
-      $this->updateAndDelete($feed, 7);
-      $this->updateAndDelete($feed, 7);
-      // Delete feed.
-      $this->deleteFeed($feed);
-    }
-  }
-
-}

core/modules/aggregator/src/Tests/DeleteFeedTest.php

@@ -1,50 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Delete feed test.
- *
- * @group aggregator
- */
-class DeleteFeedTest extends AggregatorTestBase {
-
-  /**
-   * Modules to install.
-   *
-   * @var array
-   */
-  public static $modules = array('block');
-
-  /**
-   * Deletes a feed and ensures that all of its services are deleted.
-   */
-  public function testDeleteFeed() {
-    $feed1 = $this->createFeed();
-    $feed2 = $this->createFeed();
-
-    // Place a block for both feeds.
-    $block = $this->drupalPlaceBlock('aggregator_feed_block');
-    $block->getPlugin()->setConfigurationValue('feed', $feed1->id());
-    $block->save();
-    $block2 = $this->drupalPlaceBlock('aggregator_feed_block');
-    $block2->getPlugin()->setConfigurationValue('feed', $feed2->id());
-    $block2->save();
-
-    // Delete feed.
-    $this->deleteFeed($feed1);
-    $this->assertText($feed2->label());
-    $block_storage = $this->container->get('entity.manager')->getStorage('block');
-    $this->assertNull($block_storage->load($block->id()), 'Block for the deleted feed was deleted.');
-    $this->assertEqual($block2->id(), $block_storage->load($block2->id())->id(), 'Block for not deleted feed still exists.');
-
-    // Check feed source.
-    $this->drupalGet('aggregator/sources/' . $feed1->id());
-    $this->assertResponse(404, 'Deleted feed source does not exists.');
-
-    // Check database for feed.
-    $result = db_query("SELECT COUNT(*) FROM {aggregator_feed} WHERE title = :title AND url = :url", array(':title' => $feed1->label(), ':url' => $feed1->getUrl()))->fetchField();
-    $this->assertFalse($result, 'Feed not found in database');
-  }
-
-}

core/modules/aggregator/src/Tests/FeedAdminDisplayTest.php

@@ -1,63 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Tests the display of a feed on the feed aggregator list page.
- *
- * @group aggregator
- */
-class FeedAdminDisplayTest extends AggregatorTestBase {
-
-  /**
-   * Tests the "Next update" and "Last update" fields.
-   */
-  public function testFeedUpdateFields() {
-    // Create scheduled feed.
-    $scheduled_feed = $this->createFeed(NULL, array('refresh' => '900'));
-
-    $this->drupalGet('admin/config/services/aggregator');
-    $this->assertResponse(200, 'Aggregator feed overview page exists.');
-
-    // The scheduled feed shows that it has not been updated yet and is
-    // scheduled.
-    $this->assertText('never', 'The scheduled feed has not been updated yet.  Last update shows "never".');
-    $this->assertText('imminently', 'The scheduled feed has not been updated yet. Next update shows "imminently".');
-    $this->assertNoText('ago', 'The scheduled feed has not been updated yet.  Last update does not show "x x ago".');
-    $this->assertNoText('left', 'The scheduled feed has not been updated yet.  Next update does not show "x x left".');
-
-    $this->updateFeedItems($scheduled_feed);
-    $this->drupalGet('admin/config/services/aggregator');
-
-    // After the update, an interval should be displayed on both last updated
-    // and next update.
-    $this->assertNoText('never', 'The scheduled feed has been updated. Last updated changed.');
-    $this->assertNoText('imminently', 'The scheduled feed has been updated. Next update changed.');
-    $this->assertText('ago', 'The scheduled feed been updated.  Last update shows "x x ago".');
-    $this->assertText('left', 'The scheduled feed has been updated. Next update shows "x x left".');
-
-    // Delete scheduled feed.
-    $this->deleteFeed($scheduled_feed);
-
-    // Create non-scheduled feed.
-    $non_scheduled_feed = $this->createFeed(NULL, array('refresh' => '0'));
-
-    $this->drupalGet('admin/config/services/aggregator');
-    // The non scheduled feed shows that it has not been updated yet.
-    $this->assertText('never', 'The non scheduled feed has not been updated yet.  Last update shows "never".');
-    $this->assertNoText('imminently', 'The non scheduled feed does not show "imminently" as next update.');
-    $this->assertNoText('ago', 'The non scheduled feed has not been updated. It does not show "x x ago" as last update.');
-    $this->assertNoText('left', 'The feed is not scheduled. It does not show a timeframe "x x left" for next update.');
-
-    $this->updateFeedItems($non_scheduled_feed);
-    $this->drupalGet('admin/config/services/aggregator');
-
-    // After the feed update, we still need to see "never" as next update label.
-    // Last update will show an interval.
-    $this->assertNoText('imminently', 'The updated non scheduled feed does not show "imminently" as next update.');
-    $this->assertText('never', 'The updated non scheduled feed still shows "never" as next update.');
-    $this->assertText('ago', 'The non scheduled feed has been updated. It shows "x x ago" as last update.');
-    $this->assertNoText('left', 'The feed is not scheduled. It does not show a timeframe "x x left" for next update.');
-  }
-
-}

core/modules/aggregator/src/Tests/FeedCacheTagsTest.php

@@ -1,52 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-use Drupal\aggregator\Entity\Feed;
-use Drupal\system\Tests\Entity\EntityWithUriCacheTagsTestBase;
-use Drupal\user\Entity\Role;
-use Drupal\user\RoleInterface;
-
-/**
- * Tests the Feed entity's cache tags.
- *
- * @group aggregator
- */
-class FeedCacheTagsTest extends EntityWithUriCacheTagsTestBase {
-
-  /**
-   * {@inheritdoc}
-   */
-  public static $modules = array('aggregator');
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    parent::setUp();
-
-    // Give anonymous users permission to access feeds, so that we can verify
-    // the cache tags of cached versions of feeds.
-    $user_role = Role::load(RoleInterface::ANONYMOUS_ID);
-    $user_role->grantPermission('access news feeds');
-    $user_role->save();
-  }
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function createEntity() {
-    // Create a "Llama" feed.
-    $feed = Feed::create(array(
-      'title' => 'Llama',
-      'url' => 'https://www.drupal.org/',
-      'refresh' => 900,
-      'checked' => 1389919932,
-      'description' => 'Drupal.org',
-    ));
-    $feed->save();
-
-    return $feed;
-  }
-
-}

core/modules/aggregator/src/Tests/FeedFetcherPluginTest.php

@@ -1,44 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Tests the fetcher plugins functionality and discoverability.
- *
- * @group aggregator
- *
- * @see \Drupal\aggregator_test\Plugin\aggregator\fetcher\TestFetcher.
- */
-class FeedFetcherPluginTest extends AggregatorTestBase {
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    parent::setUp();
-    // Enable test plugins.
-    $this->enableTestPlugins();
-    // Create some nodes.
-    $this->createSampleNodes();
-  }
-
-  /**
-   * Test fetching functionality.
-   */
-  public function testfetch() {
-    // Create feed with local url.
-    $feed = $this->createFeed();
-    $this->updateFeedItems($feed);
-    $this->assertFalse(empty($feed->items));
-
-    // Delete items and restore checked property to 0.
-    $this->deleteFeedItems($feed);
-    // Change its name and try again.
-    $feed->setTitle('Do not fetch');
-    $feed->save();
-    $this->updateFeedItems($feed);
-    // Fetch should fail due to feed name.
-    $this->assertTrue(empty($feed->items));
-  }
-
-}

core/modules/aggregator/src/Tests/FeedLanguageTest.php

@@ -1,85 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-use Drupal\language\Entity\ConfigurableLanguage;
-
-/**
- * Tests aggregator feeds in multiple languages.
- *
- * @group aggregator
- */
-class FeedLanguageTest extends AggregatorTestBase {
-
-  /**
-   * Modules to install.
-   *
-   * @var array
-   */
-  public static $modules = array('language');
-
-  /**
-   * List of langcodes.
-   *
-   * @var string[]
-   */
-  protected $langcodes = array();
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    parent::setUp();
-
-    // Create test languages.
-    $this->langcodes = array(ConfigurableLanguage::load('en'));
-    for ($i = 1; $i < 3; ++$i) {
-      $language = ConfigurableLanguage::create(array(
-        'id' => 'l' . $i,
-        'label' => $this->randomString(),
-      ));
-      $language->save();
-      $this->langcodes[$i] = $language->id();
-    }
-  }
-
-  /**
-   * Tests creation of feeds with a language.
-   */
-  public function testFeedLanguage() {
-    $admin_user = $this->drupalCreateUser(['administer languages', 'access administration pages', 'administer news feeds', 'access news feeds', 'create article content']);
-    $this->drupalLogin($admin_user);
-
-    // Enable language selection for feeds.
-    $edit['entity_types[aggregator_feed]'] = TRUE;
-    $edit['settings[aggregator_feed][aggregator_feed][settings][language][language_alterable]'] = TRUE;
-
-    $this->drupalPostForm('admin/config/regional/content-language', $edit, t('Save configuration'));
-
-    /** @var \Drupal\aggregator\FeedInterface[] $feeds */
-    $feeds = array();
-    // Create feeds.
-    $feeds[1] = $this->createFeed(NULL, array('langcode[0][value]' => $this->langcodes[1]));
-    $feeds[2] = $this->createFeed(NULL, array('langcode[0][value]' => $this->langcodes[2]));
-
-    // Make sure that the language has been assigned.
-    $this->assertEqual($feeds[1]->language()->getId(), $this->langcodes[1]);
-    $this->assertEqual($feeds[2]->language()->getId(), $this->langcodes[2]);
-
-    // Create example nodes to create feed items from and then update the feeds.
-    $this->createSampleNodes();
-    $this->cronRun();
-
-    // Loop over the created feed items and verify that their language matches
-    // the one from the feed.
-    foreach ($feeds as $feed) {
-      /** @var \Drupal\aggregator\ItemInterface[] $items */
-      $items = entity_load_multiple_by_properties('aggregator_item', array('fid' => $feed->id()));
-      $this->assertTrue(count($items) > 0, 'Feed items were created.');
-      foreach ($items as $item) {
-        $this->assertEqual($item->language()->getId(), $feed->language()->getId());
-      }
-    }
-  }
-
-}

core/modules/aggregator/src/Tests/FeedParserTest.php

@@ -1,111 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-use Drupal\Core\Url;
-use Drupal\aggregator\Entity\Feed;
-
-/**
- * Tests the built-in feed parser with valid feed samples.
- *
- * @group aggregator
- */
-class FeedParserTest extends AggregatorTestBase {
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    parent::setUp();
-    // Do not delete old aggregator items during these tests, since our sample
-    // feeds have hardcoded dates in them (which may be expired when this test
-    // is run).
-    $this->config('aggregator.settings')->set('items.expire', AGGREGATOR_CLEAR_NEVER)->save();
-  }
-
-  /**
-   * Tests a feed that uses the RSS 0.91 format.
-   */
-  public function testRSS091Sample() {
-    $feed = $this->createFeed($this->getRSS091Sample());
-    $feed->refreshItems();
-    $this->drupalGet('aggregator/sources/' . $feed->id());
-    $this->assertResponse(200, format_string('Feed %name exists.', array('%name' => $feed->label())));
-    $this->assertText('First example feed item title');
-    $this->assertLinkByHref('http://example.com/example-turns-one');
-    $this->assertText('First example feed item description.');
-    $this->assertRaw('<img src="http://example.com/images/druplicon.png"');
-
-    // Several additional items that include elements over 255 characters.
-    $this->assertRaw("Second example feed item title.");
-    $this->assertText('Long link feed item title');
-    $this->assertText('Long link feed item description');
-    $this->assertLinkByHref('http://example.com/tomorrow/and/tomorrow/and/tomorrow/creeps/in/this/petty/pace/from/day/to/day/to/the/last/syllable/of/recorded/time/and/all/our/yesterdays/have/lighted/fools/the/way/to/dusty/death/out/out/brief/candle/life/is/but/a/walking/shadow/a/poor/player/that/struts/and/frets/his/hour/upon/the/stage/and/is/heard/no/more/it/is/a/tale/told/by/an/idiot/full/of/sound/and/fury/signifying/nothing');
-    $this->assertText('Long author feed item title');
-    $this->assertText('Long author feed item description');
-    $this->assertLinkByHref('http://example.com/long/author');
-  }
-
-  /**
-   * Tests a feed that uses the Atom format.
-   */
-  public function testAtomSample() {
-    $feed = $this->createFeed($this->getAtomSample());
-    $feed->refreshItems();
-    $this->drupalGet('aggregator/sources/' . $feed->id());
-    $this->assertResponse(200, format_string('Feed %name exists.', array('%name' => $feed->label())));
-    $this->assertText('Atom-Powered Robots Run Amok');
-    $this->assertLinkByHref('http://example.org/2003/12/13/atom03');
-    $this->assertText('Some text.');
-    $this->assertEqual('urn:uuid:1225c695-cfb8-4ebb-aaaa-80da344efa6a', db_query('SELECT guid FROM {aggregator_item} WHERE link = :link', array(':link' => 'http://example.org/2003/12/13/atom03'))->fetchField(), 'Atom entry id element is parsed correctly.');
-
-    // Check for second feed entry.
-    $this->assertText('We tried to stop them, but we failed.');
-    $this->assertLinkByHref('http://example.org/2003/12/14/atom03');
-    $this->assertText('Some other text.');
-    $db_guid = db_query('SELECT guid FROM {aggregator_item} WHERE link = :link', array(
-      ':link' => 'http://example.org/2003/12/14/atom03',
-    ))->fetchField();
-    $this->assertEqual('urn:uuid:1225c695-cfb8-4ebb-bbbb-80da344efa6a', $db_guid, 'Atom entry id element is parsed correctly.');
-  }
-
-  /**
-   * Tests a feed that uses HTML entities in item titles.
-   */
-  public function testHtmlEntitiesSample() {
-    $feed = $this->createFeed($this->getHtmlEntitiesSample());
-    $feed->refreshItems();
-    $this->drupalGet('aggregator/sources/' . $feed->id());
-    $this->assertResponse(200, format_string('Feed %name exists.', array('%name' => $feed->label())));
-    $this->assertRaw("Quote&quot; Amp&amp;");
-  }
-
-  /**
-   * Tests that a redirected feed is tracked to its target.
-   */
-  public function testRedirectFeed() {
-    $redirect_url = Url::fromRoute('aggregator_test.redirect')->setAbsolute()->toString();
-    $feed = Feed::create(array('url' => $redirect_url, 'title' => $this->randomMachineName()));
-    $feed->save();
-    $feed->refreshItems();
-
-    // Make sure that the feed URL was updated correctly.
-    $this->assertEqual($feed->getUrl(), \Drupal::url('aggregator_test.feed', array(), array('absolute' => TRUE)));
-  }
-
-  /**
-   * Tests error handling when an invalid feed is added.
-   */
-  public function testInvalidFeed() {
-    // Simulate a typo in the URL to force a curl exception.
-    $invalid_url = 'http:/www.drupal.org';
-    $feed = Feed::create(array('url' => $invalid_url, 'title' => $this->randomMachineName()));
-    $feed->save();
-
-    // Update the feed. Use the UI to be able to check the message easily.
-    $this->drupalGet('admin/config/services/aggregator');
-    $this->clickLink(t('Update items'));
-    $this->assertRaw(t('The feed from %title seems to be broken because of error', array('%title' => $feed->label())));
-  }
-
-}

core/modules/aggregator/src/Tests/FeedProcessorPluginTest.php

@@ -1,67 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-use Drupal\aggregator\Entity\Feed;
-use Drupal\aggregator\Entity\Item;
-
-/**
- * Tests the processor plugins functionality and discoverability.
- *
- * @group aggregator
- *
- * @see \Drupal\aggregator_test\Plugin\aggregator\processor\TestProcessor.
- */
-class FeedProcessorPluginTest extends AggregatorTestBase {
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    parent::setUp();
-    // Enable test plugins.
-    $this->enableTestPlugins();
-    // Create some nodes.
-    $this->createSampleNodes();
-  }
-
-  /**
-   * Test processing functionality.
-   */
-  public function testProcess() {
-    $feed = $this->createFeed();
-    $this->updateFeedItems($feed);
-    foreach ($feed->items as $iid) {
-      $item = Item::load($iid);
-      $this->assertTrue(strpos($item->label(), 'testProcessor') === 0);
-    }
-  }
-
-  /**
-   * Test deleting functionality.
-   */
-  public function testDelete() {
-    $feed = $this->createFeed();
-    $description = $feed->description->value ?: '';
-    $this->updateAndDelete($feed, NULL);
-    // Make sure the feed title is changed.
-    $entities = entity_load_multiple_by_properties('aggregator_feed', array('description' => $description));
-    $this->assertTrue(empty($entities));
-  }
-
-  /**
-   * Test post-processing functionality.
-   */
-  public function testPostProcess() {
-    $feed = $this->createFeed(NULL, array('refresh' => 1800));
-    $this->updateFeedItems($feed);
-    $feed_id = $feed->id();
-    // Reset entity cache manually.
-    \Drupal::entityManager()->getStorage('aggregator_feed')->resetCache(array($feed_id));
-    // Reload the feed to get new values.
-    $feed = Feed::load($feed_id);
-    // Make sure its refresh rate doubled.
-    $this->assertEqual($feed->getRefreshRate(), 3600);
-  }
-
-}

core/modules/aggregator/src/Tests/ImportOpmlTest.php

@@ -1,124 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Tests OPML import.
- *
- * @group aggregator
- */
-class ImportOpmlTest extends AggregatorTestBase {
-
-  /**
-   * Modules to install.
-   *
-   * @var array
-   */
-  public static $modules = array('block', 'help');
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    parent::setUp();
-
-    $admin_user = $this->drupalCreateUser(array('administer news feeds', 'access news feeds', 'create article content', 'administer blocks'));
-    $this->drupalLogin($admin_user);
-  }
-
-  /**
-   * Opens OPML import form.
-   */
-  public function openImportForm() {
-    // Enable the help block.
-    $this->drupalPlaceBlock('help_block', array('region' => 'help'));
-
-    $this->drupalGet('admin/config/services/aggregator/add/opml');
-    $this->assertText('A single OPML document may contain many feeds.', 'Found OPML help text.');
-    $this->assertField('files[upload]', 'Found file upload field.');
-    $this->assertField('remote', 'Found Remote URL field.');
-    $this->assertField('refresh', '', 'Found Refresh field.');
-  }
-
-  /**
-   * Submits form filled with invalid fields.
-   */
-  public function validateImportFormFields() {
-    $before = db_query('SELECT COUNT(*) FROM {aggregator_feed}')->fetchField();
-
-    $edit = array();
-    $this->drupalPostForm('admin/config/services/aggregator/add/opml', $edit, t('Import'));
-    $this->assertRaw(t('<em>Either</em> upload a file or enter a URL.'), 'Error if no fields are filled.');
-
-    $path = $this->getEmptyOpml();
-    $edit = array(
-      'files[upload]' => $path,
-      'remote' => file_create_url($path),
-    );
-    $this->drupalPostForm('admin/config/services/aggregator/add/opml', $edit, t('Import'));
-    $this->assertRaw(t('<em>Either</em> upload a file or enter a URL.'), 'Error if both fields are filled.');
-
-    $edit = array('remote' => 'invalidUrl://empty');
-    $this->drupalPostForm('admin/config/services/aggregator/add/opml', $edit, t('Import'));
-    $this->assertText(t('The URL invalidUrl://empty is not valid.'), 'Error if the URL is invalid.');
-
-    $after = db_query('SELECT COUNT(*) FROM {aggregator_feed}')->fetchField();
-    $this->assertEqual($before, $after, 'No feeds were added during the three last form submissions.');
-  }
-
-  /**
-   * Submits form with invalid, empty, and valid OPML files.
-   */
-  protected function submitImportForm() {
-    $before = db_query('SELECT COUNT(*) FROM {aggregator_feed}')->fetchField();
-
-    $form['files[upload]'] = $this->getInvalidOpml();
-    $this->drupalPostForm('admin/config/services/aggregator/add/opml', $form, t('Import'));
-    $this->assertText(t('No new feed has been added.'), 'Attempting to upload invalid XML.');
-
-    $edit = array('remote' => file_create_url($this->getEmptyOpml()));
-    $this->drupalPostForm('admin/config/services/aggregator/add/opml', $edit, t('Import'));
-    $this->assertText(t('No new feed has been added.'), 'Attempting to load empty OPML from remote URL.');
-
-    $after = db_query('SELECT COUNT(*) FROM {aggregator_feed}')->fetchField();
-    $this->assertEqual($before, $after, 'No feeds were added during the two last form submissions.');
-
-    db_delete('aggregator_feed')->execute();
-
-    $feeds[0] = $this->getFeedEditArray();
-    $feeds[1] = $this->getFeedEditArray();
-    $feeds[2] = $this->getFeedEditArray();
-    $edit = array(
-      'files[upload]' => $this->getValidOpml($feeds),
-      'refresh'       => '900',
-    );
-    $this->drupalPostForm('admin/config/services/aggregator/add/opml', $edit, t('Import'));
-    $this->assertRaw(t('A feed with the URL %url already exists.', array('%url' => $feeds[0]['url[0][value]'])), 'Verifying that a duplicate URL was identified');
-    $this->assertRaw(t('A feed named %title already exists.', array('%title' => $feeds[1]['title[0][value]'])), 'Verifying that a duplicate title was identified');
-
-    $after = db_query('SELECT COUNT(*) FROM {aggregator_feed}')->fetchField();
-    $this->assertEqual($after, 2, 'Verifying that two distinct feeds were added.');
-
-    $feeds_from_db = db_query("SELECT title, url, refresh FROM {aggregator_feed}");
-    $refresh = TRUE;
-    foreach ($feeds_from_db as $feed) {
-      $title[$feed->url] = $feed->title;
-      $url[$feed->title] = $feed->url;
-      $refresh = $refresh && $feed->refresh == 900;
-    }
-
-    $this->assertEqual($title[$feeds[0]['url[0][value]']], $feeds[0]['title[0][value]'], 'First feed was added correctly.');
-    $this->assertEqual($url[$feeds[1]['title[0][value]']], $feeds[1]['url[0][value]'], 'Second feed was added correctly.');
-    $this->assertTrue($refresh, 'Refresh times are correct.');
-  }
-
-  /**
-   * Tests the import of an OPML file.
-   */
-  public function testOpmlImport() {
-    $this->openImportForm();
-    $this->validateImportFormFields();
-    $this->submitImportForm();
-  }
-
-}

core/modules/aggregator/src/Tests/ItemCacheTagsTest.php

@@ -1,83 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-use Drupal\aggregator\Entity\Feed;
-use Drupal\aggregator\Entity\Item;
-use Drupal\Core\Cache\CacheBackendInterface;
-use Drupal\system\Tests\Entity\EntityCacheTagsTestBase;
-use Drupal\user\Entity\Role;
-use Drupal\user\RoleInterface;
-
-/**
- * Tests the Item entity's cache tags.
- *
- * @group aggregator
- */
-class ItemCacheTagsTest extends EntityCacheTagsTestBase {
-
-  /**
-   * {@inheritdoc}
-   */
-  public static $modules = array('aggregator');
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    parent::setUp();
-
-    // Give anonymous users permission to access feeds, so that we can verify
-    // the cache tags of cached versions of feed items.
-    $user_role = Role::load(RoleInterface::ANONYMOUS_ID);
-    $user_role->grantPermission('access news feeds');
-    $user_role->save();
-  }
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function createEntity() {
-    // Create a "Camelids" feed.
-    $feed = Feed::create(array(
-      'title' => 'Camelids',
-      'url' => 'https://groups.drupal.org/not_used/167169',
-      'refresh' => 900,
-      'checked' => 1389919932,
-      'description' => 'Drupal Core Group feed',
-    ));
-    $feed->save();
-
-    // Create a "Llama" aggregator feed item.
-    $item = Item::create(array(
-      'fid' => $feed->id(),
-      'title' => t('Llama'),
-      'path' => 'https://www.drupal.org/',
-    ));
-    $item->save();
-
-    return $item;
-  }
-
-  /**
-   * Tests that when creating a feed item, the feed tag is invalidated.
-   */
-  public function testEntityCreation() {
-    // Create a cache entry that is tagged with a feed cache tag.
-    \Drupal::cache('render')->set('foo', 'bar', CacheBackendInterface::CACHE_PERMANENT, $this->entity->getCacheTags());
-
-    // Verify a cache hit.
-    $this->verifyRenderCache('foo', array('aggregator_feed:1'));
-
-    // Now create a feed item in that feed.
-    Item::create(array(
-      'fid' => $this->entity->getFeedId(),
-      'title' => t('Llama 2'),
-      'path' => 'https://groups.drupal.org/',
-    ))->save();
-
-    // Verify a cache miss.
-    $this->assertFalse(\Drupal::cache('render')->get('foo'), 'Creating a new feed item invalidates the cache tag of the feed.');
-  }
-
-}

core/modules/aggregator/src/Tests/Update/AggregatorUpdateTest.php

@@ -1,41 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests\Update;
-
-use Drupal\system\Tests\Update\UpdatePathTestBase;
-
-/**
- * Tests that node settings are properly updated during database updates.
- *
- * @group aggregator
- */
-class AggregatorUpdateTest extends UpdatePathTestBase {
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setDatabaseDumpFiles() {
-    $this->databaseDumpFiles = [
-      __DIR__ . '/../../../../system/tests/fixtures/update/drupal-8.filled.standard.php.gz',
-    ];
-  }
-
-  /**
-   * Tests that the 'Source feed' field is required.
-   *
-   * @see aggregator_update_8200()
-   */
-  public function testSourceFeedRequired() {
-    // Check that the 'fid' field is not required prior to the update.
-    $field_definition = \Drupal::entityDefinitionUpdateManager()->getFieldStorageDefinition('fid', 'aggregator_item');
-    $this->assertFalse($field_definition->isRequired());
-
-    // Run updates.
-    $this->runUpdates();
-
-    // Check that the 'fid' field is now required.
-    $field_definition = \Drupal::entityDefinitionUpdateManager()->getFieldStorageDefinition('fid', 'aggregator_item');
-    $this->assertTrue($field_definition->isRequired());
-  }
-
-}

core/modules/aggregator/src/Tests/UpdateFeedItemTest.php

@@ -1,70 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-use Drupal\aggregator\Entity\Feed;
-
-/**
- * Update feed items from a feed.
- *
- * @group aggregator
- */
-class UpdateFeedItemTest extends AggregatorTestBase {
-  /**
-   * Tests running "update items" from 'admin/config/services/aggregator' page.
-   */
-  public function testUpdateFeedItem() {
-    $this->createSampleNodes();
-
-    // Create a feed and test updating feed items if possible.
-    $feed = $this->createFeed();
-    if (!empty($feed)) {
-      $this->updateFeedItems($feed, $this->getDefaultFeedItemCount());
-      $this->deleteFeedItems($feed);
-    }
-
-    // Delete feed.
-    $this->deleteFeed($feed);
-
-    // Test updating feed items without valid timestamp information.
-    $edit = array(
-      'title[0][value]' => "Feed without publish timestamp",
-      'url[0][value]' => $this->getRSS091Sample(),
-    );
-
-    $this->drupalGet($edit['url[0][value]']);
-    $this->assertResponse(200);
-
-    $this->drupalPostForm('aggregator/sources/add', $edit, t('Save'));
-    $this->assertRaw(t('The feed %name has been added.', array('%name' => $edit['title[0][value]'])), format_string('The feed @name has been added.', array('@name' => $edit['title[0][value]'])));
-
-    $fid = db_query("SELECT fid FROM {aggregator_feed} WHERE url = :url", array(':url' => $edit['url[0][value]']))->fetchField();
-    $feed = Feed::load($fid);
-
-    $feed->refreshItems();
-    $before = db_query('SELECT timestamp FROM {aggregator_item} WHERE fid = :fid', array(':fid' => $feed->id()))->fetchField();
-
-    // Sleep for 3 second.
-    sleep(3);
-    db_update('aggregator_feed')
-      ->condition('fid', $feed->id())
-      ->fields(array(
-        'checked' => 0,
-        'hash' => '',
-        'etag' => '',
-        'modified' => 0,
-      ))
-      ->execute();
-    $feed->refreshItems();
-
-    $after = db_query('SELECT timestamp FROM {aggregator_item} WHERE fid = :fid', array(':fid' => $feed->id()))->fetchField();
-    $this->assertTrue($before === $after, format_string('Publish timestamp of feed item was not updated (@before === @after)', array('@before' => $before, '@after' => $after)));
-
-    // Make sure updating items works even after uninstalling a module
-    // that provides the selected plugins.
-    $this->enableTestPlugins();
-    $this->container->get('module_installer')->uninstall(array('aggregator_test'));
-    $this->updateFeedItems($feed);
-    $this->assertResponse(200);
-  }
-
-}

core/modules/aggregator/src/Tests/UpdateFeedTest.php

@@ -1,46 +0,0 @@
-<?php
-
-namespace Drupal\aggregator\Tests;
-
-/**
- * Update feed test.
- *
- * @group aggregator
- */
-class UpdateFeedTest extends AggregatorTestBase {
-  /**
-   * Creates a feed and attempts to update it.
-   */
-  public function testUpdateFeed() {
-    $remaining_fields = array('title[0][value]', 'url[0][value]', '');
-    foreach ($remaining_fields as $same_field) {
-      $feed = $this->createFeed();
-
-      // Get new feed data array and modify newly created feed.
-      $edit = $this->getFeedEditArray();
-      // Change refresh value.
-      $edit['refresh'] = 1800;
-      if (isset($feed->{$same_field}->value)) {
-        $edit[$same_field] = $feed->{$same_field}->value;
-      }
-      $this->drupalPostForm('aggregator/sources/' . $feed->id() . '/configure', $edit, t('Save'));
-      $this->assertRaw(t('The feed %name has been updated.', array('%name' => $edit['title[0][value]'])), format_string('The feed %name has been updated.', array('%name' => $edit['title[0][value]'])));
-
-      // Check feed data.
-      $this->assertUrl($feed->url('canonical', ['absolute' => TRUE]));
-      $this->assertTrue($this->uniqueFeed($edit['title[0][value]'], $edit['url[0][value]']), 'The feed is unique.');
-
-      // Check feed source.
-      $this->drupalGet('aggregator/sources/' . $feed->id());
-      $this->assertResponse(200, 'Feed source exists.');
-      $this->assertText($edit['title[0][value]'], 'Page title');
-
-      // Set correct title so deleteFeed() will work.
-      $feed->title = $edit['title[0][value]'];
-
-      // Delete feed.
-      $this->deleteFeed($feed);
-    }
-  }
-
-}

core/modules/aggregator/tests/modules/aggregator_test/aggregator_test.info.yml

@@ -5,8 +5,8 @@ package: Testing
 # version: VERSION
 # core: 8.x
 
-# Information added by Drupal.org packaging script on 2017-11-03
-version: '8.4.2'
+# Information added by Drupal.org packaging script on 2018-01-03
+version: '8.4.4'
 core: '8.x'
 project: 'drupal'
-datestamp: 1509719929
+datestamp: 1515021228

core/modules/aggregator/tests/modules/aggregator_test_views/aggregator_test_views.info.yml

@@ -8,8 +8,8 @@ dependencies:
   - aggregator
   - views
 
-# Information added by Drupal.org packaging script on 2017-11-03
-version: '8.4.2'
+# Information added by Drupal.org packaging script on 2018-01-03
+version: '8.4.4'
 core: '8.x'
 project: 'drupal'
-datestamp: 1509719929
+datestamp: 1515021228

core/modules/aggregator/tests/src/Functional/Update/AggregatorUpdateTest.php

@@ -38,4 +38,21 @@ class AggregatorUpdateTest extends UpdatePathTestBase {
     $this->assertTrue($field_definition->isRequired());
   }
 
+  /**
+   * Tests that the 'Update interval' field has a default value.
+   */
+  public function testUpdateIntervalDefaultValue() {
+    // Check that the 'refresh' field does not have a default value prior to the
+    // update.
+    $field_definition = \Drupal::entityDefinitionUpdateManager()->getFieldStorageDefinition('refresh', 'aggregator_feed');
+    $this->assertSame([], $field_definition->getDefaultValueLiteral());
+
+    // Run updates.
+    $this->runUpdates();
+
+    // Check that the 'refresh' has a default value now.
+    $field_definition = \Drupal::entityDefinitionUpdateManager()->getFieldStorageDefinition('refresh', 'aggregator_feed');
+    $this->assertSame([['value' => 3600]], $field_definition->getDefaultValueLiteral());
+  }
+
 }

core/modules/aggregator/tests/src/Unit/Plugin/AggregatorPluginSettingsBaseTest.php

@@ -109,5 +109,6 @@ class AggregatorPluginSettingsBaseTest extends UnitTestCase {
 namespace Drupal\Core\Form;
 
 if (!function_exists('drupal_set_message')) {
-  function drupal_set_message() {}
+  function drupal_set_message() {
+  }
 }

core/modules/aggregator/tests/src/Unit/Plugin/migrate/source/AggregatorItemTest.php

@@ -1,44 +0,0 @@
-<?php
-
-namespace Drupal\Tests\aggregator\Unit\Plugin\migrate\source;
-
-use Drupal\Tests\migrate\Unit\MigrateSqlSourceTestCase;
-
-/**
- * Tests aggregator item source plugin.
- *
- * @group aggregator
- */
-class AggregatorItemTest extends MigrateSqlSourceTestCase {
-
-  const PLUGIN_CLASS = 'Drupal\aggregator\Plugin\migrate\source\AggregatorItem';
-
-  protected $migrationConfiguration = array(
-    'id' => 'test',
-    'source' => array(
-      'plugin' => 'aggregator_item',
-    ),
-  );
-
-  protected $expectedResults = array(
-    array(
-      'iid' => 1,
-      'fid' => 1,
-      'title' => 'This (three) weeks in Drupal Core - January 10th 2014',
-      'link' => 'https://groups.drupal.org/node/395218',
-      'author' => 'larowlan',
-      'description' => "<h2 id='new'>What's new with Drupal 8?</h2>",
-      'timestamp' => 1389297196,
-      'guid' => '395218 at https://groups.drupal.org',
-    ),
-  );
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    $this->databaseContents['aggregator_item'] = $this->expectedResults;
-    parent::setUp();
-  }
-
-}

core/modules/aggregator/tests/src/Unit/Plugin/migrate/source/d6/AggregatorFeedTest.php

@@ -1,60 +0,0 @@
-<?php
-
-namespace Drupal\Tests\aggregator\Unit\Plugin\migrate\source\d6;
-
-use Drupal\Tests\migrate\Unit\MigrateSqlSourceTestCase;
-
-/**
- * Tests D6 aggregator feed source plugin.
- *
- * @group aggregator
- */
-class AggregatorFeedTest extends MigrateSqlSourceTestCase {
-
-  const PLUGIN_CLASS = 'Drupal\aggregator\Plugin\migrate\source\AggregatorFeed';
-
-  protected $migrationConfiguration = array(
-    'id' => 'test',
-    'source' => array(
-      'plugin' => 'd6_aggregator_feed',
-    ),
-  );
-
-  protected $expectedResults = array(
-    array(
-      'fid' => 1,
-      'title' => 'feed title 1',
-      'url' => 'http://example.com/feed.rss',
-      'refresh' => 900,
-      'checked' => 0,
-      'link' => 'http://example.com',
-      'description' => 'A vague description',
-      'image' => '',
-      'etag' => '',
-      'modified' => 0,
-      'block' => 5,
-    ),
-    array(
-      'fid' => 2,
-      'title' => 'feed title 2',
-      'url' => 'http://example.net/news.rss',
-      'refresh' => 1800,
-      'checked' => 0,
-      'link' => 'http://example.net',
-      'description' => 'An even more vague description',
-      'image' => '',
-      'etag' => '',
-      'modified' => 0,
-      'block' => 5,
-    ),
-  );
-
-  /**
-  * {@inheritdoc}
-  */
-  protected function setUp() {
-    $this->databaseContents['aggregator_feed'] = $this->expectedResults;
-    parent::setUp();
-  }
-
-}

core/modules/aggregator/tests/src/Unit/Plugin/migrate/source/d7/AggregatorFeedTest.php

@@ -1,62 +0,0 @@
-<?php
-
-namespace Drupal\Tests\aggregator\Unit\Plugin\migrate\source\d7;
-
-use Drupal\Tests\migrate\Unit\MigrateSqlSourceTestCase;
-
-/**
- * Tests D7 aggregator feed source plugin.
- *
- * @group aggregator
- */
-class AggregatorFeedTest extends MigrateSqlSourceTestCase {
-
-  const PLUGIN_CLASS = 'Drupal\aggregator\Plugin\migrate\source\AggregatorFeed';
-
-  protected $migrationConfiguration = array(
-    'id' => 'test',
-    'source' => array(
-      'plugin' => 'd7_aggregator_feed',
-    ),
-  );
-
-  protected $expectedResults = array(
-    array(
-      'fid' => 1,
-      'title' => 'feed title 1',
-      'url' => 'http://example.com/feed.rss',
-      'refresh' => 900,
-      'checked' => 0,
-      'queued' => 0,
-      'link' => 'http://example.com',
-      'description' => 'A vague description',
-      'image' => '',
-      'etag' => '',
-      'modified' => 0,
-      'block' => 5,
-    ),
-    array(
-      'fid' => 2,
-      'title' => 'feed title 2',
-      'url' => 'http://example.net/news.rss',
-      'refresh' => 1800,
-      'checked' => 0,
-      'queued' => 0,
-      'link' => 'http://example.net',
-      'description' => 'An even more vague description',
-      'image' => '',
-      'etag' => '',
-      'modified' => 0,
-      'block' => 5,
-    ),
-  );
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function setUp() {
-    $this->databaseContents['aggregator_feed'] = $this->expectedResults;
-    parent::setUp();
-  }
-
-}