updated core from 8.4 to 8.5 : bug with login_destination

core/modules/path/src/Form/AddForm.php

@@ -6,6 +6,8 @@ use Drupal\Core\Language\LanguageInterface;
 
 /**
  * Provides the path add form.
+ *
+ * @internal
  */
 class AddForm extends PathFormBase {
 

core/modules/path/src/Form/DeleteForm.php

@@ -10,6 +10,8 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**
  * Builds the form to delete a path alias.
+ *
+ * @internal
  */
 class DeleteForm extends ConfirmFormBase {
 

core/modules/path/src/Form/EditForm.php

@@ -7,6 +7,8 @@ use Drupal\Core\Url;
 
 /**
  * Provides the path edit form.
+ *
+ * @internal
  */
 class EditForm extends PathFormBase {
 

core/modules/path/src/Form/PathFilterForm.php

@@ -7,6 +7,8 @@ use Drupal\Core\Form\FormStateInterface;
 
 /**
  * Provides the path admin overview filter form.
+ *
+ * @internal
  */
 class PathFilterForm extends FormBase {
 
@@ -30,7 +32,7 @@ class PathFilterForm extends FormBase {
     ];
     $form['basic']['filter'] = [
       '#type' => 'search',
-      '#title' => 'Path alias',
+      '#title' => $this->t('Path alias'),
       '#title_display' => 'invisible',
       '#default_value' => $keys,
       '#maxlength' => 128,

core/modules/path/src/Form/PathFormBase.php

@@ -192,7 +192,7 @@ abstract class PathFormBase extends FormBase {
     }
 
     if (!$this->pathValidator->isValid(trim($source, '/'))) {
-      $form_state->setErrorByName('source', t("The path '@link_path' is either invalid or you do not have access to it.", ['@link_path' => $source]));
+      $form_state->setErrorByName('source', t("Either the path '@link_path' is invalid or you do not have access to it.", ['@link_path' => $source]));
     }
   }
 

core/modules/path/src/Plugin/Field/FieldType/PathItem.php

@@ -89,7 +89,7 @@ class PathItem extends FieldItemBase {
    */
   public static function generateSampleValue(FieldDefinitionInterface $field_definition) {
     $random = new Random();
-    $values['alias'] = str_replace(' ', '-', strtolower($random->sentences(3)));
+    $values['alias'] = '/' . str_replace(' ', '-', strtolower($random->sentences(3)));
     return $values;
   }